On 2014-01-19 20:29:40, akbjker wrote:
> >From a first look at it, this leaks all old GtkAlignment instances on every
> >page_widget_set_mode call.
>
> Whoops, you're right. I misunderstood the purpose of gtk_widget_reparent.
>
> Here's the patch v2.
Thank you. I've pushed it for now. We probab
>From a first look at it, this leaks all old GtkAlignment instances on every
>page_widget_set_mode call.
Whoops, you're right. I misunderstood the purpose of gtk_widget_reparent.
Here's the patch v2.
diff --git a/zathura.c b/zathura.c
index 75aabc5..49a78b0 100644
--- a/zathura.c
+++ b/zathura.c
On 2014-01-18 02:08:04, akbjker wrote:
> diff --git a/zathura.c b/zathura.c
> index 1f5f4fd..5335def 100644
> --- a/zathura.c
> +++ b/zathura.c
> @@ -943,10 +943,6 @@ document_close(zathura_t* zathura, bool keep_monitor)
>
>/* remove widgets */
>gtk_container_foreach(GTK_CONTAINER(zathura
On 2014-01-19 17:12:09, akbjker wrote:
> Basically, all of the ZathuraPages get resized to the largest one, and
> GtkDrawingArea's default background color gets drawn in the leftover
> space of the smaller pages.
> It's more noticeable when pages are grossly different sizes, like in
> this attached
On 2014-01-18 02:08:04, akbjker wrote:
> Quick patch to center-align pages that have different sizes.
> Also fixes a bug that forces all the ZathuraPages to the size of the
> largest one, therefore causing GTK's default background color to be
> drawn instead of the one set in zathurarc.
>
> This f
