Re: [Zaurus-devel] gpio_keys and how PXA27x sets gpio_set_wake() (was Re: sharp c-3000 aka spitz: fix warn_on introduced in 2.6.32-rc1)

2010-01-26 Thread Stanislav Brabec
Eric Miao wrota: > I prefer 2) - the ugly and hardcoded setup in spitz_pm.c should really > be removed. That's why the gpio_set_wake() and keypad_set_wake() > are introduced. I am unsure, whether gpio_keys driver is interested in the way, how wake happens. I guess that is interested only in the f

Re: [Zaurus-devel] gpio_keys and how PXA27x sets gpio_set_wake() (was Re: sharp c-3000 aka spitz: fix warn_on introduced in 2.6.32-rc1)

2010-01-26 Thread Eric Miao
2010/1/26 Stanislav Brabec : > Eric Miao wrota: > >> I prefer 2) - the ugly and hardcoded setup in spitz_pm.c should really >> be removed. That's why the gpio_set_wake() and keypad_set_wake() >> are introduced. > > I am unsure, whether gpio_keys driver is interested in the way, how wake > happens.

Re: [Zaurus-devel] gpio_keys and how PXA27x sets gpio_set_wake() (was Re: sharp c-3000 aka spitz: fix warn_on introduced in 2.6.32-rc1)

2010-01-26 Thread Stanislav Brabec
Eric Miao wrote: > 2010/1/26 Stanislav Brabec : > > Handling platform specific edge/level wake setup would only complicate > > the code. (In fact, even the PXA270 platform code does not exist yet - > > arch/arm/mach-pxa/mfp-pxa2xx.c:__mfp_config_gpio() is not capable to > > configure Power Manager

[Zaurus-devel] pxa25x - corgi vs. 2.6.33-rc5

2010-01-26 Thread Andrea Adami
Hello, I'm following (without understanding too much..) the thread about spitz keyboard/GPIO. I'd just like to report on my Zaurus SL-C860 the power on/off has no reaction with following mini-config: http://cgit.openembedded.org/cgit.cgi/openembedded/tree/recipes/kexecboot/linux-kexecboot-2.6.32

Re: [Zaurus-devel] gpio_keys and how PXA27x sets gpio_set_wake() (was Re: sharp c-3000 aka spitz: fix warn_on introduced in 2.6.32-rc1)

2010-01-26 Thread Dmitry Eremin-Solenikov
Hello, 2010/1/26 Stanislav Brabec : > Eric Miao wrote: >> > The problem affects gpio_keys: It is a driver implementing "one key per >> > gpio". It now handles On/Off and lid switches on Zaurus. Lid switches >> > are on "normal" GPIOs, On/Off switch is wired to PKWR capable GPIO. >> Ain't On/Off sw

Re: [Zaurus-devel] gpio_keys and how PXA27x sets gpio_set_wake() (was Re: sharp c-3000 aka spitz: fix warn_on introduced in 2.6.32-rc1)

2010-01-26 Thread Eric Miao
2010/1/26 Stanislav Brabec : > Eric Miao wrote: >> 2010/1/26 Stanislav Brabec : > >> > Handling platform specific edge/level wake setup would only complicate >> > the code. (In fact, even the PXA270 platform code does not exist yet - >> > arch/arm/mach-pxa/mfp-pxa2xx.c:__mfp_config_gpio() is not ca

Re: [Zaurus-devel] pxa25x - corgi vs. 2.6.33-rc5

2010-01-26 Thread Eric Miao
On Tue, Jan 26, 2010 at 6:47 PM, Andrea Adami wrote: > Hello, > > I'm following (without understanding too much..)  the thread about > spitz keyboard/GPIO. > > I'd just like to report on my Zaurus SL-C860 the power on/off has no > reaction with following mini-config: > http://cgit.openembedded.org

Re: [Zaurus-devel] gpio_keys and how PXA27x sets gpio_set_wake() (was Re: sharp c-3000 aka spitz: fix warn_on introduced in 2.6.32-rc1)

2010-01-26 Thread Stanislav Brabec
Eric Miao wrote: > 2010/1/26 Stanislav Brabec : > > Eric Miao wrote: > >> 2010/1/26 Stanislav Brabec : > > > >> > Handling platform specific edge/level wake setup would only complicate > >> > the code. (In fact, even the PXA270 platform code does not exist yet - > >> > arch/arm/mach-pxa/mfp-pxa2xx.