[Zeitgeist] [Merge] lp:~ev/activity-log-manager/add-whoopsie-back into lp:activity-log-manager

2013-06-19 Thread noreply
The proposal to merge lp:~ev/activity-log-manager/add-whoopsie-back into lp:activity-log-manager has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~ev/activity-log-manager/add-whoopsie-back/+merge/169855 -- https://code.launchpad.net/~ev/acti

Re: [Zeitgeist] [Merge] lp:~ev/activity-log-manager/add-whoopsie-back into lp:activity-log-manager

2013-06-19 Thread मनीष सिन्हा
Review: Approve This fixes it. I guess it was solved by - extern void* whoopsie_daisy_preferences_new (void); + extern GtkWidget* whoopsie_daisy_preferences_new (void); I will still check it on another developer installation before merging -- https://code.launchpad.net/~ev/activity-log-manager/

Re: [Zeitgeist] [Merge] lp:~ev/activity-log-manager/add-whoopsie-back into lp:activity-log-manager

2013-06-19 Thread Evan Dandrea
So whoopsie_daisy_preferences_new () is returning an invalid type from the looks of it. Can you please build from my branch with the latest commits (r53) and try again? It should output something like "GType: 258458288" but will probably give you something bogus. Bonus points if you can use gdb

Re: [Zeitgeist] [Merge] lp:~ev/activity-log-manager/add-whoopsie-back into lp:activity-log-manager

2013-06-18 Thread मनीष सिन्हा
Used the debdiff and built the packages locally and installed it. Sadly, crashes again with exactly the same backtrace -- https://code.launchpad.net/~ev/activity-log-manager/add-whoopsie-back/+merge/169855 Your team Activity Log Manager is subscribed to branch lp:activity-log-manager. __

Re: [Zeitgeist] [Merge] lp:~ev/activity-log-manager/add-whoopsie-back into lp:activity-log-manager

2013-06-18 Thread मनीष सिन्हा
Hello Evan, I am still getting crashes on another system, with backtrace Program received signal SIGSEGV, Segmentation fault. g_type_check_instance_cast (type_instance=0xe8006e00, iface_type=iface_type@entry=93824994480816) at /build/buildd/glib2.0-2.36.0/./gobject/gtype.c:4027 4027/

Re: [Zeitgeist] [Merge] lp:~ev/activity-log-manager/add-whoopsie-back into lp:activity-log-manager

2013-06-18 Thread Evan Dandrea
I can also confirm this works well with Jeremy's debdiff: https://bugs.launchpad.net/ubuntu/+source/activity-log-manager/+bug/1189253/+attachment/3699264/+files/update-to-0.9.5.debdiff -- https://code.launchpad.net/~ev/activity-log-manager/add-whoopsie-back/+merge/169855 Your team Activity Log Ma

Re: [Zeitgeist] [Merge] lp:~ev/activity-log-manager/add-whoopsie-back into lp:activity-log-manager

2013-06-18 Thread Evan Dandrea
I've implemented the define for whoopsie in a slightly different way. It is working fine for me when I build it in a deb and install that way. Can you please build with debugging symbols and provide a backtrace? -- https://code.launchpad.net/~ev/activity-log-manager/add-whoopsie-back/+merge/1698

Re: [Zeitgeist] [Merge] lp:~ev/activity-log-manager/add-whoopsie-back into lp:activity-log-manager

2013-06-18 Thread मनीष सिन्हा
Sorry, here is the branch where I pushed the minor changes with your merged branch lp:~manishsinha/activity-log-manager/ev -- https://code.launchpad.net/~ev/activity-log-manager/add-whoopsie-back/+merge/169855 Your team Activity Log Manager is subscribed to branch lp:activity-log-manager. __

Re: [Zeitgeist] [Merge] lp:~ev/activity-log-manager/add-whoopsie-back into lp:activity-log-manager

2013-06-18 Thread मनीष सिन्हा
I tried it in a VM and I did not get any Segfault. Now this is weird. Evan, can you try it out with the above changes I mentioned -- https://code.launchpad.net/~ev/activity-log-manager/add-whoopsie-back/+merge/169855 Your team Activity Log Manager is subscribed to branch lp:activity-log-manager.

Re: [Zeitgeist] [Merge] lp:~ev/activity-log-manager/add-whoopsie-back into lp:activity-log-manager

2013-06-17 Thread मनीष सिन्हा
#1 0x7fffb99244b0 in alm_main_window_panel_init (self=0x557b9b40) at alm-cc.c:63 line 63 is GtkWidget *whoopsie = GTK_WIDGET (whoopsie_daisy_preferences_new ()); tells that the issue is with macro GTK_WIDGET since if the problem was with whoopsie_daisy_preferences_new () then the backtr

Re: [Zeitgeist] [Merge] lp:~ev/activity-log-manager/add-whoopsie-back into lp:activity-log-manager

2013-06-17 Thread मनीष सिन्हा
I did some more research and found that in alm-cc.c file, inside function "alm_main_window_panel_init" the #ifdef section is not being called. I tried fixing that with changing #ifdef HAVE_WHOOPSIE to #ifdef WHOOPSIE and changing in src/Makefile.am if HAVE_WHOOPSIE libactivity_log_manager_la_C

Re: [Zeitgeist] [Merge] lp:~ev/activity-log-manager/add-whoopsie-back into lp:activity-log-manager

2013-06-17 Thread मनीष सिन्हा
Review: Needs Fixing It looks good, but still doesn't show up in System Settings. http://i.imgur.com/xCTk5bR.png -- https://code.launchpad.net/~ev/activity-log-manager/add-whoopsie-back/+merge/169855 Your team Activity Log Manager is subscribed to branch lp:activity-log-manager. ___

[Zeitgeist] [Merge] lp:~ev/activity-log-manager/add-whoopsie-back into lp:activity-log-manager

2013-06-17 Thread Evan Dandrea
Evan Dandrea has proposed merging lp:~ev/activity-log-manager/add-whoopsie-back into lp:activity-log-manager. Requested reviews: Activity Log Manager (activity-log-manager) For more details, see: https://code.launchpad.net/~ev/activity-log-manager/add-whoopsie-back/+merge/169855 This resurrec