[Zeitgeist] [Merge] lp:~mhr3/zeitgeist/fts-secondary-sorting into lp:zeitgeist

2012-03-14 Thread noreply
The proposal to merge lp:~mhr3/zeitgeist/fts-secondary-sorting into lp:zeitgeist has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~mhr3/zeitgeist/fts-secondary-sorting/+merge/96479 -- https://code.launchpad.net/~mhr3/zeitgeist/fts-secondary-

Re: [Zeitgeist] [Merge] lp:~mhr3/zeitgeist/fts-secondary-sorting into lp:zeitgeist

2012-03-11 Thread Michal Hruby
I wouldn't really like to change the semantics of the Search() method, somehow magically it approximates the results quite ok (plus it'd be weird if _SUBJECTS groupings worked perfectly and the others just ok-ish). -- https://code.launchpad.net/~mhr3/zeitgeist/fts-secondary-sorting/+merge/96479

Re: [Zeitgeist] [Merge] lp:~mhr3/zeitgeist/fts-secondary-sorting into lp:zeitgeist

2012-03-11 Thread Siegfried Gevatter
By the way, doesn't the same need to be done for Indexer::Search()? -- https://code.launchpad.net/~mhr3/zeitgeist/fts-secondary-sorting/+merge/96479 Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist. ___ Mailing list: https://launc

Re: [Zeitgeist] [Merge] lp:~mhr3/zeitgeist/fts-secondary-sorting into lp:zeitgeist

2012-03-11 Thread Siegfried Gevatter
Review: Approve OK! * "Only ANY storage state is supported" This sounds a bit weird, maybe it'd make it "Only storage state ANY is supported". -- https://code.launchpad.net/~mhr3/zeitgeist/fts-secondary-sorting/+merge/96479 Your team Zeitgeist Framework Team is subscribed to branch lp:zeitge

Re: [Zeitgeist] [Merge] lp:~mhr3/zeitgeist/fts-secondary-sorting into lp:zeitgeist

2012-03-11 Thread Michal Hruby
So, how about now? -- https://code.launchpad.net/~mhr3/zeitgeist/fts-secondary-sorting/+merge/96479 Your team Zeitgeist Framework Team is requested to review the proposed merge of lp:~mhr3/zeitgeist/fts-secondary-sorting into lp:zeitgeist. ___ Mailing

Re: [Zeitgeist] [Merge] lp:~mhr3/zeitgeist/fts-secondary-sorting into lp:zeitgeist

2012-03-08 Thread Siegfried Gevatter
As discussed on IRC, I don't really like how this is ending up. We should look into re-architecting FTS at some point, starting from the assumption that it's only for searching current documents (so it may change from storing all events to storing one of each subjects + event information, or wha

Re: [Zeitgeist] [Merge] lp:~mhr3/zeitgeist/fts-secondary-sorting into lp:zeitgeist

2012-03-08 Thread Michal Hruby
I'm starting to think that doing the secondary sorting in FTS isn't a good idea, we're sending the relevancies to the client, so we should keep the full Zeitgeist sorting, and since the client has the relevancies, it can do this kind of sort itself (or not). -- https://code.launchpad.net/~mhr3/

[Zeitgeist] [Merge] lp:~mhr3/zeitgeist/fts-secondary-sorting into lp:zeitgeist

2012-03-07 Thread Michal Hruby
Michal Hruby has proposed merging lp:~mhr3/zeitgeist/fts-secondary-sorting into lp:zeitgeist. Requested reviews: Zeitgeist Framework Team (zeitgeist) For more details, see: https://code.launchpad.net/~mhr3/zeitgeist/fts-secondary-sorting/+merge/96479 Implements secondary sorting based on Resu