Review: Approve
Great job as always, thanks!
--
https://code.launchpad.net/~rainct/zeitgeist/ignore-ubuntuone-actor/+merge/99986
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.
___
Mailing list:
The proposal to merge lp:~rainct/zeitgeist/ignore-ubuntuone-actor into
lp:zeitgeist has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~rainct/zeitgeist/ignore-ubuntuone-actor/+merge/99986
--
https://code.launchpad.net/~rainct/zeitgeist
The proposal to merge lp:~rainct/zeitgeist/ignore-ubuntuone-actor into
lp:zeitgeist has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~rainct/zeitgeist/ignore-ubuntuone-actor/+merge/99986
--
https://code.launchpad.net/~rainct/zeitgeist/ignore
Review: Needs Fixing
Can we add an envvar which would control the ignoring (ignore by default)? Plus
can we change the primary template when doing reindex, so we don't grab the U1
events in the first place?
--
https://code.launchpad.net/~rainct/zeitgeist/ignore-ubuntuone-actor/+merge/99986
8 + // Blacklist Ubuntu One events...
9 + const gchar *actor;
10 + actor = zeitgeist_event_get_actor (event);
11 + if (strcmp(actor, dbus://com.ubuntuone.SyncDaemon.service) == 0)
12 + return;
13 + if (strcmp(actor, dbus://org.desktopcouch.CouchDB.service) == 0)
14
Another benefit of a separate function is also that we can unit test the
function directly as well.
--
https://code.launchpad.net/~rainct/zeitgeist/ignore-ubuntuone-actor/+merge/99986
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.
decided to skip the u1 events when indexing
mhr3_ (they can be uniquely identified by actor)
--
https://code.launchpad.net/~rainct/zeitgeist/ignore-ubuntuone-actor/+merge/99986
Your team Zeitgeist Framework Team is requested to review the proposed merge of
lp:~rainct/zeitgeist/ignore-ubuntuone-actor
7 matches
Mail list logo
