[Zeitgeist] [Bug 495179] Re: What to do on failed or blocked event insertions?

I'm preparing a branch with the solution proposed by Mikkel, as this solution has the best (making sense)/(breaking API) ratio. ** Changed in: zeitgeist Assignee: (unassigned) = Markus Korn (thekorn) -- What to do on failed or blocked event insertions?

[Zeitgeist] [Bug 495179] Re: What to do on failed or blocked event insertions?

thanks for your super fast code review. I've changed the method name and fixed some engine-testcases (Exceptions are not raised anymore, 0 is returned instead) If nobody complains until lunchtime I will merge this branch into lp:zeitgeist. This branch fixes only half of the issue, we also need a

[Zeitgeist] [Bug 495179] Re: What to do on failed or blocked event insertions?

** Branch linked: lp:zeitgeist -- What to do on failed or blocked event insertions? https://bugs.launchpad.net/bugs/495179 You received this bug notification because you are a member of Zeitgeist Framework, which is the registrant for Zeitgeist Framework. Status in Zeitgeist Framework: Fix

[Zeitgeist] [Bug 495179] Re: What to do on failed or blocked event insertions?

** Changed in: zeitgeist Status: Confirmed = Fix Committed -- What to do on failed or blocked event insertions? https://bugs.launchpad.net/bugs/495179 You received this bug notification because you are a member of Zeitgeist Framework, which is the registrant for Zeitgeist Framework.

[Zeitgeist] [Bug 495017] Re: AttributeError: 'NoneType' object has no attribute 'payload'

** Changed in: zeitgeist Status: Fix Committed = Fix Released -- AttributeError: 'NoneType' object has no attribute 'payload' https://bugs.launchpad.net/bugs/495017 You received this bug notification because you are a member of Zeitgeist Framework, which is the registrant for Zeitgeist

[Zeitgeist] [Bug 495392] Re: What to do if an event is not found or blocked when calling GetEvents (or its engine equivalent)

Looks good. I suppose that just doing «NULL_EVENT = ([], [], )» instead of all this D-Bus fuss didn't work? Also, personally I'd change: = if event is None: continue event._make_dbus_sendable() = to: = if event: event._make_dbus_sendable() = But this is just nitpicking

[Zeitgeist] [Bug 494288] Re: apriori: get most used (websites/notes/documents/etc...)

Okay, this is now merged into lp:zeitgeist (after doing some more changes and having Markus review it again), but of course this doesn't mean that we can't continue improving it there (all the opposite!). You are right. I think a hybrid approach would give the best results Yeah. But for this we

[Zeitgeist] [Bug 494288] Re: apriori: get most used (websites/notes/documents/etc...)

** Branch linked: lp:zeitgeist -- apriori: get most used (websites/notes/documents/etc...) https://bugs.launchpad.net/bugs/494288 You received this bug notification because you are a member of Zeitgeist Developers, which is the registrant for Zeitgeist Framework. Status in Zeitgeist Framework:

[Zeitgeist] [Bug 495392] Re: What to do if an event is not found or blocked when calling GetEvents (or its engine equivalent)

I addressed both your comments in revision 1225, thanks for the review. -- What to do if an event is not found or blocked when calling GetEvents (or its engine equivalent) https://bugs.launchpad.net/bugs/495392 You received this bug notification because you are a member of Zeitgeist Developers,