Review: Disapprove
Seif,
I don't like the way this bug is fixed in your branch, sorry.
First of all you are using blank try:...except:... blocks, and you are putting
too much code in this exception handlers, which makes the code unreadable.
I propose this diff:
=== modified file 'extra/PythonSe
Hello Zeitgeist Framework Team,
On 2010-08-31 20:58z (18 minutes ago), you uploaded a translation
template for zeitgeist in Zeitgeist Framework 0.3 in Launchpad.
The template has now been imported successfully.
Thank you,
The Launchpad team
___
Mail
Hello Zeitgeist Framework Team,
On 2010-08-31 20:58z (13 minutes ago), you uploaded a translation
template for zeitgeist in Zeitgeist Framework 0.1 in Launchpad.
The template has now been imported successfully.
Thank you,
The Launchpad team
___
Mail
i put up a branch here lp:~zeitgeist/zeitgeist/rdflib3
** Changed in: zeitgeist
Assignee: (unassigned) => Seif Lotfy (seif)
--
Fix build with rdflib 3
https://bugs.launchpad.net/bugs/626224
You received this bug notification because you are a member of Zeitgeist
Framework Team, which is su
Seif Lotfy has proposed merging lp:~zeitgeist/zeitgeist/rdflib3 into
lp:zeitgeist.
Requested reviews:
Zeitgeist Framework Team (zeitgeist)
I added some try and excepts to extend to patch given
this way we can work with both rdflib 2 and 3
--
https://code.launchpad.net/~zeitgeist/zeitgeist/r
** Changed in: zeitgeist
Status: Fix Committed => Fix Released
--
searching with subject_storage in template is not working
https://bugs.launchpad.net/bugs/580364
You received this bug notification because you are a member of Zeitgeist
Framework Team, which is subscribed to Zeitgeist Frame
The proposal to merge lp:~zeitgeist/zeitgeist/bug580364 into lp:zeitgeist has
been updated.
Status: Needs review => Merged
--
https://code.launchpad.net/~zeitgeist/zeitgeist/bug580364/+merge/34141
Your team Zeitgeist Framework Team is subscribed to branch
lp:~zeitgeist/zeitgeist/bug580364.
ok done :)
--
https://code.launchpad.net/~zeitgeist/zeitgeist/bug580364/+merge/34141
Your team Zeitgeist Framework Team is subscribed to branch
lp:~zeitgeist/zeitgeist/bug580364.
___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeis
Review: Needs Fixing
Ok, I cave in, fix the things mentioned by Mikkel, run the testsuite and if
everything goes well merge it into lp:zeitgeist (but please don't *bzr pull*)
--
https://code.launchpad.net/~zeitgeist/zeitgeist/bug580364/+merge/34141
Your team Zeitgeist Framework Team is subscribed
Review: Needs Fixing
Well, I disagree with Markus :-) I think it makes perfect sense to include this
- otherwise we have a chicken-and-egg problem.
In theory anyone could set the storage field upon item insertion. It just so
happens that the DS we ship is not feature complete. On top of that, 3r
10 matches
Mail list logo
