[Gnome-zeitgeist] [Bug 715910] Re: Allow to attach a note to documents
** Changed in: gnome-activity-journal Assignee: (unassigned) = Stefano Candori (cando) ** Changed in: gnome-activity-journal Status: Confirmed = In Progress -- You received this bug notification because you are a member of GNOME Zeitgeist Team, which is the registrant for GNOME Activity Journal. https://bugs.launchpad.net/bugs/715910 Title: Allow to attach a note to documents Status in GNOME Activity Journal: In Progress Bug description: I'd be great to have a way to attach a small note to a (pinned) documents. For example, I've pinned a document to review tomorrow and I'd like to attach a note saying Review the document layout. ___ Mailing list: https://launchpad.net/~gnome-zeitgeist Post to : gnome-zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~gnome-zeitgeist More help : https://help.launchpad.net/ListHelp
[Gnome-zeitgeist] [Bug 716396] [NEW] Add new Month view
Public bug reported: Dave_largo in IRC suggested the creation of a new Month view. Something like that: http://imagebin.org/137155. ** Affects: gnome-activity-journal Importance: Wishlist Status: Confirmed ** Changed in: gnome-activity-journal Status: New = Confirmed ** Changed in: gnome-activity-journal Importance: Undecided = Low ** Changed in: gnome-activity-journal Status: Confirmed = Invalid ** Changed in: gnome-activity-journal Importance: Low = Wishlist ** Changed in: gnome-activity-journal Status: Invalid = Confirmed -- You received this bug notification because you are a member of GNOME Zeitgeist Team, which is the registrant for GNOME Activity Journal. https://bugs.launchpad.net/bugs/716396 Title: Add new Month view Status in GNOME Activity Journal: Confirmed Bug description: Dave_largo in IRC suggested the creation of a new Month view. Something like that: http://imagebin.org/137155. ___ Mailing list: https://launchpad.net/~gnome-zeitgeist Post to : gnome-zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~gnome-zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 695363] Re: Python API doesn't expose DataSourceRegistry's enabled status
** Changed in: zeitgeist Status: New = Fix Committed -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/695363 Title: Python API doesn't expose DataSourceRegistry's enabled status Status in Zeitgeist Framework: Fix Committed Bug description: def set_data_source_enabled_callback(self, enabled_callback): [...] # TODO: Make it possible to access the return value! ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 704931] Re: Publish property names, accesslevel and type in introspection data
** Changed in: zeitgeist Milestone: None = 0.8.0 -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/704931 Title: Publish property names, accesslevel and type in introspection data Status in Zeitgeist Framework: In Progress Bug description: Our .Log dbus interface has two properties, version and extensions. It would be great if we could publish their existence in the introspect xml data. [0] is one example of how this can be achieved in python. [0] http://bazaar.launchpad.net/~aptdaemon- developers/aptdaemon/main/view/head:/aptdaemon/core.py#L150 ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 673008] Re: Reinstall monitors upon startup
** Changed in: zeitgeist Status: Confirmed = Fix Committed -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/673008 Title: Reinstall monitors upon startup Status in Zeitgeist Framework: Fix Committed Status in Zeitgeist Sharp: Confirmed Bug description: When for some reason zeitgeist restarts all monitors are then gone Quoting kamstrup: And fwiw - libzeitgeist detects when the daemon comes and goes and reinstates any monitors it has running - so restarting the daemon is not an issue for libzeitgeist customers We should look into having that in the python and zeitgeist-sharp wrappers ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 670358] Re: Add new aggregate API
** Changed in: zeitgeist Milestone: 0.8.0 = None -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/670358 Title: Add new aggregate API Status in Zeitgeist Framework: Confirmed Bug description: Zeitgeist API can give us vague information but not statistics over the API Use case: - Give me counts of every subject_text from actor = Unity Currently to do that one will need to either: Request all events with Unity as an Actor and count the subject_text This can be done much better IMHO I am thinking of an Aggregation Extension. But before we hack on that we need to agree if its necessary and how the API will look like. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 639737] Re: Improve insertion times
** Changed in: zeitgeist Status: In Progress = Fix Committed ** Changed in: zeitgeist Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/639737 Title: Improve insertion times Status in Zeitgeist Framework: Fix Released Bug description: We insert pretty slowly with an average of 0.15 seconds for one event on my core i5 2.5 GHz beast. RainCT had some optimization possibilities: 1) PRAGMA synchronous=OFF 2) PRAGMA journal_mode=OFF The Chat: kamstrup I think we are - but I can't recall... in case of failed transactions - but I don't even know if we use transactions these days... seif RainCT try synchronous=OFF seif RainCT but it can corrupt your database if your phone dies while ZG is inserting seif RainCT and journal_mode=MEMORY seif RainCT or OFF since we don't use rollback anyway seif so maybe journal_mode = OFF is a good start? kamstrup okay, he's probably right... kamstrup 'grep -Ri rollback _zeitgeist/' is your friend :-) kamstrup apparently we are not using rollback... More info can be found here: http://www.sqlite.org/pragma.html In order to get a better picture of what's going on, can you please try to get some more information, like: 1) How many events are in your database? 2) What's the insertion time for one event into an empty db? 3) Out of this 0.15 secs, how many time is spend in our python code, and what's the time of the actual sql action? 4) How much faster is adding 10 events at once compared to adding them one at a time? 5) You think 0.15 secs is slow for inserting one event, what time do you expect, and why? ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 598666] Re: Invalid cache access (was: Error when trying to fetch items)
The last release added a workaround for this. Since we currently aren't able to reproduce this issue, I'm just going to close this bug now. Please re-open it if you can provide a test case to reproduce the problem. ** Changed in: zeitgeist Status: Triaged = Fix Released ** Changed in: zeitgeist Assignee: Siegfried Gevatter (rainct) = (unassigned) -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/598666 Title: Invalid cache access (was: Error when trying to fetch items) Status in Zeitgeist Framework: Fix Released Bug description: When i try to fetch all items in one query i get Error from Zeitgeist engine: org.freedesktop.DBus.Python.KeyError: Traceback (most recent call last): File /usr/lib/pymodules/python2.6/dbus/service.py, line 702, in _message_cb retval = candidate_method(self, *args, **keywords) File /usr/local/share/zeitgeist/_zeitgeist/engine/remote.py, line 254, in FindEvents event_templates, storage_state, num_events, result_type, sender)) File /usr/local/share/zeitgeist/_zeitgeist/engine/main.py, line 378, in find_events return self._find_events(1, *args) File /usr/local/share/zeitgeist/_zeitgeist/engine/main.py, line 366, in _find_events return self.get_events(rows=result, sender=sender) File /usr/local/share/zeitgeist/_zeitgeist/engine/main.py, line 188, in get_events events[event.id].append_subject(self._get_subject_from_row(row)) File /usr/local/share/zeitgeist/_zeitgeist/engine/main.py, line 160, in _get_subject_from_row getattr(self, _ + field).value(row[subj_ + field])) File /usr/local/share/zeitgeist/_zeitgeist/engine/sql.py, line 422, in value return self._inv_dict[id] KeyError: 138 This looks serious ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 397715] Re: I18N of zeitgeist
I'm closing this bug since it isn't really being useful anymore. The
current status is that only the --help output is translated, and
translations done on Launchpad (for the three help strings) are
automatically pushed to a separate branch from where we can incorporate
them.
I think it'd make sense to translate normal log output (Starting...,
Already running..., etc.) but before that we should fix the log output
to actually be readable. All those date stamps and stuff that's
currently in the output is way too verbose that people would bother to
read it at all (although it does make sense to have that in the log
file), so we should figure out what to do with that and then we may make
more strings translatable. We can open a separate bug for that once
we're going to work on it.
On the other side there's the ontology translation topic. At the moment
the ontology strings are being used (in fact, nowadays we're lacking
display strings for the ontology). If that changes later we should make
them translatable, but we don't need this bug to remember us of that.
** Changed in: zeitgeist
Status: Confirmed = Fix Released
--
You received this bug notification because you are a member of Zeitgeist
Framework Team, which is subscribed to Zeitgeist Framework.
https://bugs.launchpad.net/bugs/397715
Title:
I18N of zeitgeist
Status in Zeitgeist Framework:
Fix Released
Bug description:
zeitgeist is using gettext for I18N in various places, but its usage is
inconsistent. A quick grep with `grep -R -E [^\_]\_{1}\( .` shows we are
using gettext for:
- some logging messages
- the name and description of the FF DataProvider
- display name of Content and Source objects in our datamodel (real gettext
support is not implemented yet)
Thinking about this three items a bit I think none of them make sense
at all. Logging is for debugging purposes, in the future we will ask
our user to add a log file to a bugreport. If the logging messages are
translated to a random language we will hardly understand the content.
Translating the display name of Content and Source object also makes
no sense, instead of this it should be done by the client. This way
one database can be accessed with different language settings. And if
we agree on the last two arguments, it also makes less sense for the
last item.
But just in case I'm missing the point here, and we decide to have
I18N support in zeitgeist we should decide which parts we would
exactly like to translate, and dig trough the code to add language
support to related elements consistently.
Markus
___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 660307] Re: zeitgeist fails to run if its database structure is not complete
** Changed in: zeitgeist Milestone: 0.8.0 = None -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/660307 Title: zeitgeist fails to run if its database structure is not complete Status in Zeitgeist Framework: Triaged Status in “zeitgeist” package in Ubuntu: Confirmed Bug description: Binary package hint: zeitgeist If zeitgeist's database (~/.local/share/zeitgeist/activity.sqlite) is incomplete, eg missing the events table, zeitgeist fails to run. And because the GUI does not report that zeitgeist faiiled to run, applications that rely on zeitgeist simply fail to work without any relevant reason given. I ran into this problem on upgrading an installation from Ubuntu 10.04 to 10.10. After the upgrade, the dockbarx applet failed to run. The error message from gnome-panel just said it had failed to run, and .xsession-errors said the child process did not report any specific error. Running in debug mode (ie with the command dockbarx-factory.py run-in-window) gave: ERROR:dbus.proxies:Introspect error on :1.134:/org/gnome/zeitgeist/log/activity: dbus.exceptions.DBusException: org.freedesktop.DBus.Error.NoReply: Message did not receive a reply (timeout by message bus) DEBUG:dbus.proxies:Executing introspect queue due to error Traceback (most recent call last): File /usr/bin/dockbarx_factory.py, line 26, in module import dockbarx.dockbar ... File /usr/lib/pymodules/python2.6/dbus/proxies.py, line 140, in __call__ **keywords) File /usr/lib/pymodules/python2.6/dbus/connection.py, line 620, in call_blocking message, timeout) dbus.exceptions.DBusException: org.freedesktop.DBus.Error.ServiceUnknown: The name :1.134 was not provided by any .service files The error appeared to be a dbus error, but in fact was a problem with zeitgeist, which was failing to run because its database apparently was corrupted during the upgrade. I fixed the problem (eventually) by deleting the zeitgeist database file and restarting the zeitgeist- daemon manually. What I would expect to happen is: 1) The GUI should report that zeitgeist has failed to run. 2) Better yet, zeitgeist could create the necessary tables if its database is invalid or perhaps backup the old database and create a new one so it can run properly. It would of course be nice if dockbarx reported better error information, but since there are other applications that depend on zeitgeist, it would be good if zeitgeist could recover from this situation. ProblemType: Bug DistroRelease: Ubuntu 10.10 Package: zeitgeist 0.5.2-0ubuntu1 ProcVersionSignature: Ubuntu 2.6.35-22.34-generic 2.6.35.4 Uname: Linux 2.6.35-22-generic i686 Architecture: i386 Date: Thu Oct 14 11:52:41 2010 InstallationMedia: Ubuntu 10.10 Maverick Meerkat - Alpha i386 (20100602.2) PackageArchitecture: all ProcEnviron: PATH=(custom, no user) LANG=en_AU.UTF-8 SHELL=/bin/bash SourcePackage: zeitgeist ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 691167] Re: The payload is sometimes mentioned as string and sometimes as array of bytes
I think we can bump the Python dependency to Python 2.6 by now, and fix
this the right way.
--
You received this bug notification because you are a member of Zeitgeist
Framework Team, which is subscribed to Zeitgeist Framework.
https://bugs.launchpad.net/bugs/691167
Title:
The payload is sometimes mentioned as string and sometimes as array of
bytes
Status in Zeitgeist Framework:
In Progress
Bug description:
In the event serialization format, the third array is array of bytes
or ay as dbus signature.
When an event enters an extension, it looks like
Event([dbus.Array([u'', u'1292500628312', u'', u'',
u'application://foo.desktop'], signature=dbus.Signature('s')), [Subject([u'',
u'', u'', u'', u'', u'', u''])], dbus.Array([], signature=dbus.Signature('y'))])
which implies that payload is array of bytes
Now look at _zeitgeist/engine/datamodel.py at line 58
where you get the line
popo.append(str(ev[2]))
Really so when you do str() on dbus.Array([], signature=dbus.Signature('y'))
you get dbus.Array([], signature=dbus.Signature('y')) instead of the
contents of bytes converted to string
Now when you call Event.get_plain on
Event([dbus.Array([u'', u'1292500628312', u'', u'',
u'application://foo.desktop'], signature=dbus.Signature('s')),
[Subject([u'', u'', u'', u'', u'', u'', u''])], dbus.Array([],
signature=dbus.Signature('y'))])
you get
[[u'', u'1292500628312', u'', u'', u'application://foo.desktop'],
[[u'', u'', u'', u'', u'', u'', u'']], dbus.Array([],
signature=dbus.Signature('y'))]
Not what you expect
___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 425258] Re: origin should be a property of events, not items
So I think we decided to add origin to events in addition to what is there now? -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/425258 Title: origin should be a property of events, not items Status in Zeitgeist Framework: New Bug description: Both http://live.gnome.org/GnomeZeitgeist/DatabaseDesign and our current implementation have origin as a property of items, but this makes no sense, as the origin can be different for every event and should as such be a property of it. (Further, to improve disk space usage we should save the actual value of it in the uri table). I'm filling this bug so that we don't remember to fix it, but please let's ignore it until we get the basic event/item separation stuff merged - most important stuff first. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/storagemonitor2 into lp:zeitgeist
Mikkel Kamstrup Erlandsen has proposed merging lp:~zeitgeist/zeitgeist/storagemonitor2 into lp:zeitgeist. Requested reviews: Zeitgeist Framework Team (zeitgeist) Related bugs: #489194 Implement storage monitor (devices and connectivity) https://bugs.launchpad.net/bugs/489194 For more details, see: https://code.launchpad.net/~zeitgeist/zeitgeist/storagemonitor2/+merge/49212 Woohoo, finally the storage monitor is ready. It supports uodating the storage table with the values from GIO volume monitors as well as the network state from Connman or NetworkManager which ever is available on the system. The extension will also populate the 'storage' field of subjects that don't already have one. So what's missing? Well ZG will raise NotImplementedError if you send it a StorageState that is different from StorageState.Any. So I'll propose another branch that properly supports this. -- https://code.launchpad.net/~zeitgeist/zeitgeist/storagemonitor2/+merge/49212 Your team Zeitgeist Framework Team is requested to review the proposed merge of lp:~zeitgeist/zeitgeist/storagemonitor2 into lp:zeitgeist. === modified file '_zeitgeist/engine/__init__.py' --- _zeitgeist/engine/__init__.py 2011-01-17 15:54:47 + +++ _zeitgeist/engine/__init__.py 2011-02-10 12:31:04 + @@ -57,7 +57,7 @@ # Required version of DB schema CORE_SCHEMA=core - CORE_SCHEMA_VERSION = 3 + CORE_SCHEMA_VERSION = 4 USER_EXTENSION_PATH = os.path.join(DATA_PATH, extensions) === modified file '_zeitgeist/engine/extensions/Makefile.am' --- _zeitgeist/engine/extensions/Makefile.am 2010-06-17 20:43:34 + +++ _zeitgeist/engine/extensions/Makefile.am 2011-02-10 12:31:04 + @@ -3,4 +3,5 @@ app_PYTHON = \ __init__.py \ blacklist.py \ - datasource_registry.py + datasource_registry.py \ + storagemonitor.py === added file '_zeitgeist/engine/extensions/storagemonitor.py' --- _zeitgeist/engine/extensions/storagemonitor.py 1970-01-01 00:00:00 + +++ _zeitgeist/engine/extensions/storagemonitor.py 2011-02-10 12:31:04 + @@ -0,0 +1,392 @@ +# -.- coding: utf-8 -.- + +# Zeitgeist +# +# Copyright © 2009 Mikkel Kamstrup Erlandsen mikkel.kamst...@gmail.com +# Copyright © 2011 Canonical Ltd +# +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU Lesser General Public License as published by +# the Free Software Foundation, either version 2.1 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU Lesser General Public License for more details. +# +# You should have received a copy of the GNU Lesser General Public License +# along with this program. If not, see http://www.gnu.org/licenses/. + +import os +import dbus +import dbus.service +import gio +import logging + +from zeitgeist.datamodel import Event +from _zeitgeist.engine.extension import Extension +from _zeitgeist.engine import constants + +logging.basicConfig(level=logging.DEBUG) +log = logging.getLogger(zeitgeist.storagemonitor) + +# +# Storage mediums we need to handle: +# +# - USB drives +# - Data CD/DVDs +# - Audio CDs +# - Video DVD +# - Networked file systems +# - Online resources +# +# A storage medium is gio.Volume (since this is a physical entity for the user) +# or a network interface - how ever NetworkManager/ConnMan model these +# +# We can not obtain UUIDs for all of the listed gio.Volumes, so we need a +# fallback chain of identifiers +# +# DB schema: +# It may be handy for app authors to have the human-readable +# description at hand. We can not currently easily do this in the +# current db... We may be able to do this in a new table, not +# breaking compat with the log db. We might also want a formal type +# associated with the storage so apps can use an icon for it. +# A new table and a new object+interface on DBus could facilitate this +# +# 'storage' table +# id +# name +# state +# +type +# +display_name +# +# FIXME: We can not guess what the correct ID of CDs and DVDs were when they +#are ejected, and also guess unknown +# + +import dbus +import dbus.service +import sqlite3 +import gio +import logging +log = logging.getLogger(zeitgeist.storagemonitor) + +from zeitgeist.datamodel import StorageState +from _zeitgeist.engine.sql import get_default_cursor + +STORAGE_MONITOR_DBUS_OBJECT_PATH = /org/gnome/zeitgeist/storagemonitor +STORAGE_MONITOR_DBUS_INTERFACE = org.gnome.zeitgeist.StorageMonitor + +class StorageMonitor(Extension, dbus.service.Object): + + The Storage Monitor monitors the availability of network interfaces and + storage devices and updates the Zeitgeist database with this information so + clients can efficiently query based on the storage identifier and availability + of the storage media the event subjects reside on. + + For storage devices the monitor
Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/storagemonitor2 into lp:zeitgeist
Review: Needs Fixing +logging.basicConfig(level=logging.DEBUG) WHY? And why is this and the imports there twice (before and after the big comments)? +# storgaemonitor extension. This is actually backwards compatible. Storgae? Is that like 'deine mudda' in Danish? -- https://code.launchpad.net/~zeitgeist/zeitgeist/storagemonitor2/+merge/49212 Your team Zeitgeist Framework Team is subscribed to branch lp:~zeitgeist/zeitgeist/storagemonitor2. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 716503] [NEW] FTS: can't get more than 132 results
Public bug reported: The FTS extension uses SQLite's argument parsing, which limits the results to 132 distinct URIs. FTS should workaround this restriction like Zeitgeist itself already does. ** Affects: zeitgeist-extensions Importance: Undecided Status: New -- You received this bug notification because you are a member of Zeitgeist Extensions, which is the registrant for Zeitgeist Extensions. https://bugs.launchpad.net/bugs/716503 Title: FTS: can't get more than 132 results Status in Zeitgeist Extensions: New Bug description: The FTS extension uses SQLite's argument parsing, which limits the results to 132 distinct URIs. FTS should workaround this restriction like Zeitgeist itself already does. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/storagemonitor2 into lp:zeitgeist
Review: Needs Fixing lambda : The space before the colons looks ugly :P. except: Please make this except sqlite3.foobar (or, worst-case, except Exception). Also, why do you need the rollback there? A storage medium is indetified by a key How can I indetify you? :) You could move most the the NM/Connman code into a common base class. Looks great otherwise. Good job!!! -- https://code.launchpad.net/~zeitgeist/zeitgeist/storagemonitor2/+merge/49212 Your team Zeitgeist Framework Team is subscribed to branch lp:~zeitgeist/zeitgeist/storagemonitor2. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 691167] Re: The payload is sometimes mentioned as string and sometimes as array of bytes
+1 on that decision
--
You received this bug notification because you are a member of Zeitgeist
Framework Team, which is subscribed to Zeitgeist Framework.
https://bugs.launchpad.net/bugs/691167
Title:
The payload is sometimes mentioned as string and sometimes as array of
bytes
Status in Zeitgeist Framework:
In Progress
Bug description:
In the event serialization format, the third array is array of bytes
or ay as dbus signature.
When an event enters an extension, it looks like
Event([dbus.Array([u'', u'1292500628312', u'', u'',
u'application://foo.desktop'], signature=dbus.Signature('s')), [Subject([u'',
u'', u'', u'', u'', u'', u''])], dbus.Array([], signature=dbus.Signature('y'))])
which implies that payload is array of bytes
Now look at _zeitgeist/engine/datamodel.py at line 58
where you get the line
popo.append(str(ev[2]))
Really so when you do str() on dbus.Array([], signature=dbus.Signature('y'))
you get dbus.Array([], signature=dbus.Signature('y')) instead of the
contents of bytes converted to string
Now when you call Event.get_plain on
Event([dbus.Array([u'', u'1292500628312', u'', u'',
u'application://foo.desktop'], signature=dbus.Signature('s')),
[Subject([u'', u'', u'', u'', u'', u'', u''])], dbus.Array([],
signature=dbus.Signature('y'))])
you get
[[u'', u'1292500628312', u'', u'', u'application://foo.desktop'],
[[u'', u'', u'', u'', u'', u'', u'']], dbus.Array([],
signature=dbus.Signature('y'))]
Not what you expect
___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help : https://help.launchpad.net/ListHelp
