[Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bluebird_basedir_2 into lp:~zeitgeist/zeitgeist/bluebird

2011-07-28 Thread noreply
The proposal to merge lp:~zeitgeist/zeitgeist/bluebird_basedir_2 into lp:~zeitgeist/zeitgeist/bluebird has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird_basedir_2/+merge/69670 -- https://code.launchpad.net/~zeitg

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bluebird_basedir_2 into lp:~zeitgeist/zeitgeist/bluebird

2011-07-28 Thread Seif Lotfy
on it 2011/7/28 Manish Sinha (मनीष सिन्हा > Review: Needs Fixing > Everything looks fine. Please add one more constant called > LOCAL_EXTENSIONS_PATH which should be XDG_DATA_HOME + /zeitgeist/ + > /extensions/ > -- > > https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird_basedir_2/+merge/6

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bluebird_basedir_2 into lp:~zeitgeist/zeitgeist/bluebird

2011-07-28 Thread मनीष सिन्हा
Review: Needs Fixing Everything looks fine. Please add one more constant called LOCAL_EXTENSIONS_PATH which should be XDG_DATA_HOME + /zeitgeist/ + /extensions/ -- https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird_basedir_2/+merge/69670 Your team Zeitgeist Framework Team is subscribed to br

[Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bluebird_basedir_2 into lp:~zeitgeist/zeitgeist/bluebird

2011-07-28 Thread Seif Lotfy
Seif Lotfy has proposed merging lp:~zeitgeist/zeitgeist/bluebird_basedir_2 into lp:~zeitgeist/zeitgeist/bluebird. Requested reviews: Zeitgeist Framework Team (zeitgeist) For more details, see: https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird_basedir_2/+merge/69670 Another take on the

[Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bluebird_basedir into lp:~zeitgeist/zeitgeist/bluebird

2011-07-28 Thread Seif Lotfy
The proposal to merge lp:~zeitgeist/zeitgeist/bluebird_basedir into lp:~zeitgeist/zeitgeist/bluebird has been updated. Status: Work in progress => Merged For more details, see: https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird_basedir/+merge/69658 -- https://code.launchpad.net/~zeitg

[Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bluebird_basedir into lp:~zeitgeist/zeitgeist/bluebird

2011-07-28 Thread Seif Lotfy
The proposal to merge lp:~zeitgeist/zeitgeist/bluebird_basedir into lp:~zeitgeist/zeitgeist/bluebird has been updated. Status: Merged => Work in progress For more details, see: https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird_basedir/+merge/69658 -- https://code.launchpad.net/~zeitg

[Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bluebird_basedir into lp:~zeitgeist/zeitgeist/bluebird

2011-07-28 Thread noreply
The proposal to merge lp:~zeitgeist/zeitgeist/bluebird_basedir into lp:~zeitgeist/zeitgeist/bluebird has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird_basedir/+merge/69658 -- https://code.launchpad.net/~zeitgeist

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bluebird_basedir into lp:~zeitgeist/zeitgeist/bluebird

2011-07-28 Thread मनीष सिन्हा
Review: Approve -- https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird_basedir/+merge/69658 Your team Zeitgeist Framework Team is subscribed to branch lp:~zeitgeist/zeitgeist/bluebird. ___ Mailing list: https://launchpad.net/~zeitgeist Post to

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bluebird_basedir into lp:~zeitgeist/zeitgeist/bluebird

2011-07-28 Thread Michal Hruby
Review: Approve -- https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird_basedir/+merge/69658 Your team Zeitgeist Framework Team is subscribed to branch lp:~zeitgeist/zeitgeist/bluebird. ___ Mailing list: https://launchpad.net/~zeitgeist Post to

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bluebird_basedir into lp:~zeitgeist/zeitgeist/bluebird

2011-07-28 Thread मनीष सिन्हा
Do we need FileTest.IS_DIR or FileTest.IS_DIR | FileTest.EXISTS ? -- https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird_basedir/+merge/69658 Your team Zeitgeist Framework Team is subscribed to branch lp:~zeitgeist/zeitgeist/bluebird. ___ Mailing

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bluebird_basedir into lp:~zeitgeist/zeitgeist/bluebird

2011-07-28 Thread मनीष सिन्हा
Review: Needs Fixing paths Instead of Environment.get_user_data_dir () + "/"+ ZEITGEIST_DATA_FOLDER; Use Path.build_filename(path1 path2, path3...) -- https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird_basedir/+merge/69658 Your team Zeitgeist Framework Team is subscribed to branch lp:~zeit

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bluebird_basedir into lp:~zeitgeist/zeitgeist/bluebird

2011-07-28 Thread Michal Hruby
Review: Needs Fixing We don't need gio (File.*), use DirUtils.* functions, join paths with Path.build_filename () -- https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird_basedir/+merge/69658 Your team Zeitgeist Framework Team is subscribed to branch lp:~zeitgeist/zeitgeist/bluebird. ___

[Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bluebird_basedir into lp:~zeitgeist/zeitgeist/bluebird

2011-07-28 Thread Seif Lotfy
Seif Lotfy has proposed merging lp:~zeitgeist/zeitgeist/bluebird_basedir into lp:~zeitgeist/zeitgeist/bluebird. Requested reviews: Zeitgeist Framework Team (zeitgeist) For more details, see: https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird_basedir/+merge/69658 This is just a place hol