Re: [Zeitgeist] [Merge] lp:~ev/activity-log-manager/whoopsie into lp:activity-log-manager

2012-02-21 Thread मनीष सिन्हा
Review: Needs Fixing build system

Please make this as optional (--enable-whoopsie) otherwise it cannot be 
packaged in other distributions without whoopsie being packaged
-- 
https://code.launchpad.net/~ev/activity-log-manager/whoopsie/+merge/93899
Your team Activity Log Manager is subscribed to branch lp:activity-log-manager.

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Bug 646724] Re: not all files show up in files-place

2012-02-21 Thread Raffaele Zippo
Excuse me for not reading all the discussion up there..

From the first time i used the dash, i found it extremely handy and
useful; but for what are my necessities zeigeist's way to search files
is not suited for me, so that i'm only using tracker.

So I ask: can you integrate tracker, obviously as an option and not as
default, with the dash search lens?

-- 
You received this bug notification because you are a member of Zeitgeist
Framework Team, which is subscribed to Zeitgeist Data-Sources.
https://bugs.launchpad.net/bugs/646724

Title:
  not all files show up in files-place

Status in Unity:
  Triaged
Status in Unity 2D:
  Triaged
Status in Unity Files Lens:
  Triaged
Status in Zeitgeist Framework:
  Invalid
Status in Zeitgeist Data-Sources:
  Invalid
Status in “unity-lens-files” package in Ubuntu:
  Triaged
Status in “unity-place-files” package in Ubuntu:
  Triaged
Status in “zeitgeist” package in Ubuntu:
  Fix Released

Bug description:
  The Unity interface, with its files-place feature for user access to
  files/documents etc. is really great.

  However there is a problem since the search feature relies wholly on
  zeitgeist (AFAIK), in the zeitgeist is not tracking everything.

  E.g. in openoffice, I create a new file (or open an existing one) from
  within openoffice itself. This file does not show up, presumably
  because openoffice does not (yet) push its activity to zeitgeist.

  I guess any number of other programs could suffer the same problem.

  For the average user, this is surely going to be confusing. They will
  create documents via legitimate means ('New ...' buttons in their
  applications), and then expect to be able to search for them in the
  Unity files-place interface.

  To avoid this confusion I would guess there really needs to be a
  filesystem watcher on the home dir (or key folders within it) so that
  zeitgeist is aware of activity caused by non-zeitgeist-aware
  applications.

  (See also bug 897393, about warning users that the search doesn't
  search all files.)

To manage notifications about this bug go to:
https://bugs.launchpad.net/unity/+bug/646724/+subscriptions

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


Re: [Zeitgeist] [Merge] lp:~ev/activity-log-manager/whoopsie into lp:activity-log-manager

2012-02-21 Thread Seif Lotfy
Evan I dont mind also having it in the standalone version :D
-- 
https://code.launchpad.net/~ev/activity-log-manager/whoopsie/+merge/93899
Your team Activity Log Manager is subscribed to branch lp:activity-log-manager.

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 408: Make sure we clean up transactions properly

2012-02-21 Thread noreply

revno: 408
fixes bug: https://launchpad.net/bugs/937991
committer: Michal Hruby michal@gmail.com
branch nick: bluebird
timestamp: Tue 2012-02-21 19:17:16 +0100
message:
  Make sure we clean up transactions properly
modified:
  src/engine.vala
  src/sql.vala


--
lp:zeitgeist
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird

Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.
To unsubscribe from this branch go to 
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird/+edit-subscription
=== modified file 'src/engine.vala'
--- src/engine.vala	2012-02-10 13:35:02 +
+++ src/engine.vala	2012-02-21 18:17:16 +
@@ -72,13 +72,24 @@
 
 extension_collection.call_pre_insert_events (events, sender);
 uint32[] event_ids = new uint32[events.length];
+EngineError? err = null;
 database.begin_transaction ();
-for (int i = 0; i  events.length; ++i)
-{
-if (events[i] != null)
-event_ids[i] = insert_event (events[i]);
-}
-database.end_transaction ();
+try
+{
+for (int i = 0; i  events.length; ++i)
+{
+if (events[i] != null)
+event_ids[i] = insert_event (events[i]);
+}
+database.end_transaction ();
+}
+catch (EngineError e)
+{
+err = e;
+database.abort_transaction ();
+}
+if (err != null) throw err;
+
 extension_collection.call_post_insert_events (events, sender);
 return event_ids;
 }

=== modified file 'src/sql.vala'
--- src/sql.vala	2012-02-10 11:28:05 +
+++ src/sql.vala	2012-02-21 18:17:16 +
@@ -277,6 +277,12 @@
 assert_query_success (rc, Can't commit transaction);
 }
 
+public void abort_transaction () throws EngineError
+{
+int rc = database.exec (ROLLBACK);
+assert_query_success (rc, Can't rollback transaction);
+}
+
 public void close ()
 {
 // SQLite connection is implicitly closed upon destruction

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Bug 937991] Re: Failed logging: transaction within transaction

2012-02-21 Thread Launchpad Bug Tracker
** Branch linked: lp:zeitgeist

-- 
You received this bug notification because you are a member of Zeitgeist
Framework Team, which is subscribed to Zeitgeist Framework.
https://bugs.launchpad.net/bugs/937991

Title:
  Failed logging: transaction within transaction

Status in Zeitgeist Framework:
  New

Bug description:
  Seems like the commit() call in SQLIte fails. I think it is because
  another connection is keeping a lock on the database, which leads
  subsequent calls to the connection fail with OperationalError: cannot
  start a transaction within a transaction.

  ---
  mhr3: oh oh
  mhr3: ** WARNING **: zeitgeist-datahub.vala:207: Error during inserting 
events: GDBus.Error:org.gnome.zeitgeist.EngineError.DatabaseError: Can't start 
transaction: 1, cannot start a transaction within a transaction
  mhr3: nothing got logged for me for the past 23hours
  mhr3: seems to be our fault, there should be definitely try{} finally{}

To manage notifications about this bug go to:
https://bugs.launchpad.net/zeitgeist/+bug/937991/+subscriptions

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Bug 937991] [NEW] Failed logging: transaction within transaction

2012-02-21 Thread Seif Lotfy
Public bug reported:

Seems like the commit() call in SQLIte fails. I think it is because
another connection is keeping a lock on the database, which leads
subsequent calls to the connection fail with OperationalError: cannot
start a transaction within a transaction.

---
mhr3: oh oh
mhr3: ** WARNING **: zeitgeist-datahub.vala:207: Error during inserting events: 
GDBus.Error:org.gnome.zeitgeist.EngineError.DatabaseError: Can't start 
transaction: 1, cannot start a transaction within a transaction
mhr3: nothing got logged for me for the past 23hours
mhr3: seems to be our fault, there should be definitely try{} finally{}

** Affects: zeitgeist
 Importance: High
 Status: New

-- 
You received this bug notification because you are a member of Zeitgeist
Framework Team, which is subscribed to Zeitgeist Framework.
https://bugs.launchpad.net/bugs/937991

Title:
  Failed logging: transaction within transaction

Status in Zeitgeist Framework:
  New

Bug description:
  Seems like the commit() call in SQLIte fails. I think it is because
  another connection is keeping a lock on the database, which leads
  subsequent calls to the connection fail with OperationalError: cannot
  start a transaction within a transaction.

  ---
  mhr3: oh oh
  mhr3: ** WARNING **: zeitgeist-datahub.vala:207: Error during inserting 
events: GDBus.Error:org.gnome.zeitgeist.EngineError.DatabaseError: Can't start 
transaction: 1, cannot start a transaction within a transaction
  mhr3: nothing got logged for me for the past 23hours
  mhr3: seems to be our fault, there should be definitely try{} finally{}

To manage notifications about this bug go to:
https://bugs.launchpad.net/zeitgeist/+bug/937991/+subscriptions

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Bug 937991] Re: Failed logging: transaction within transaction

2012-02-21 Thread Michal Hruby
** Changed in: zeitgeist
   Status: New = Fix Committed

-- 
You received this bug notification because you are a member of Zeitgeist
Framework Team, which is subscribed to Zeitgeist Framework.
https://bugs.launchpad.net/bugs/937991

Title:
  Failed logging: transaction within transaction

Status in Zeitgeist Framework:
  Fix Committed

Bug description:
  Seems like the commit() call in SQLIte fails. I think it is because
  another connection is keeping a lock on the database, which leads
  subsequent calls to the connection fail with OperationalError: cannot
  start a transaction within a transaction.

  ---
  mhr3: oh oh
  mhr3: ** WARNING **: zeitgeist-datahub.vala:207: Error during inserting 
events: GDBus.Error:org.gnome.zeitgeist.EngineError.DatabaseError: Can't start 
transaction: 1, cannot start a transaction within a transaction
  mhr3: nothing got logged for me for the past 23hours
  mhr3: seems to be our fault, there should be definitely try{} finally{}

To manage notifications about this bug go to:
https://bugs.launchpad.net/zeitgeist/+bug/937991/+subscriptions

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


Re: [Zeitgeist] [Merge] lp:~ev/activity-log-manager/whoopsie into lp:activity-log-manager

2012-02-21 Thread Evan Dandrea
On Tue, Feb 21, 2012 at 2:55 PM, Seif Lotfy s...@lotfy.com wrote:
 Evan I dont mind also having it in the standalone version :D

Sure, but presumably that requires building the whoopsie code as a
library and generating a vapi, as you cannot directly call C code from
vala source.

So could we get that in a second pass, given that UI freeze is tomorrow?

-- 
https://code.launchpad.net/~ev/activity-log-manager/whoopsie/+merge/93899
Your team Activity Log Manager is subscribed to branch lp:activity-log-manager.

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


Re: [Zeitgeist] [Merge] lp:~ev/activity-log-manager/whoopsie into lp:activity-log-manager

2012-02-21 Thread Seif Lotfy
Yep merging tomorrow first thing

On Wed, Feb 22, 2012 at 12:41 AM, Evan Dandrea
evan.dand...@canonical.comwrote:

 On Tue, Feb 21, 2012 at 2:55 PM, Seif Lotfy s...@lotfy.com wrote:
  Evan I dont mind also having it in the standalone version :D

 Sure, but presumably that requires building the whoopsie code as a
 library and generating a vapi, as you cannot directly call C code from
 vala source.

 So could we get that in a second pass, given that UI freeze is tomorrow?

 --
 https://code.launchpad.net/~ev/activity-log-manager/whoopsie/+merge/93899
 Your team Activity Log Manager is subscribed to branch
 lp:activity-log-manager.


-- 
https://code.launchpad.net/~ev/activity-log-manager/whoopsie/+merge/93899
Your team Activity Log Manager is subscribed to branch lp:activity-log-manager.

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Bug 927938] Re: Monitoring Downloads directory should be disabled by default

2012-02-21 Thread Seif Lotfy
I will work on this tomorrow

** Changed in: zeitgeist-datahub
 Assignee: (unassigned) = Seif Lotfy (seif)

** Changed in: zeitgeist-datahub
   Status: New = Confirmed

** Changed in: zeitgeist-datahub
   Importance: Undecided = High

-- 
You received this bug notification because you are a member of Zeitgeist
Framework Team, which is the registrant for Zeitgeist Datahub.
https://bugs.launchpad.net/bugs/927938

Title:
  Monitoring Downloads directory should be disabled by default

Status in Zeitgeist Datahub:
  Confirmed

Bug description:
  I think Zeitgeist should ship its source with monitoring downloads
  disabled by default. I think we should use --enable-downloads-monitor
  as an argument.

To manage notifications about this bug go to:
https://bugs.launchpad.net/zeitgeist-datahub/+bug/927938/+subscriptions

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp