[Zeitgeist] [Bug 691690] Re: DataSourceRegistry should have GetDataSourceForId method
** Changed in: zeitgeist Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/691690 Title: DataSourceRegistry should have GetDataSourceForId method Status in Zeitgeist Framework: Fix Released Bug description: DataSourceRegistry should have a way to get a DataSource from it's id especially because the DataSourceEnabled signal only sends an id rather than a DataSource in the signal. To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/691690/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 691690] Re: DataSourceRegistry should have GetDataSourceForId method
** Changed in: zeitgeist Milestone: 0.8.0 = 0.8.1 -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/691690 Title: DataSourceRegistry should have GetDataSourceForId method Status in Zeitgeist Framework: Fix Committed Bug description: DataSourceRegistry should have a way to get a DataSource from it's id especially because the DataSourceEnabled signal only sends an id rather than a DataSource in the signal. To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/691690/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 691690] Re: DataSourceRegistry should have GetDataSourceForId method
** Branch linked: lp:zeitgeist -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/691690 Title: DataSourceRegistry should have GetDataSourceForId method Status in Zeitgeist Framework: Fix Committed Bug description: DataSourceRegistry should have a way to get a DataSource from it's id especially because the DataSourceEnabled signal only sends an id rather than a DataSource in the signal. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Bug 691690] Re: DataSourceRegistry should have GetDataSourceForId method
Siegfried; what you propose is breaking the DBus API, which will force me to break ABI and API of libzeitgeist = mikkel becomes unpopular. That said, I do see the merit in what you are proposing. It just has some consequences... ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 691690] Re: DataSourceRegistry should have GetDataSourceForId method
(Uhm, I had send out an e-mail about this earlier but it looks like Launchpad lost it:) There's a typo in my first comment, what I meant is b) or c), not a) or b). That is, the solution I'd prefer is a). After that I'd choose b), since a GetDataSourceForId method by itself (without the signals) isn't really useful -- you need to know the IDs to ask for them. Thoughts? -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/691690 Title: DataSourceRegistry should have GetDataSourceForId method Status in Zeitgeist Framework: Confirmed Bug description: DataSourceRegistry should have a way to get a DataSource from it's id especially because the DataSourceEnabled signal only sends an id rather than a DataSource in the signal. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 691690] Re: DataSourceRegistry should have GetDataSourceForId method
Oh, I see what you meant. Yeah, b would be helpful I believe from our standpoint. Then the signals would be consistent. -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/691690 Title: DataSourceRegistry should have GetDataSourceForId method Status in Zeitgeist Framework: Confirmed Bug description: DataSourceRegistry should have a way to get a DataSource from it's id especially because the DataSourceEnabled signal only sends an id rather than a DataSource in the signal. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 691690] Re: DataSourceRegistry should have GetDataSourceForId method
OK, so as I see it there are various ways to fix this: a) Not a bug - If they care about data-sources they should keep track of them (GetDataSources at start and DataSourceRegistered after that). However, what should be fixed is the DataSourceDisconnected signal, it is currently sending the whole data-source information while just the unique id should be enough. b) Change DataSourceEnabled to send the whole data-source, so it's consistent with DataSourceRegistered and DataSourceDisconnected. c) Leave DataSourceEnabled as it is, fix DataSourceDisconnected to only return the unique id (see A) and add a GetDataSourceForId method. Personally I don't see what a) or b) would bring us. If you're a data- source yourself you'll probably just want to check whether the ID is yours to know what happened to you. If you're a data-source management GUI, which wants to update the information when something is enabled/disabled, you'll be keep track of all data-sources anyway, through a GetDataSources call at startup and successive updates thanks to DataSourceRegistered signals. This means that when you get a DataSourceEnabled signal you already have the information about the event, and getting a full copy of it won't make your work any easier than just having the unique ID. ** Changed in: zeitgeist Importance: Undecided = Low ** Changed in: zeitgeist Status: In Progress = New -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/691690 Title: DataSourceRegistry should have GetDataSourceForId method Status in Zeitgeist Framework: New Bug description: DataSourceRegistry should have a way to get a DataSource from it's id especially because the DataSourceEnabled signal only sends an id rather than a DataSource in the signal. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 691690] Re: DataSourceRegistry should have GetDataSourceForId method
** Changed in: zeitgeist Status: New = Confirmed ** Changed in: zeitgeist Milestone: None = 0.7.0 -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/691690 Title: DataSourceRegistry should have GetDataSourceForId method Status in Zeitgeist Framework: Confirmed Bug description: DataSourceRegistry should have a way to get a DataSource from it's id especially because the DataSourceEnabled signal only sends an id rather than a DataSource in the signal. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
