is requested to review the proposed merge of
lp:~zeitgeist/zeitgeist/fix-950983 into lp:zeitgeist.
=== modified file 'extensions/storage-monitor.vala'
--- extensions/storage-monitor.vala 2012-02-10 13:35:02 +
+++ extensions/storage-monitor.vala 2012-03-19 10:07:31 +
@@ -112,8 +112,10
Review: Needs Fixing
Can't we make it simpler? Try to INSERT the row, if that fails because the
value already exists, run UPDATE.
And arguably it might be more efficient to swap the order.
--
https://code.launchpad.net/~zeitgeist/zeitgeist/fix-950983/+merge/98176
Your team Zeitgeist Framework
Review: Approve
Looks good to me
--
https://code.launchpad.net/~zeitgeist/zeitgeist/fix-950983/+merge/98176
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.
___
Mailing list: https://launchpad.net/~zeitgeist
Post to :
The proposal to merge lp:~zeitgeist/zeitgeist/fix-950983 into lp:zeitgeist has
been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~zeitgeist/zeitgeist/fix-950983/+merge/98176
--
https://code.launchpad.net/~zeitgeist/zeitgeist/fix-950983/+merge
Review: Abstain
OK
--
https://code.launchpad.net/~zeitgeist/zeitgeist/fix-950983/+merge/98176
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.
___
Mailing list: https://launchpad.net/~zeitgeist
Post to :
Review: Approve
--
https://code.launchpad.net/~zeitgeist/zeitgeist/fix-950983/+merge/98176
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.
___
Mailing list: https://launchpad.net/~zeitgeist
Post to :
6 matches
Mail list logo
