Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/symbols into lp:~zeitgeist/zeitgeist/bluebird

2011-08-01 Thread Michal Hruby
Review: Needs Fixing Since you made get_parents return all parents, there's now no way to get the immediate parents and therefore reconstruct the original ontology graph easily. Fix pls... -- https://code.launchpad.net/~zeitgeist/zeitgeist/symbols/+merge/69927 Your team Zeitgeist Framework Team

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/symbols into lp:~zeitgeist/zeitgeist/bluebird

2011-08-01 Thread Seif Lotfy
you can get the immidiate stuff by asking for the properties, parents and children... I will just change the names to get_all_parents On Mon, Aug 1, 2011 at 1:55 PM, Michal Hruby michal@gmail.com wrote: Review: Needs Fixing Since you made get_parents return all parents, there's now no way

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/symbols into lp:~zeitgeist/zeitgeist/bluebird

2011-08-01 Thread Michal Hruby
Review: Needs Fixing My point is that the Symbol class itself shouldn't even be public, it should be something private to this source file. Method that this file needs to expose are (all of them are static): Liststring Symbol.get_parents (string uri) Liststring Symbol.get_children (string uri)