[Zeitgeist] [Merge] lp:~dhananjaysathe/zeitgeist-explorer/zeitgeist-explorer into lp:zeitgeist-explorer

2012-06-15 Thread dhananjaysathe
dhananjaysathe has proposed merging lp:~dhananjaysathe/zeitgeist-explorer/zeitgeist-explorer into lp:zeitgeist-explorer. Requested reviews: Zeitgeist Framework Team (zeitgeist) For more details, see: https://code.launchpad.net/~dhananjaysathe/zeitgeist-explorer/zeitgeist-explorer/+merge/11061

Re: [Zeitgeist] [Merge] lp:~dhananjaysathe/zeitgeist-explorer/zeitgeist-explorer into lp:zeitgeist-explorer

2012-06-15 Thread Siegfried Gevatter
Review: Needs Fixing Cool! There's a bit of a visual regression though: a) Padding between elements is missing. b) When nothing is selected, all titles are lumped together (before there would still be two columns). Could you look into fixing this? -- https://code.launchpad.net/~dhananjaysath

Re: [Zeitgeist] [Merge] lp:~dhananjaysathe/zeitgeist-explorer/zeitgeist-explorer into lp:zeitgeist-explorer

2012-06-15 Thread Siegfried Gevatter
(Thinking about b) again, it's probably better to just show nothing when there isn't anything selected, or maybe just a "Select an event to see its details" label). -- https://code.launchpad.net/~dhananjaysathe/zeitgeist-explorer/zeitgeist-explorer/+merge/110610 Your team Zeitgeist Framework Tea

Re: [Zeitgeist] [Merge] lp:~dhananjaysathe/zeitgeist-explorer/zeitgeist-explorer into lp:zeitgeist-explorer

2012-06-15 Thread dhananjaysathe
Review: Needs Fixing Cool ill deal with it , missed the padding params ! -- https://code.launchpad.net/~dhananjaysathe/zeitgeist-explorer/zeitgeist-explorer/+merge/110610 Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist-explorer. _