[Zeitgeist] [Merge] lp:~ev/activity-log-manager/split-out-diagnostics-service into lp:activity-log-manager

2013-07-19 Thread Evan Dandrea
Evan Dandrea has proposed merging lp:~ev/activity-log-manager/split-out-diagnostics-service into lp:activity-log-manager. Requested reviews: Activity Log Manager (activity-log-manager) For more details, see: https://code.launchpad.net/~ev/activity-log-manager/split-out-diagnostics-service/+me

[Zeitgeist] [Merge] lp:~ev/activity-log-manager/split-out-diagnostics-service into lp:activity-log-manager

2013-07-19 Thread Evan Dandrea
The proposal to merge lp:~ev/activity-log-manager/split-out-diagnostics-service into lp:activity-log-manager has been updated. Description changed to: This branch removes the code for the whoopsie-preferences DBus service as it now lives in the whoopsie-preferences package (http://bazaar.launc

Re: [Zeitgeist] [Merge] lp:~ev/activity-log-manager/split-out-diagnostics-service into lp:activity-log-manager

2013-07-19 Thread मनीष सिन्हा
Review: Needs Fixing merge-conflict, distcheck First, it give a conflict that it cannot delete directory src/diagnostic Second, even after I manually delete the folder and resolve conflict, distcheck fails because 2 files in po/POTFILES.in still reference the older ui file and C file in diagnos

Re: [Zeitgeist] [Merge] lp:~jbicha/activity-log-manager/add-apps-drop-spreadsheets-presentations into lp:activity-log-manager

2013-07-19 Thread मनीष सिन्हा
Review: Needs Information I am not sure if dropping Presentations and Spreadsheets makes sense because Datahub's recent-manager-provider.vala does take care of openoffice stuff. Check lines 113 and it is able to deduce the proper Interpretation from the mimetype (line 148) -- https://code.laun

Re: [Zeitgeist] [Merge] lp:~jbicha/activity-log-manager/add-help-link into lp:activity-log-manager

2013-07-19 Thread मनीष सिन्हा
Review: Approve -- https://code.launchpad.net/~jbicha/activity-log-manager/add-help-link/+merge/174292 Your team Activity Log Manager is subscribed to branch lp:activity-log-manager. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zei

[Zeitgeist] [Merge] lp:~jbicha/activity-log-manager/add-help-link into lp:activity-log-manager

2013-07-19 Thread noreply
The proposal to merge lp:~jbicha/activity-log-manager/add-help-link into lp:activity-log-manager has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~jbicha/activity-log-manager/add-help-link/+merge/174292 -- https://code.launchpad.net/~jbicha/