[Zeitgeist] [Bug 595919] Re: delete_event_hook for extensions
** Changed in: zeitgeist Milestone: 0.4.1 = 0.5.0 -- delete_event_hook for extensions https://bugs.launchpad.net/bugs/595919 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. Status in Zeitgeist Framework: Fix Released Bug description: Right now zeitgeist extensions have no way of knowing when events are deleted. I propose adding a delete_event_hook() method on the Extension class that extensions can override. The delete_event_hook() method should take an event_id as its sole argument. I need this functionality in the FTS extension. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 595919] Re: delete_event_hook for extensions
** Changed in: zeitgeist Assignee: (unassigned) = Seif Lotfy (seif) ** Changed in: zeitgeist Status: Fix Committed = Fix Released -- delete_event_hook for extensions https://bugs.launchpad.net/bugs/595919 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. Status in Zeitgeist Framework: Fix Released Bug description: Right now zeitgeist extensions have no way of knowing when events are deleted. I propose adding a delete_event_hook() method on the Extension class that extensions can override. The delete_event_hook() method should take an event_id as its sole argument. I need this functionality in the FTS extension. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 595919] Re: delete_event_hook for extensions
** Changed in: zeitgeist Status: Triaged = Fix Committed -- delete_event_hook for extensions https://bugs.launchpad.net/bugs/595919 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. Status in Zeitgeist Framework: Fix Committed Bug description: Right now zeitgeist extensions have no way of knowing when events are deleted. I propose adding a delete_event_hook() method on the Extension class that extensions can override. The delete_event_hook() method should take an event_id as its sole argument. I need this functionality in the FTS extension. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 595919] Re: delete_event_hook for extensions
On second thought i think a delete hook must be after.. since its the only way of knowing something was successfully deleted -- delete_event_hook for extensions https://bugs.launchpad.net/bugs/595919 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. Status in Zeitgeist Framework: Triaged Bug description: Right now zeitgeist extensions have no way of knowing when events are deleted. I propose adding a delete_event_hook() method on the Extension class that extensions can override. The delete_event_hook() method should take an event_id as its sole argument. I need this functionality in the FTS extension. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 595919] Re: delete_event_hook for extensions
BTW what should the delete_event_hook return? the whole event or the id -- delete_event_hook for extensions https://bugs.launchpad.net/bugs/595919 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. Status in Zeitgeist Framework: Triaged Bug description: Right now zeitgeist extensions have no way of knowing when events are deleted. I propose adding a delete_event_hook() method on the Extension class that extensions can override. The delete_event_hook() method should take an event_id as its sole argument. I need this functionality in the FTS extension. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 595919] Re: delete_event_hook for extensions
Does the extension need to know the sender of the delete ? ** Branch linked: lp:~zeitgeist/zeitgeist/delete-hooks -- delete_event_hook for extensions https://bugs.launchpad.net/bugs/595919 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. Status in Zeitgeist Framework: Triaged Bug description: Right now zeitgeist extensions have no way of knowing when events are deleted. I propose adding a delete_event_hook() method on the Extension class that extensions can override. The delete_event_hook() method should take an event_id as its sole argument. I need this functionality in the FTS extension. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 595919] Re: delete_event_hook for extensions
Ok here is my frist draft of a delete_event_hook that takes in the ids of deleted events and it hooks in AFTER the events are deleted. Take a look the test case is in there too -- delete_event_hook for extensions https://bugs.launchpad.net/bugs/595919 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. Status in Zeitgeist Framework: Triaged Bug description: Right now zeitgeist extensions have no way of knowing when events are deleted. I propose adding a delete_event_hook() method on the Extension class that extensions can override. The delete_event_hook() method should take an event_id as its sole argument. I need this functionality in the FTS extension. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 595919] Re: delete_event_hook for extensions
I agree, we can add this delete hook to extensions, but I'm not sure what this hook should be able to do. Is it to just notify an extension that a certain event is deleted, or is about to be deleted? Or can this hook also block the removal of an event? For notification purposes we have the notification interface. -- delete_event_hook for extensions https://bugs.launchpad.net/bugs/595919 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. Status in Zeitgeist Framework: New Bug description: Right now zeitgeist extensions have no way of knowing when events are deleted. I propose adding a delete_event_hook() method on the Extension class that extensions can override. The delete_event_hook() method should take an event_id as its sole argument. I need this functionality in the FTS extension. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 595919] Re: delete_event_hook for extensions
I proposed one event_id because the insert hook also only receives one event. The idea was simply as a notification mechanism, I am not sure it's a good idea to allow extensions to bar events from deletion, although I can't fully see the ramifications of this... We can't use the current notification API because that would require a full dbus roundtrip (back to the same process!). I don't know if the hooks should be called before or after the deletion... Any thoughts? -- delete_event_hook for extensions https://bugs.launchpad.net/bugs/595919 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. Status in Zeitgeist Framework: New Bug description: Right now zeitgeist extensions have no way of knowing when events are deleted. I propose adding a delete_event_hook() method on the Extension class that extensions can override. The delete_event_hook() method should take an event_id as its sole argument. I need this functionality in the FTS extension. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Bug 595919] Re: delete_event_hook for extensions
2010/6/18 Seif Lotfy s...@lotfy.com: Maybe a possibility is to add to hooks delete_event_hook and delete_event_hook_after +1, so that if another extension decides a particular thing shouldn't be deleted FTS's hook won't be called. -- delete_event_hook for extensions https://bugs.launchpad.net/bugs/595919 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. Status in Zeitgeist Framework: New Bug description: Right now zeitgeist extensions have no way of knowing when events are deleted. I propose adding a delete_event_hook() method on the Extension class that extensions can override. The delete_event_hook() method should take an event_id as its sole argument. I need this functionality in the FTS extension. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
