[Zeitgeist] [Bug 909708] Re: Inserting event with two subjects with the same URI breaks the following event
** Changed in: zeitgeist Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/909708 Title: Inserting event with two subjects with the same URI breaks the following event Status in Zeitgeist Framework: Fix Released Bug description: By the way our database is structured, all subjects of a same event must have different URIs. However, this isn't currently being checked, with the effect that the first subject is inserted correctly, while the second subject triggers the existing event exception and rolls back the event ID. This has the effect that the next event to be inserted will incorrectly have the same event ID (thus its subjects are mixed into whatever got saved of the first event and all sorts of weirdness :P). To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/909708/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 909708] Re: Inserting event with two subjects with the same URI breaks the following event
** Changed in: zeitgeist Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/909708 Title: Inserting event with two subjects with the same URI breaks the following event Status in Zeitgeist Framework: Fix Committed Bug description: By the way our database is structured, all subjects of a same event must have different URIs. However, this isn't currently being checked, with the effect that the first subject is inserted correctly, while the second subject triggers the existing event exception and rolls back the event ID. This has the effect that the next event to be inserted will incorrectly have the same event ID (thus its subjects are mixed into whatever got saved of the first event and all sorts of weirdness :P). To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/909708/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 909708] Re: Inserting event with two subjects with the same URI breaks the following event
Instead of deleting what was inserted of that particular event why not check the subjects of the event for validity then either start insertion or throw out a warning. I fear deletion... -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/909708 Title: Inserting event with two subjects with the same URI breaks the following event Status in Zeitgeist Framework: Confirmed Bug description: By the way our database is structured, all subjects of a same event must have different URIs. However, this isn't currently being checked, with the effect that the first subject is inserted correctly, while the second subject triggers the existing event exception and rolls back the event ID. This has the effect that the next event to be inserted will incorrectly have the same event ID (thus its subjects are mixed into whatever got saved of the first event and all sorts of weirdness :P). To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/909708/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Bug 909708] Re: Inserting event with two subjects with the same URI breaks the following event
2012/1/1 Seif Lotfy 909...@bugs.launchpad.net: Instead of deleting what was inserted of that particular event why not check the subjects of the event for validity then either start insertion or throw out a warning. I fear deletion... Huh. Checking first is just slower, there's nothing bad with deleting the event (it's just like a rollback, only not a rollback because we don't commit until the end of everything). Throwing out a warning will stop ALL events from being inserted, so it's not a nice option. -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/909708 Title: Inserting event with two subjects with the same URI breaks the following event Status in Zeitgeist Framework: Confirmed Bug description: By the way our database is structured, all subjects of a same event must have different URIs. However, this isn't currently being checked, with the effect that the first subject is inserted correctly, while the second subject triggers the existing event exception and rolls back the event ID. This has the effect that the next event to be inserted will incorrectly have the same event ID (thus its subjects are mixed into whatever got saved of the first event and all sorts of weirdness :P). To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/909708/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Bug 909708] Re: Inserting event with two subjects with the same URI breaks the following event
you win On Sun, Jan 1, 2012 at 12:44 PM, Siegfried Gevatter rai...@ubuntu.comwrote: 2012/1/1 Seif Lotfy 909...@bugs.launchpad.net: Instead of deleting what was inserted of that particular event why not check the subjects of the event for validity then either start insertion or throw out a warning. I fear deletion... Huh. Checking first is just slower, there's nothing bad with deleting the event (it's just like a rollback, only not a rollback because we don't commit until the end of everything). Throwing out a warning will stop ALL events from being inserted, so it's not a nice option. -- You received this bug notification because you are subscribed to The Zeitgeist Project. https://bugs.launchpad.net/bugs/909708 Title: Inserting event with two subjects with the same URI breaks the following event Status in Zeitgeist Framework: Confirmed Bug description: By the way our database is structured, all subjects of a same event must have different URIs. However, this isn't currently being checked, with the effect that the first subject is inserted correctly, while the second subject triggers the existing event exception and rolls back the event ID. This has the effect that the next event to be inserted will incorrectly have the same event ID (thus its subjects are mixed into whatever got saved of the first event and all sorts of weirdness :P). To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/909708/+subscriptions -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/909708 Title: Inserting event with two subjects with the same URI breaks the following event Status in Zeitgeist Framework: Confirmed Bug description: By the way our database is structured, all subjects of a same event must have different URIs. However, this isn't currently being checked, with the effect that the first subject is inserted correctly, while the second subject triggers the existing event exception and rolls back the event ID. This has the effect that the next event to be inserted will incorrectly have the same event ID (thus its subjects are mixed into whatever got saved of the first event and all sorts of weirdness :P). To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/909708/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 909708] Re: Inserting event with two subjects with the same URI breaks the following event
So I think I went with a modified option 3 since we already parse the subjects before insertion I added a list with subj_uris to find if there is a duplicate and return 0 if one is found ** Changed in: zeitgeist Assignee: Siegfried Gevatter (rainct) = Seif Lotfy (seif) ** Changed in: zeitgeist Status: Confirmed = In Progress ** Branch linked: lp:~zeitgeist/zeitgeist/fix-909708 -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/909708 Title: Inserting event with two subjects with the same URI breaks the following event Status in Zeitgeist Framework: In Progress Bug description: By the way our database is structured, all subjects of a same event must have different URIs. However, this isn't currently being checked, with the effect that the first subject is inserted correctly, while the second subject triggers the existing event exception and rolls back the event ID. This has the effect that the next event to be inserted will incorrectly have the same event ID (thus its subjects are mixed into whatever got saved of the first event and all sorts of weirdness :P). To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/909708/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 909708] Re: Inserting event with two subjects with the same URI breaks the following event
Ok, let's go with option #3. -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/909708 Title: Inserting event with two subjects with the same URI breaks the following event Status in Zeitgeist Framework: Confirmed Bug description: By the way our database is structured, all subjects of a same event must have different URIs. However, this isn't currently being checked, with the effect that the first subject is inserted correctly, while the second subject triggers the existing event exception and rolls back the event ID. This has the effect that the next event to be inserted will incorrectly have the same event ID (thus its subjects are mixed into whatever got saved of the first event and all sorts of weirdness :P). To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/909708/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 909708] Re: Inserting event with two subjects with the same URI breaks the following event
Committed a test case reproducing this in revision 350. --- def testInsertWithDuplicateSubject(self): events = parse_events(test/data/three_events.js) events[0].subjects.append(list(events[0].subjects[0])) ids = self.insertEventsAndWait(events) self.assertEquals(3, len(set(ids))) --- -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/909708 Title: Inserting event with two subjects with the same URI breaks the following event Status in Zeitgeist Framework: Confirmed Bug description: By the way our database is structured, all subjects of a same event must have different URIs. However, this isn't currently being checked, with the effect that the first subject is inserted correctly, while the second subject triggers the existing event exception and rolls back the event ID. This has the effect that the next event to be inserted will incorrectly have the same event ID (thus its subjects are mixed into whatever got saved of the first event and all sorts of weirdness :P). To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/909708/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 909708] Re: Inserting event with two subjects with the same URI breaks the following event
Options: 1. Add a check to see if there are any duplicate subjects. If so, rollback all insertions done to that point and throw an exception. 2. Just ignore the second and later subjects with the same URI and keep going. 3. DELETE what was inserted of that particular event and return 0 for it (but insert all other events). -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/909708 Title: Inserting event with two subjects with the same URI breaks the following event Status in Zeitgeist Framework: Confirmed Bug description: By the way our database is structured, all subjects of a same event must have different URIs. However, this isn't currently being checked, with the effect that the first subject is inserted correctly, while the second subject triggers the existing event exception and rolls back the event ID. This has the effect that the next event to be inserted will incorrectly have the same event ID (thus its subjects are mixed into whatever got saved of the first event and all sorts of weirdness :P). To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/909708/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Bug 909708] Re: Inserting event with two subjects with the same URI breaks the following event
Option 3 makes most sense but IMHO it would be good to inform the developer of the error On Thu, Dec 29, 2011 at 3:13 PM, Siegfried Gevatter rai...@ubuntu.comwrote: Options: 1. Add a check to see if there are any duplicate subjects. If so, rollback all insertions done to that point and throw an exception. 2. Just ignore the second and later subjects with the same URI and keep going. 3. DELETE what was inserted of that particular event and return 0 for it (but insert all other events). -- You received this bug notification because you are subscribed to The Zeitgeist Project. https://bugs.launchpad.net/bugs/909708 Title: Inserting event with two subjects with the same URI breaks the following event Status in Zeitgeist Framework: Confirmed Bug description: By the way our database is structured, all subjects of a same event must have different URIs. However, this isn't currently being checked, with the effect that the first subject is inserted correctly, while the second subject triggers the existing event exception and rolls back the event ID. This has the effect that the next event to be inserted will incorrectly have the same event ID (thus its subjects are mixed into whatever got saved of the first event and all sorts of weirdness :P). To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/909708/+subscriptions -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/909708 Title: Inserting event with two subjects with the same URI breaks the following event Status in Zeitgeist Framework: Confirmed Bug description: By the way our database is structured, all subjects of a same event must have different URIs. However, this isn't currently being checked, with the effect that the first subject is inserted correctly, while the second subject triggers the existing event exception and rolls back the event ID. This has the effect that the next event to be inserted will incorrectly have the same event ID (thus its subjects are mixed into whatever got saved of the first event and all sorts of weirdness :P). To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/909708/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
