[Zeitgeist] [Merge] lp:~rainct/zeitgeist/monitor-queue into lp:zeitgeist

2012-02-01 Thread noreply
The proposal to merge lp:~rainct/zeitgeist/monitor-queue into lp:zeitgeist has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~rainct/zeitgeist/monitor-queue/+merge/90720 -- https://code.launchpad.net/~rainct/zeitgeist/monitor-queue/+merge/90720

Re: [Zeitgeist] [Merge] lp:~rainct/zeitgeist/monitor-queue into lp:zeitgeist

2012-01-31 Thread Michal Hruby
Review: Needs Fixing 22 +[Compact] 23 +private class InsertionData : NotificationData I can't help it, but this looks like serious misusage of the type system, I'd rather go with single compact class that has an enum indicating the type plus a method that

[Zeitgeist] [Merge] lp:~rainct/zeitgeist/monitor-queue into lp:zeitgeist

2012-01-31 Thread Michal Hruby
The proposal to merge lp:~rainct/zeitgeist/monitor-queue into lp:zeitgeist has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~rainct/zeitgeist/monitor-queue/+merge/90720 -- https://code.launchpad.net/~rainct/zeitgeist/monitor-queue/+merge

[Zeitgeist] [Merge] lp:~rainct/zeitgeist/monitor-queue into lp:zeitgeist

2012-01-30 Thread Siegfried Gevatter
/monitor-queue/+merge/90720 Your team Zeitgeist Framework Team is requested to review the proposed merge of lp:~rainct/zeitgeist/monitor-queue into lp:zeitgeist. === modified file 'src/notify.vala' --- src/notify.vala 2011-10-20 14:20:17 + +++ src/notify.vala 2012-01-30 15:48:24 + @@ -32,7