The test you added will pass if no events are found. While a test for template
matching with multiple subjects is also useful, what I meant for a test where
you insert and retrieve an event with 2 subjects, validating that it worked.
--
https://code.launchpad.net/~seif/zeitgeist/clean-up-get-eve
Seif Lotfy has proposed merging lp:~seif/zeitgeist/clean-up-get-events into
lp:zeitgeist.
Requested reviews:
Zeitgeist Framework Team (zeitgeist)
I cleaned up and shortend the code
I am not sure how much performance increase we get out of that but I think its
much more compact now.
All tests
Something looks to be ascrew if an event has multiple subject? But it looks
like that was also the case before this branch..? Do we have a test for this?
Can you re-insert the comment about returning None for missing events - I think
it's nice to note there that it is our API contract.
But look
3 matches
Mail list logo
