The proposal to merge lp:~tdfischer/zeitgeist/bluebird into lp:zeitgeist has
been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~tdfischer/zeitgeist/bluebird/+merge/97026
--
https://code.launchpad.net/~tdfischer/zeitgeist/bluebird/+merge/97026
You
Review: Approve
ok thinks looks good I will merge it
--
https://code.launchpad.net/~tdfischer/zeitgeist/bluebird/+merge/97026
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.
___
Mailing list: https://launchpad.net/~zeitgeist
P
Branch updated.
--
https://code.launchpad.net/~tdfischer/zeitgeist/bluebird/+merge/97026
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.
___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.
> TableLookup is still then just internal API.
Indeed, we don't need to care about binary compability here. get_id / find_id
is very ambiguous, I'd rather get rid of both, and have a more common try_
variant (perhaps id_for_string / id_try_string), so just something that makes
the insertion sid
2012/3/13 Seif Lotfy :
> but he has a point there since we did want to set up libzg 2 based on the
> internals of zeitgeist
Yes, so it's time to get nice clean APIs before stuff gets exposed.
But anyway, TableLookup is still then just internal API.
--
https://code.launchpad.net/~tdfischer/zeitge
but he has a point there since we did want to set up libzg 2 based on the
internals of zeitgeist
On Tue, Mar 13, 2012 at 8:55 PM, Siegfried Gevatter wrote:
> Not a problem, everything in lp:zeitgeist is private API so far :).
> --
> https://code.launchpad.net/~tdfischer/zeitgeist/bluebird/+merge/
michal?
On Tue, Mar 13, 2012 at 8:51 PM, Trever Fischer wrote:
> Finding an ID simply searches for an ID and returns -1 if one is not found.
>
> Getting an ID is defined as returning a valid ID number for the given
> string one way or another.
>
> Adding a default argument to a vala method that
Not a problem, everything in lp:zeitgeist is private API so far :).
--
https://code.launchpad.net/~tdfischer/zeitgeist/bluebird/+merge/97026
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.
___
Mailing list: https://launchpad.net
Finding an ID simply searches for an ID and returns -1 if one is not found.
Getting an ID is defined as returning a valid ID number for the given string
one way or another.
Adding a default argument to a vala method that is public breaks source and
binary compatability with users of the generat
same here
--
https://code.launchpad.net/~tdfischer/zeitgeist/bluebird/+merge/97026
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.
___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
U
Hm, personally I'd prefer a "bool create=false" parameter in get_id. Having
get_ and find_ is kinda confusing (esp. with get_ inserting stuff :p).
--
https://code.launchpad.net/~tdfischer/zeitgeist/bluebird/+merge/97026
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.
___
Trever Fischer has proposed merging lp:~tdfischer/zeitgeist/bluebird into
lp:zeitgeist.
Requested reviews:
Seif Lotfy (seif)
For more details, see:
https://code.launchpad.net/~tdfischer/zeitgeist/bluebird/+merge/97026
Fixes #953041
--
https://code.launchpad.net/~tdfischer/zeitgeist/bluebird/
12 matches
Mail list logo
