[Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bluebird-no-distinct into lp:zeitgeist

2011-12-31 Thread noreply
The proposal to merge lp:~zeitgeist/zeitgeist/bluebird-no-distinct into lp:zeitgeist has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird-no-distinct/+merge/87175 -- https://code.launchpad.net/~zeitgeist/zeitgeist/blueb

[Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bluebird-no-distinct into lp:zeitgeist

2011-12-31 Thread Michal Hruby
The proposal to merge lp:~zeitgeist/zeitgeist/bluebird-no-distinct into lp:zeitgeist has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird-no-distinct/+merge/87175 -- https://code.launchpad.net/~zeitgeist/zeitgeist

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bluebird-no-distinct into lp:zeitgeist

2011-12-31 Thread Michal Hruby
Review: Approve As the query plans show, without the DISTINCT sql doesn't need to build one temp b-tree, so it's slightly faster. -- https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird-no-distinct/+merge/87175 Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist. ___

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bluebird-no-distinct into lp:zeitgeist

2011-12-30 Thread Michal Hruby
33 +event_ids += event_id; We could be more clever here, this will cause 3-6 reallocations in common cases, perhaps the array should be preallocated to `int.min(max_events, 128)`? (for non-zero max_events). -- https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird-no-dist

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bluebird-no-distinct into lp:zeitgeist

2011-12-30 Thread Siegfried Gevatter
>From #sqlite: --- Hi. I've got a question: do .step() calls (internally) just look for the next row, or does the first .step() call already process everything? Particularly, I'm wondering if removing a LIMIT from a query and instead aborting the whil

[Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bluebird-no-distinct into lp:zeitgeist

2011-12-30 Thread Siegfried Gevatter
Siegfried Gevatter has proposed merging lp:~zeitgeist/zeitgeist/bluebird-no-distinct into lp:zeitgeist. Requested reviews: Zeitgeist Framework Team (zeitgeist) For more details, see: https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird-no-distinct/+merge/87175 -- https://code.launchpad.ne