Review: Approve
282 +throw err;
289 +throw err;
293 +throw err;
Seems like it could be moved out of the ifs.
Other than that it's fine.
--
https://code.launchpad.net/~zeitgeist/zeitgeist/dbfails/+merge/87195
Your team
The proposal to merge lp:~zeitgeist/zeitgeist/dbfails into lp:zeitgeist has
been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~zeitgeist/zeitgeist/dbfails/+merge/87195
--
https://code.launchpad.net/~zeitgeist/zeitgeist/dbfails/+merge/87195
Your
Review: Needs Fixing
Yes, please :)
--
https://code.launchpad.net/~zeitgeist/zeitgeist/dbfails/+merge/87195
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.
___
Mailing list: https://launchpad.net/~zeitgeist
Post to :
Review: Needs Fixing
mhr3 RainCT, can you propagate the error one more level up, so there's no
need for the posix.exit?
--
https://code.launchpad.net/~zeitgeist/zeitgeist/dbfails/+merge/87195
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.
4 matches
Mail list logo