[Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/fix772041 into lp:zeitgeist

2011-05-04 Thread noreply
The proposal to merge lp:~zeitgeist/zeitgeist/fix772041 into lp:zeitgeist has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~zeitgeist/zeitgeist/fix772041/+merge/59810 -- https://code.launchpad.net/~zeitgeist/zeitgeist/fix772041/+merge/59810 Your

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/fix772041 into lp:zeitgeist

2011-05-04 Thread Markus Korn
Review: Approve 14:55 < thekorn> RainCT: ACK from me, it does not look nice, but it has one adv. over the old approach, it is descriptive, you see which query belongs to which resulttype at the first glance 14:56 -!- m4n1sh [~manish@ubuntu/member/m4n1sh] has jo

[Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/fix772041 into lp:zeitgeist

2011-05-03 Thread Seif Lotfy
The proposal to merge lp:~zeitgeist/zeitgeist/fix772041 into lp:zeitgeist has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zeitgeist/zeitgeist/fix772041/+merge/59810 -- https://code.launchpad.net/~zeitgeist/zeitgeist/fix772041/+merge/5981

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/fix772041 into lp:zeitgeist

2011-05-03 Thread Seif Lotfy
Although a bit ugly it actually seems to be the best solution we have. I am bothered by the if else statements but I cant find an *performant* way around it... -- https://code.launchpad.net/~zeitgeist/zeitgeist/fix772041/+merge/59810 Your team Zeitgeist Framework Team is requested to review the

[Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/fix772041 into lp:zeitgeist

2011-05-03 Thread Siegfried Gevatter
Siegfried Gevatter has proposed merging lp:~zeitgeist/zeitgeist/fix772041 into lp:zeitgeist. Requested reviews: Zeitgeist Framework Team (zeitgeist) Related bugs: Bug #772041 in Zeitgeist Framework: "Timestamp isn't considered when choosing events by popularity" https://bugs.launchpad.net/