The proposal to merge lp:~zeitgeist/zeitgeist/mimetypes into lp:zeitgeist has
been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~zeitgeist/zeitgeist/mimetypes/+merge/87033
--
https://code.launchpad.net/~zeitgeist/zeitgeist/mimetypes/+merge/87033
Your
The proposal to merge lp:~zeitgeist/zeitgeist/mimetypes into lp:zeitgeist has
been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zeitgeist/zeitgeist/mimetypes/+merge/87033
--
https://code.launchpad.net/~zeitgeist/zeitgeist/mimetypes/+merge/8703
Review: Approve
Perfection.
--
https://code.launchpad.net/~zeitgeist/zeitgeist/mimetypes/+merge/87033
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.
___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@li
Review: Needs Fixing
A couple of optimizations, pls:
- turn the private structs into compact classes (this will require explicit
ownership transfer when adding them to the lists)
- the *_for_* methods should return `unowned string?`
- it'd be nice to sort the register_mimetype calls alphabetical
Siegfried Gevatter has proposed merging lp:~zeitgeist/zeitgeist/mimetypes into
lp:zeitgeist.
Requested reviews:
Michal Hruby (mhr3)
For more details, see:
https://code.launchpad.net/~zeitgeist/zeitgeist/mimetypes/+merge/87033
--
https://code.launchpad.net/~zeitgeist/zeitgeist/mimetypes/+merge
5 matches
Mail list logo