Re: [Zeitgeist] [Merge] lp:~kelemeng/activity-log-manager/bug958483 into lp:activity-log-manager

2012-03-19 Thread मनीष सिन्हा
@Stefano I reviewed yours. It's fine. Will merge it by end of the day -- https://code.launchpad.net/~kelemeng/activity-log-manager/bug958483/+merge/98096 Your team Activity Log Manager is subscribed to branch lp:activity-log-manager. ___ Mailing list:

Re: [Zeitgeist] [Merge] lp:~kelemeng/activity-log-manager/bug958483 into lp:activity-log-manager

2012-03-19 Thread मनीष सिन्हा
Review: Approve @Gabor Cool. Looks fine. Will merge both the branches. I just checked Stefano's diff. Will have a thorough look at the codebcase before making a release. -- https://code.launchpad.net/~kelemeng/activity-log-manager/bug958483/+merge/98096 Your team Activity Log Manager is

Re: [Zeitgeist] [Merge] lp:~kelemeng/activity-log-manager/bug958483 into lp:activity-log-manager

2012-03-18 Thread मनीष सिन्हा
Review: Needs Fixing var last_accessed = time.format(_(%e %B %Y)); These are string formatting for how the time should be rendered. It doesn't get printed on the screen. It doesn't need to be translated. var date_string = date.format(_(%d %B %Y)); Same var date_string = date.format(_(%d %B

Re: [Zeitgeist] [Merge] lp:~kelemeng/activity-log-manager/bug958483 into lp:activity-log-manager

2012-03-18 Thread Stefano Candori
Manish, those gettext changes are already in my branch.. could you review my merge request? Stefano Candori Il giorno 18/mar/2012 19:47, Manish Sinha (मनीष सिन्हा manishsi...@ubuntu.com ha scritto: Review: Needs Fixing var last_accessed = time.format(_(%e %B %Y)); These are string

Re: [Zeitgeist] [Merge] lp:~kelemeng/activity-log-manager/bug958483 into lp:activity-log-manager

2012-03-18 Thread Gabor Kelemen
var last_accessed = time.format(_(%e %B %Y)); These are string formatting for how the time should be rendered. It doesn't get printed on the screen. It doesn't need to be translated. The date gets printed in a format specified by these strings. Preferred date formats are different in