Re: [Zeitgeist] [Merge] lp:~rainct/zeitgeist/find_storage_for_uri into lp:zeitgeist

2012-01-27 Thread Michal Hruby 
Review: Approve

54  +else*/ if (uri_scheme in network_uri_schemes)

Would be nice to add a linebreak there, but otherwise fine...
-- 
https://code.launchpad.net/~rainct/zeitgeist/find_storage_for_uri/+merge/90423
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp

Re: [Zeitgeist] [Merge] lp:~rainct/zeitgeist/find_storage_for_uri into lp:zeitgeist

2012-01-27 Thread Michal Hruby 
Review: Needs Fixing

38  +string uri_scheme = uri.substring (0, uri.index_of 
("://"));

There's File.get_uri_scheme() for that.

45  +Mount mount = file.find_enclosing_mount ();

I'm really worried here, it's bringing back gvfs and I dont like that one bit, 
can be disable it for now and just distinguish net vs unknown?
-- 
https://code.launchpad.net/~rainct/zeitgeist/find_storage_for_uri/+merge/90423
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp