Re: [Zeitgeist] [Merge] lp:~seif/zeitgeist/fix-738555 into lp:zeitgeist

2011-04-22 Thread Siegfried Gevatter
> Add a try except block in the _write_to_disk method > Fixed some indents Looks good. Feel free to commit this part already. > Add a counter to write to disk upon every 20 events Why every 20 events? I don't like this, too arbitrary (and it ends writing to disk a lot again). Also, shouldn't rea

Re: [Zeitgeist] [Merge] lp:~seif/zeitgeist/fix-738555 into lp:zeitgeist

2011-04-22 Thread Seif Lotfy
Add a try except block in the _write_to_disk method Add a counter to write to disk upon every 20 events Fixed some indents -- https://code.launchpad.net/~seif/zeitgeist/fix-738555/+merge/58818 Your team Zeitgeist Framework Team is requested to review the proposed merge of lp:~seif/zeitgeist/fix-7