Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bug695311 into lp:zeitgeist

2011-01-10 Thread Mikkel Kamstrup Erlandsen
Sorry i mean I have *not* done test runs... :-) -- https://code.launchpad.net/~zeitgeist/zeitgeist/bug695311/+merge/44850 Your team Zeitgeist Framework Team is subscribed to branch lp:~zeitgeist/zeitgeist/bug695311. ___ Mailing list: https://launchpad.

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bug695311 into lp:zeitgeist

2011-01-10 Thread Mikkel Kamstrup Erlandsen
Review: Approve I have done any test runs, but this looks sane to me -- https://code.launchpad.net/~zeitgeist/zeitgeist/bug695311/+merge/44850 Your team Zeitgeist Framework Team is subscribed to branch lp:~zeitgeist/zeitgeist/bug695311. ___ Mailing lis

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bug695311 into lp:zeitgeist

2011-01-05 Thread Siegfried Gevatter
I haven't checked, but Zeitgeist should be receiving a SIGTERM at system poweroff (and it's also the default signal sent by "kill"). This way we try to ensure that Zeitgeist always ends nicely (ie. mostly always other than if there's an uncached exception or a SIGKILL). -- https://code.launchpa

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bug695311 into lp:zeitgeist

2011-01-03 Thread Markus Korn
Review: Needs Information Siegfried, you added an additional handler for SIGTERM. Can you please elaborate when we receive such kind of signals. I mean we clearly documented SIGHUB as a tool for distributors, and I would like to see the same documentation for SIGTERM too. -- https://code.launch

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bug695311 into lp:zeitgeist

2010-12-29 Thread Seif Lotfy
Review: Approve forgot the +1 -- https://code.launchpad.net/~zeitgeist/zeitgeist/bug695311/+merge/44850 Your team Zeitgeist Framework Team is subscribed to branch lp:~zeitgeist/zeitgeist/bug695311. ___ Mailing list: https://launchpad.net/~zeitgeist Pos

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bug695311 into lp:zeitgeist

2010-12-29 Thread Seif Lotfy
Changing to dict is a big improvement for me and makes it easier to comprehend. All in all its pretty straight forward and i like the unload method. I would suggest writing to disk every 5 minutes or every time a new application opens, instead of "on zeitgeist exit" but this is just a suggestion