I think it's valuable to be able to tell where we use ?-substitution, so I'll
leave that as is. The print statement was a slip of mind, I'll fix that and
then merge. Thanks for reviewing!
--
https://code.launchpad.net/~zeitgeist/zeitgeist/explain-logs/+merge/35334
Your team Zeitgeist Framework T
I'm not sure, but maybe the queries are more readable if we replace '?' by the
actual values:
=== modified file '_zeitgeist/engine/sql.py'
--- _zeitgeist/engine/sql.py2010-09-13 20:55:00 +
+++ _zeitgeist/engine/sql.py2010-09-14 07:40:46 +
@@ -38,9 +38,11 @@
def explain_query(c
Review: Approve
Looks good, and it does not have to be perfect as it is for internal use only,
but I'd like to avoid the 'print' statement and put it in a logging statement.
This way it would be possible to redirect logging output of the 'zeitgeist.sql'
domain to some file etc.
Proposed diff:
3 matches
Mail list logo
