Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/remove-datahub into lp:zeitgeist
Review: Approve All tests are running fine, zeitgeist-daemon is looking good, and it seems to me that you managed to remove everything related to the old datahub, Good work. -- https://code.launchpad.net/~zeitgeist/zeitgeist/remove-datahub/+merge/38339 Your team Zeitgeist Framework Team is subscribed to branch lp:~zeitgeist/zeitgeist/remove-datahub. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/remove-datahub into lp:zeitgeist
Seif, that's looking much better ;) I could not find you on irc, so I did a few changes to zeitgeist-daemon.py which came into my mind while reading the code, please contact me if you think they don't make sense... -- https://code.launchpad.net/~zeitgeist/zeitgeist/remove-datahub/+merge/38339 Your team Zeitgeist Framework Team is requested to review the proposed merge of lp:~zeitgeist/zeitgeist/remove-datahub into lp:zeitgeist. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/remove-datahub into lp:zeitgeist
Hey Markus, Sorry about that. I ran the make check and forgot to run the proper dameon. Very sorry. The fix is up. Cheers Seif -- https://code.launchpad.net/~zeitgeist/zeitgeist/remove-datahub/+merge/38339 Your team Zeitgeist Framework Team is requested to review the proposed merge of lp:~zeitgeist/zeitgeist/remove-datahub into lp:zeitgeist. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/remove-datahub into lp:zeitgeist
Hi Seif, thanks for working on this. But why are you proposing branch to be merged into lp:zeitgeist although they are obviously not working. A simple "./zeitgeist-daemon" and a close look to zeitgeist-daemon.py will show you at least two *very* obvious errors. I personally don't find it motivating being ask for a review of a branch which obviously has not been tested by the author -- https://code.launchpad.net/~zeitgeist/zeitgeist/remove-datahub/+merge/38339 Your team Zeitgeist Framework Team is requested to review the proposed merge of lp:~zeitgeist/zeitgeist/remove-datahub into lp:zeitgeist. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
