Re: [zeromq-dev] Proposal for a revised zlist API

2014-09-12 Thread Goswin von Brederlow
On Wed, Sep 10, 2014 at 06:42:18PM +0200, Pieter Hintjens wrote: Sorry, I've lost track of some of the details here. Could you re-describe your timeout queue starting from the problem so I can think about how I'd implement it? Thanks Pieter The problem is that every connected host has a

Re: [zeromq-dev] Proposal for a revised zlist API

2014-09-10 Thread Goswin von Brederlow
On Mon, Sep 08, 2014 at 07:02:53PM +0200, Pieter Hintjens wrote: On Mon, Sep 8, 2014 at 6:42 PM, Goswin von Brederlow goswin-...@web.de wrote: Urgs. :-) If zlist gets deprecated then there needs to be a new list (zring) that preserves the strict fifo ordering and simplicity of a

Re: [zeromq-dev] Proposal for a revised zlist API

2014-09-10 Thread Pieter Hintjens
Sorry, I've lost track of some of the details here. Could you re-describe your timeout queue starting from the problem so I can think about how I'd implement it? Thanks Pieter On Wed, Sep 10, 2014 at 6:28 PM, Goswin von Brederlow goswin-...@web.de wrote: On Mon, Sep 08, 2014 at 07:02:53PM

Re: [zeromq-dev] Proposal for a revised zlist API

2014-09-08 Thread Goswin von Brederlow
On Sun, Sep 07, 2014 at 07:11:52PM +0200, Pieter Hintjens wrote: Hi Goswin, So the upshot of this is, (a) zlist is as-was, and represents a simple, stupid list; (b) zhash has some of the new stuff like item destructor and duplicator, at the cost of slight breakage in zhash_dup; (c) zring is

Re: [zeromq-dev] Proposal for a revised zlist API

2014-09-08 Thread Pieter Hintjens
On Mon, Sep 8, 2014 at 6:42 PM, Goswin von Brederlow goswin-...@web.de wrote: Urgs. :-) If zlist gets deprecated then there needs to be a new list (zring) that preserves the strict fifo ordering and simplicity of a list. We don't need to deprecate zlist then, rather we can keep it as the

Re: [zeromq-dev] Proposal for a revised zlist API

2014-09-07 Thread Pieter Hintjens
Hi Goswin, So the upshot of this is, (a) zlist is as-was, and represents a simple, stupid list; (b) zhash has some of the new stuff like item destructor and duplicator, at the cost of slight breakage in zhash_dup; (c) zring is now a hybrid list+hash container that starts to look like something

Re: [zeromq-dev] Proposal for a revised zlist API

2014-09-06 Thread Pieter Hintjens
OK, after spending way too long on this, I'd like to revert all changes to zlist, deprecate that class, and make zring the new V3 list container, doing everything properly and cleanly. This makes it very easy for developers to spot old vs new constructs. I think we've gone too far down the rabbit

Re: [zeromq-dev] Proposal for a revised zlist API

2014-09-06 Thread Pieter Hintjens
Also, sorted lists... it makes sense, however I think what we're really wanting is a container provides both keyed and sequential (sorted) access. Either a tree (there was a ztree class that I killed a while back, as it had imported a lot of horrid code from elsewhere), or a combination hash/ring.

Re: [zeromq-dev] Proposal for a revised zlist API

2014-09-05 Thread Goswin von Brederlow
Just saw your commit. 1) Small typos: The comment for zlist_dup mentions zhash_dup_v2. The comments for zlist_sort talk about key and value and straight ASCII comparison. But sorting goes by the compare function. 2) zlist_purge does not destroy the cursor allowing zlist_next and zlist_item

Re: [zeromq-dev] Proposal for a revised zlist API

2014-09-05 Thread Goswin von Brederlow
On Fri, Sep 05, 2014 at 03:56:56PM +0200, Goswin von Brederlow wrote: 12) Can we add the void *user argument to czmq_destructor and czmq_comparator? That would be realy usefull for keeping items in 2 container like zcertstore does among other things. czmq_destructor and czmq_duplicator I mean.

Re: [zeromq-dev] Proposal for a revised zlist API

2014-09-05 Thread Pieter Hintjens
On Fri, Sep 5, 2014 at 3:56 PM, Goswin von Brederlow goswin-...@web.de wrote: Just saw your commit. You only found 17 issues? :-) I was coding till 1am, surprising it worked at all. 1) Small typos Fixed. 2) zlist_purge does not destroy the cursor allowing zlist_next and zlist_item access

Re: [zeromq-dev] Proposal for a revised zlist API

2014-09-05 Thread Goswin von Brederlow
On Fri, Sep 05, 2014 at 05:49:20PM +0200, Pieter Hintjens wrote: On Fri, Sep 5, 2014 at 3:56 PM, Goswin von Brederlow goswin-...@web.de wrote: Just saw your commit. You only found 17 issues? :-) I was coding till 1am, surprising it worked at all. 1) Small typos Fixed. 2)

[zeromq-dev] Proposal for a revised zlist API

2014-09-04 Thread Goswin von Brederlow
Hi, I've gone over the zlist API and redesigned it according to some ideas we had last month (partly for the zring class). I tried this out on zlist to see how the ideas would fit but the idea would be to change all the classes where appropriate so they behave the same. Preparing for that I

Re: [zeromq-dev] Proposal for a revised zlist API

2014-09-04 Thread Goswin von Brederlow
On Thu, Sep 04, 2014 at 04:59:19PM +0200, Goswin von Brederlow wrote: Hi, I've gone over the zlist API and redesigned it according to some ideas we had last month (partly for the zring class). I tried this out on zlist to see how the ideas would fit but the idea would be to change all the

Re: [zeromq-dev] Proposal for a revised zlist API

2014-09-04 Thread Pieter Hintjens
:-) I started, by coincidence, to make some of these changes already. Hope to have this ready soon. Nothing dramatic, just the global callbacks. We can take the other changes one by one. Breaking the v2 API is not an option, and renaming zlist to another name isn't plausible either IMO. So we