[zeta-dev] Re: Review Request: Session timeout

I was thinking of: $lastActivity = time() - $_SESSION[$this->options->lastActivityTimestampKey] if ( isset( $_SESSION[$this->options->lastActivityTimestampKey] ) && $lastActivity >= $this->options->idleTimeout ) What do you think ?

[zeta-dev] Re: Review Request: Session timeout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/783/ --- (Updated 2011-06-16 05:06:02.239400) Review request for zetacomponents. Changes

Re: [zeta-dev] Two review requests pending

Hi Derick, On Wed, Jun 15, 2011 at 2:58 PM, Derick Rethans wrote: > On Wed, 15 Jun 2011, James Pic wrote: > >> Did you try another browser (maybe webkit based if you used gecko) ? > > No, of course not. I only use Firefox, and if this reviewboard stuff > doesn't work with that I'd say it's pretty

[zeta-dev] Re: Review Request: Session timeout

> On 2011-06-15 12:11:33, james pic wrote: > > trunk/Authentication/src/session/authentication_session.php, line 136 > > > > > > why not use a local variable for that ? would it make the code more > > readable and easier

Re: [zeta-dev] Two review requests pending

On Wed, 15 Jun 2011, James Pic wrote: > Did you try another browser (maybe webkit based if you used gecko) ? No, of course not. I only use Firefox, and if this reviewboard stuff doesn't work with that I'd say it's pretty much broken. cheers, Derick

Re: [zeta-dev] Two review requests pending

Did you try another browser (maybe webkit based if you used gecko) ? It works here with chromium...

[zeta-dev] Re: Review Request: Session timeout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/783/#review844 --- trunk/Authentication/src/session/authentication_session.php

Re: [zeta-dev] Two review requests pending

On Wed, 15 Jun 2011, Jerome Renard wrote: > There are two review requests still pending in Review Board : > > - Idle timeout support in ezcAuthentication : > https://reviews.apache.org/r/783/ , ref ZETACOMP-81 [1] > - multibyte support for strings in ezcTemplate : > https://reviews.apache.org/r/6