Re: [Zim-wiki] Where dangling links go

2010-07-23 Thread Tobias Weber
On 22.07.2010, at 20:43, Tobias Weber wrote:

> It might also be prudent to make the link resolver ignore placeholders.

On closer inspection that's even necessary, depending on how much we want 
dangling links to influence each other. Consider this:

Home
\Subpage

If both exisintg pages contain a dangling [[Bacon]] link, do we only display 
one placeholder, next to home? If the link on Subpage is clicked, will the page 
be created next to Home, or next to Subpage?
___
Mailing list: https://launchpad.net/~zim-wiki
Post to : zim-wiki@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zim-wiki
More help   : https://help.launchpad.net/ListHelp


Re: [Zim-wiki] Where dangling links go

2010-07-22 Thread Jaap Karssenberg
On Thu, Jul 22, 2010 at 8:43 PM, Tobias Weber  wrote:
> On 22.07.2010, at 18:33, Jaap Karssenberg wrote:
>
>> You will see that if you first create the page and then the link it works as 
>> expected.
>
> Then it's not a wiki though ;)

I fully agree :S

>> Need to improve the logic for placeholders to ensure that they are cleaned 
>> up when they mask an existing page.
>
> Let me get this straight: for every dangling link Zim is supposed to display 
> a placeholder where a
> page would be created if it was clicked? Then we'd have to recalculate all 
> placeholders every
> time a new page is created.

Sure, but that is not as bad as it sounds since this only happens in
the sql database and doesn't need to access any pages.

> It might also be prudent to make the link resolver ignore placeholders. I'm 
> not through with the
> index code, but it seems that they end up in the database, so without that 
> users would have to
> rebuild their index to get the fix above.

Yes they need to be in the database since the index widget is a one on
one representation of the database structure.

Would need to implement the additional logic to clean up placeholders
when creating a page. Then we increase the db format version number,
so next time you start zim the database gets rebuild on the fly and
everything will stay in sync.

Regards,

Jaap

___
Mailing list: https://launchpad.net/~zim-wiki
Post to : zim-wiki@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zim-wiki
More help   : https://help.launchpad.net/ListHelp


Re: [Zim-wiki] Where dangling links go

2010-07-22 Thread Tobias Weber
On 22.07.2010, at 18:33, Jaap Karssenberg wrote:

> You will see that if you first create the page and then the link it works as 
> expected.

Then it's not a wiki though ;)

> 1) because you type [[page]] instead of using e.g. the insert link dialog,

I did use the dialog.

> Need to improve the logic for placeholders to ensure that they are cleaned up 
> when they mask an existing page.

Let me get this straight: for every dangling link Zim is supposed to display a 
placeholder where a page would be created if it was clicked? Then we'd have to 
recalculate all placeholders every time a new page is created.

It might also be prudent to make the link resolver ignore placeholders. I'm not 
through with the index code, but it seems that they end up in the database, so 
without that users would have to rebuild their index to get the fix above.

> Probably both these items deserve a bug report

One covered?
https://bugs.launchpad.net/zim/+bug/492656
___
Mailing list: https://launchpad.net/~zim-wiki
Post to : zim-wiki@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zim-wiki
More help   : https://help.launchpad.net/ListHelp


Re: [Zim-wiki] Where dangling links go

2010-07-22 Thread Jaap Karssenberg
On Thu, Jul 22, 2010 at 6:07 PM, Tobias Weber  wrote:
> Hi,
> namespaces are a new concept for me. Is the following the intended behaviour?
>
> Home
> \Subpage
>
> 1. insert a dangling link [[Page]] on Subpage
> 2. at the top level, next to Home, use the context menu to create a new page 
> named "Page"
> 3. now click the link we created on Subpage
>
> Result: below Home a new page is created. Now there are two with the same 
> name in the notebook.
>
> What I expected: jump to the existing page.
>
> The manual says square brackets without : or + "link to page in the current 
> namespace or parents".


The intended behavior is indeed to go to the page in the toplevel
namespace in this case. From testing I see two things that can make
this behavior depend on the order of operation (which in itself can be
considered a bug).

You will see that if you first create the page and then the link it
works as expected.

What goes wrong is that:
1) because you type [[page]] instead of using e.g. the insert link
dialog, the link is not indexed right away (you should see the page
show up in the treeview greyed and italic to show it doesn't have
content yet as soon as it is linked). This issue will be gone when we
enable auto-formatting for this kind of wiki syntax.

2) Once the link is indexed a "placeholder" exists for it (the grey
italic node) and it is linked instead of the top level page. Need to
improve the logic for placeholders to ensure that they are cleaned up
when they mask an existing page.

Probably both these items deserve a bug report (and I see you are
quite active already filing bugs in the tracker :) )

Regards,

Jaap

___
Mailing list: https://launchpad.net/~zim-wiki
Post to : zim-wiki@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zim-wiki
More help   : https://help.launchpad.net/ListHelp


[Zim-wiki] Where dangling links go

2010-07-22 Thread Tobias Weber
Hi,
namespaces are a new concept for me. Is the following the intended behaviour?

Home
\Subpage

1. insert a dangling link [[Page]] on Subpage
2. at the top level, next to Home, use the context menu to create a new page 
named "Page"
3. now click the link we created on Subpage

Result: below Home a new page is created. Now there are two with the same name 
in the notebook.

What I expected: jump to the existing page.

The manual says square brackets without : or + "link to page in the current 
namespace or parents".
___
Mailing list: https://launchpad.net/~zim-wiki
Post to : zim-wiki@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zim-wiki
More help   : https://help.launchpad.net/ListHelp