Re: [Zim-wiki] about bug #608822

2011-02-23 Thread Lisa Vitolo
> I would understand the bug report that way, that the 'Go-child' menu is
> a good example how other menu items should work.

You're absolutely right. I don't know why, I understood it like "the
Go-child menu is a good example about how this bug can be bad for
users" or a thing like that, but now I realize I was wrong. So guess
I'm going to take care of the other menu items.

> Maybe the item should be activ, when the cursor is on a link or object.
> For the selection, the edit action does not work, when the selection
> contains more than a link (two links or a link and a bullet).
>
> best regards,
>  stefan
>

Yes I'm noticing it displays unprintable characters in the dialog box,
and it gets things a bit wrong especially if some normal text falls
between links.

@Jaap, sorry, I'm sending this message just to close the subject, but
I will use the comments next time!
Lisa

-- 
Nondeterminism means never having to say you are wrong

___
Mailing list: https://launchpad.net/~zim-wiki
Post to : zim-wiki@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zim-wiki
More help   : https://help.launchpad.net/ListHelp


Re: [Zim-wiki] about bug #608822

2011-02-23 Thread Jaap Karssenberg
On Wed, Feb 23, 2011 at 4:56 PM, Lisa Vitolo  wrote:
> I was looking around in the code for this bug. According to the
> description: "The Go menu is exemplary: when the page displayed has no
> children, "Child" is not sensitive". I have the 0.50 version of zim
> and the last release from bzr, but can't seem to reproduce this part
> of the bug anywhere: the "Go to child" menu voice is deactived when
> the current page has no children, and actived otherwise. Is there
> already a solution for this problem, or does it turn up just in some
> situations?

I think the report mentions the "Go Child" as an example where behavior is OK.

To my mind only remaining item in the report are items in the Edit
menu that need to switch sensitivity.

> And for the "Edit/remove link" voice which is always activated, it
> should be deactived when the current page has no links, or just when
> selecting some text which doesn't contain any link? I personally would
> go for the second.

These options work on a link under the cursor, so they need to become
sensitive only when the cursor is at a link. This requires the
pageview to send a signal when the cursor enters / leaves a link. This
signal can then be used to toggle sensitivity of these actions.

Btw. this discussion should probably go in the bug tracker comments,
not to the whole mailing list.

Regards,

Jaap

___
Mailing list: https://launchpad.net/~zim-wiki
Post to : zim-wiki@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zim-wiki
More help   : https://help.launchpad.net/ListHelp


[Zim-wiki] about bug #608822

2011-02-23 Thread Lisa Vitolo
Hi,

I was looking around in the code for this bug. According to the
description: "The Go menu is exemplary: when the page displayed has no
children, "Child" is not sensitive". I have the 0.50 version of zim
and the last release from bzr, but can't seem to reproduce this part
of the bug anywhere: the "Go to child" menu voice is deactived when
the current page has no children, and actived otherwise. Is there
already a solution for this problem, or does it turn up just in some
situations?

And for the "Edit/remove link" voice which is always activated, it
should be deactived when the current page has no links, or just when
selecting some text which doesn't contain any link? I personally would
go for the second.

Lisa

-- 
Nondeterminism means never having to say you are wrong

___
Mailing list: https://launchpad.net/~zim-wiki
Post to : zim-wiki@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zim-wiki
More help   : https://help.launchpad.net/ListHelp