Re: [Zim-wiki] How to set up e-mail sending?
Hi, On Thu, Mar 04, 2010 at 09:27:04AM +0100, Jaap Karssenberg wrote: > On Thu, Mar 4, 2010 at 9:02 AM, wrote: > > A patch for seperate url_encoding of the two parameters is attached (but > > for some pages, I still don't get the whole body. Will look at this > > later). > > > > @Japp: do you prefere the launchpad merge request feature for small > > patches like these? > > No need to upload a complete branch to launchpad, but it is always > good to open a bug report and attach it, so it doesn't get overlooked. done. regards, stefan ___ Mailing list: https://launchpad.net/~zim-wiki Post to : zim-wiki@lists.launchpad.net Unsubscribe : https://launchpad.net/~zim-wiki More help : https://help.launchpad.net/ListHelp
Re: [Zim-wiki] How to set up e-mail sending?
Maybe I should add, that I am using thunderbird as mail-client and not xdg. When using this option, a blank page is opened in firefox. regards, stefan On Thu, Mar 04, 2010 at 10:29:41AM +0100, s...@z107.de wrote: > Hi, > > On Thu, Mar 04, 2010 at 10:15:24AM +0100, Vlastimil Ott wrote: > > Dne Čt 4. března 2010 09:02:47 s...@z107.de napsal(a): > > > zim url_encodes the whole mailto-link, so also the ? which separates > > > mailto: from subject= is replaced by "%3F". > > > > Well I think this is a patch for the situation when I click the link. But I > > meant the menu command > > File | Send - I want to send the whole page as e-mail (body or attachment, > > doesn't matter). > > > > no, I am using the File - 'Send to' function too. Internally it seems to > work by mailto: links. > Did you try the patch? The text of the page should appear in the body, > but for some pages only the heading is transfered, but not the rest of the > page. Same for you? > > regards, > stefan > > ___ > Mailing list: https://launchpad.net/~zim-wiki > Post to : zim-wiki@lists.launchpad.net > Unsubscribe : https://launchpad.net/~zim-wiki > More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~zim-wiki Post to : zim-wiki@lists.launchpad.net Unsubscribe : https://launchpad.net/~zim-wiki More help : https://help.launchpad.net/ListHelp
Re: [Zim-wiki] How to set up e-mail sending?
Hi, On Thu, Mar 04, 2010 at 10:15:24AM +0100, Vlastimil Ott wrote: > Dne Čt 4. března 2010 09:02:47 s...@z107.de napsal(a): > > zim url_encodes the whole mailto-link, so also the ? which separates > > mailto: from subject= is replaced by "%3F". > > Well I think this is a patch for the situation when I click the link. But I > meant the menu command > File | Send - I want to send the whole page as e-mail (body or attachment, > doesn't matter). > no, I am using the File - 'Send to' function too. Internally it seems to work by mailto: links. Did you try the patch? The text of the page should appear in the body, but for some pages only the heading is transfered, but not the rest of the page. Same for you? regards, stefan ___ Mailing list: https://launchpad.net/~zim-wiki Post to : zim-wiki@lists.launchpad.net Unsubscribe : https://launchpad.net/~zim-wiki More help : https://help.launchpad.net/ListHelp
Re: [Zim-wiki] How to set up e-mail sending?
Dne Čt 4. března 2010 09:02:47 s...@z107.de napsal(a): > zim url_encodes the whole mailto-link, so also the ? which separates > mailto: from subject= is replaced by "%3F". Well I think this is a patch for the situation when I click the link. But I meant the menu command File | Send - I want to send the whole page as e-mail (body or attachment, doesn't matter). Or am I wrong? Thanks for clarification. -- Vlastimil Ott www.e-ott.info Stahujte časopis o softwaru. Zdarma. http://www.openmagazin.cz ___ Mailing list: https://launchpad.net/~zim-wiki Post to : zim-wiki@lists.launchpad.net Unsubscribe : https://launchpad.net/~zim-wiki More help : https://help.launchpad.net/ListHelp
Re: [Zim-wiki] How to set up e-mail sending?
On Thu, Mar 4, 2010 at 9:02 AM, wrote: > A patch for seperate url_encoding of the two parameters is attached (but > for some pages, I still don't get the whole body. Will look at this > later). > > @Japp: do you prefere the launchpad merge request feature for small > patches like these? No need to upload a complete branch to launchpad, but it is always good to open a bug report and attach it, so it doesn't get overlooked. Typically I will go over the bug tracker about once a week, fix any small bugs that are filed, classify less trivial bugs and apply any patches that were added. Regards, Jaap ___ Mailing list: https://launchpad.net/~zim-wiki Post to : zim-wiki@lists.launchpad.net Unsubscribe : https://launchpad.net/~zim-wiki More help : https://help.launchpad.net/ListHelp
Re: [Zim-wiki] How to set up e-mail sending?
Hi,
On Wed, Mar 03, 2010 at 11:20:25PM +0100, Vlastimil Ott wrote:
> Hello all,
>
> trying to send the page in a mail. I use Mandriva Linux, KMail for mailing.
> Zim runs a script called
> xdg-email, this is a FreeDesktop.org standard. When I click File | Send,
> KMail's composer pops up.
> However the page text doesn't fill the email body but addressee. Some tens of
> addressees are
> created. It seems that the script does not receive the correct arguments. It
> has some parameters
> like --body or --subject but I don't know where to set them up. Any help?
>
zim url_encodes the whole mailto-link, so also the ? which separates
mailto: from subject= is replaced by "%3F".
A patch for seperate url_encoding of the two parameters is attached (but
for some pages, I still don't get the whole body. Will look at this
later).
@Japp: do you prefere the launchpad merge request feature for small
patches like these?
best regards,
stefan
=== modified file 'zim/gui/__init__.py'
--- zim/gui/__init__.py 2010-02-26 22:18:42 +
+++ zim/gui/__init__.py 2010-03-04 07:56:50 +
@@ -886,7 +886,8 @@
def email_page(self):
text = ''.join(self.page.dump(format='plain'))
- url = url_encode('mailto:?subject=%s&body=%s' % (self.page.name, text))
+ url = 'mailto:?subject=%s&body=%s' % (url_encode(self.page.name),
+url_encode(text))
self.open_url(url)
def import_page(self):
___
Mailing list: https://launchpad.net/~zim-wiki
Post to : zim-wiki@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zim-wiki
More help : https://help.launchpad.net/ListHelp
