Re: [ZODB-Dev] RFC: Attempts at Python2-compatible pickles cause unpicklable objects

2013-06-12 Thread Stephan Richter
On Wednesday, June 12, 2013 01:23:35 PM Tres Seaver wrote: > Am I the only person affected? Or do we need to add "fallback" code to > permit opening a filestorage with an older magic number in read-only > mode? In my case, the data is all test stuff, so I can just blow it away > and recreate it.

Re: [ZODB-Dev] RFC: Attempts at Python2-compatible pickles cause unpicklable objects

2013-06-12 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/08/2013 02:03 AM, Tres Seaver wrote: > One point to consider is that anybody who has been using ZODB on Py3k > since the beta will have to do surgeery on their filestorages to get > them to load after that change (the code doesn't make any atte

Re: [ZODB-Dev] RFC: Attempts at Python2-compatible pickles cause unpicklable objects

2013-06-07 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/07/2013 09:56 AM, Jim Fulton wrote: > On Fri, Jun 7, 2013 at 3:02 AM, Marius Gedminas > wrote: >> On Thu, Jun 06, 2013 at 09:43:16PM -0400, Stephan Richter wrote: >>> On Thursday, June 06, 2013 09:28:38 PM Tres Seaver wrote: If I am correct

Re: [ZODB-Dev] RFC: Attempts at Python2-compatible pickles cause unpicklable objects

2013-06-07 Thread Jim Fulton
On Fri, Jun 7, 2013 at 3:02 AM, Marius Gedminas wrote: > On Thu, Jun 06, 2013 at 09:43:16PM -0400, Stephan Richter wrote: >> On Thursday, June 06, 2013 09:28:38 PM Tres Seaver wrote: >> > If I am correct about this consensus, then in addition to merging PR #11 >> > for ZODB, we should also drop th

Re: [ZODB-Dev] RFC: Attempts at Python2-compatible pickles cause unpicklable objects

2013-06-07 Thread Marius Gedminas
On Thu, Jun 06, 2013 at 09:43:16PM -0400, Stephan Richter wrote: > On Thursday, June 06, 2013 09:28:38 PM Tres Seaver wrote: > > If I am correct about this consensus, then in addition to merging PR #11 > > for ZODB, we should also drop the 'bytes_as_strings' changes to > > 'zodbpickle'. > > Yes, t

Re: [ZODB-Dev] RFC: Attempts at Python2-compatible pickles cause unpicklable objects

2013-06-06 Thread Stephan Richter
On Thursday, June 06, 2013 09:28:38 PM Tres Seaver wrote: > If I am correct about this consensus, then in addition to merging PR #11 > for ZODB, we should also drop the 'bytes_as_strings' changes to > 'zodbpickle'. Yes, this is a left-over from our experimentation. It did not work, since it also

[ZODB-Dev] RFC: Attempts at Python2-compatible pickles cause unpicklable objects

2013-06-06 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I posted an issue, including a gist showing the problem: https://github.com/zopefoundation/ZODB/issues/10 The 'issue_10' branch adds a test (failing without the patch) and a patch for this issue: https://github.com/zopefoundation/ZODB/pull/11 I t