-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Christian Theune wrote: > On Thu, Jun 26, 2008 at 08:32:25PM +0200, Christian Theune wrote: >> Hi, >> >> I think I didn't totally grasp the way that blob savepoints work correctly. >> At >> one of our installations we have lots of .spb files left around. >> >> Looking at the code I don't see where .spb files get cleaned up again on >> savepoint aborts. > > I reviewed the savepoint tests and see that they don't check for cleanup: > neither on rollback, nor on abort. > >> On the bushy branch I found that having the TmpStore create directory >> structures is probably a bad idea. I propose to have it create a directory >> `savepoints` in the temporary directory and create files called >> `oidrepr-tidrepr.spb`. > > I implemented this on the branch and it seems to work well. I find it easier > to inspect on the filesystem than having savepoint state being distributed > over the whole structure.
Did a fix for the leaked saveepoint stuff ever get committed? https://bugs.launchpad.net/zodb/+bug/323067 Can we safely remove anything under tmp/savepoints, assuming that we know there is not a transaction running? Tres. - -- =================================================================== Tres Seaver +1 540-429-0999 tsea...@palladion.com Palladion Software "Excellence by Design" http://palladion.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFKV2O4+gerLs4ltQ4RAjo9AJ0W4ShPfPl7SXCKjQNDm7rNc2ZrGQCglbvL N3WVI/IeVhocIWWNGPnmfDw= =h36T -----END PGP SIGNATURE----- _______________________________________________ For more information about ZODB, see the ZODB Wiki: http://www.zope.org/Wikis/ZODB/ ZODB-Dev mailing list - ZODB-Dev@zope.org http://mail.zope.org/mailman/listinfo/zodb-dev
