Re: [ZODB-Dev] ZODB 3.9.3 history call causing problems for storages that still accept version parameters

2009-11-20 Thread Chris Withers
Christian Theune wrote: Traceback (most recent call last): File ZODB3-3.9.3-py2.6-linux-i686.egg/ZEO/zrpc/connection.py, line 581, in handle_request ret = meth(*args) File gocept.zeoraid-1.0b6-py2.6.egg/gocept/zeoraid/storage.py, line 219, in history assert version is ''

[ZODB-Dev] 3.9.4 release?

2009-11-20 Thread Chris Withers
Hi Jim, It would be great if the two recent fixes I committed could make it into a 3.9.4 release some time soon... What can I do to help this happen? Assuming I do anything necessary, when could you do this release? (or give Christian permission to do it :-) ) cheers, Chris -- Simplistix -

Re: [ZODB-Dev] repozo, neither official nor supported, apparently...

2009-11-20 Thread Chris Withers
Jim Fulton wrote: On Thu, Nov 19, 2009 at 7:01 PM, Chris Withers ch...@simplistix.co.uk wrote: Jim Fulton wrote: There's nothing official or supported about a backup solution without automated tests. So I guess there isn't one. Right, so what does Zope Corp use? We use ZRS, of course.

Re: [ZODB-Dev] 3.9.4 release?

2009-11-20 Thread Jim Fulton
On Fri, Nov 20, 2009 at 5:49 AM, Chris Withers ch...@simplistix.co.uk wrote: Hi Jim, It would be great if the two recent fixes I committed could make it into a 3.9.4 release some time soon... What can I do to help this happen? Assuming I do anything necessary, when could you do this

Re: [ZODB-Dev] repozo, neither official nor supported, apparently...

2009-11-20 Thread Laurence Rowe
2009/11/20 Chris Withers ch...@simplistix.co.uk: Jim Fulton wrote: On Thu, Nov 19, 2009 at 7:01 PM, Chris Withers ch...@simplistix.co.uk wrote: Jim Fulton wrote: There's nothing official or supported about a backup solution without automated tests. So I guess there isn't one. Right, so

Re: [ZODB-Dev] 3.9.4 release?

2009-11-20 Thread Chris Withers
Jim Fulton wrote: I need to review the changes before the release. I'll probably reject the repozo change without an automated test. Are you serious? You'd rather have a broken tool than one that isn't broken on the basis that the existing tests aren't part of the test suite that gets run by

Re: [ZODB-Dev] repozo, neither official nor supported, apparently...

2009-11-20 Thread Jim Fulton
On Fri, Nov 20, 2009 at 9:32 AM, Chris Withers ch...@simplistix.co.uk wrote: Jim Fulton wrote: On Thu, Nov 19, 2009 at 7:01 PM, Chris Withers ch...@simplistix.co.uk wrote: Jim Fulton wrote: There's nothing official or supported about a backup solution without automated tests. So I guess

Re: [ZODB-Dev] 3.9.4 release?

2009-11-20 Thread Jim Fulton
On Fri, Nov 20, 2009 at 9:39 AM, Chris Withers ch...@simplistix.co.uk wrote: Jim Fulton wrote: I need to review the changes before the release. I'll probably reject the repozo change without an automated test. Are you serious? You'd rather have a broken tool than one that isn't broken on

Re: [ZODB-Dev] 3.9.4 release?

2009-11-20 Thread Tim Peters
[Jim Fulton] I need to review the changes before the release. I'll probably reject the repozo change without an automated test. [Chris Withers]\ Are you serious? You'd rather have a broken tool than one that isn't broken on the basis that the existing tests aren't part of the test suite that

Re: [ZODB-Dev] repozo, neither official nor supported, apparently...

2009-11-20 Thread Jeff Shell
On Nov 20, 2009, at 7:32 AM, Chris Withers wrote: Jim Fulton wrote: I'd prefer that there be a file-storage backup solution out of the box. repozo is the logical choice. It sounds like it needs some love though. This isn't something I'd likely get to soon. I'm not sure how much love

Re: [ZODB-Dev] repozo, neither official nor supported, apparently...

2009-11-20 Thread Jim Fulton
On Fri, Nov 20, 2009 at 9:32 AM, Chris Withers ch...@simplistix.co.uk wrote: ... I'm not sure how much love repozo needs. It works, and it won't need changing until FileStorage's format changes, which I don't see happening any time soon. It just occurred to me that repozo doesn't support

Re: [ZODB-Dev] 3.9.4 release?

2009-11-20 Thread Chris Withers
Tim Peters wrote: That's what he said -- and you made him repeat it several times by now. Yes, I find it hard to believe that someone would deliberately break something that someone else has taken the trouble to fix (and run the tests for!)... I've learned my lesson, I won't try and

Re: [ZODB-Dev] repozo, neither official nor supported, apparently...

2009-11-20 Thread Chris Withers
Jim Fulton wrote: On Fri, Nov 20, 2009 at 9:32 AM, Chris Withers ch...@simplistix.co.uk wrote: ... I'm not sure how much love repozo needs. It works, and it won't need changing until FileStorage's format changes, which I don't see happening any time soon. It just occurred to me that repozo

Re: [ZODB-Dev] repozo, neither official nor supported, apparently...

2009-11-20 Thread Chris Withers
Jeff Shell wrote: For what it's worth, I've dealt with broken / unloved / mildly-out-of-date ZODB scripts by making a new package that my little company uses internally. I don't agree with this because it's fragmenting a tiny development group even further, no to mention creating private

Re: [ZODB-Dev] repozo, neither official nor supported, apparently...

2009-11-20 Thread Laurence Rowe
2009/11/20 Jim Fulton j...@zope.com: On Fri, Nov 20, 2009 at 9:32 AM, Chris Withers ch...@simplistix.co.uk wrote: ... I'm not sure how much love repozo needs. It works, and it won't need changing until FileStorage's format changes, which I don't see happening any time soon. It just occurred

Re: [ZODB-Dev] 3.9.4 release?

2009-11-20 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jim Fulton wrote: On Fri, Nov 20, 2009 at 5:49 AM, Chris Withers ch...@simplistix.co.uk wrote: Hi Jim, It would be great if the two recent fixes I committed could make it into a 3.9.4 release some time soon... What can I do to help this happen?

Re: [ZODB-Dev] 3.9.4 release?

2009-11-20 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Tres Seaver wrote: Jim Fulton wrote: On Fri, Nov 20, 2009 at 5:49 AM, Chris Withers ch...@simplistix.co.uk wrote: Hi Jim, It would be great if the two recent fixes I committed could make it into a 3.9.4 release some time soon... What can I

Re: [ZODB-Dev] 3.9.4 release?

2009-11-20 Thread Jim Fulton
On Fri, Nov 20, 2009 at 11:49 AM, Tres Seaver tsea...@palladion.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Tres Seaver wrote: Jim Fulton wrote: On Fri, Nov 20, 2009 at 5:49 AM, Chris Withers ch...@simplistix.co.uk wrote: Hi Jim, It would be great if the two recent fixes I

Re: [ZODB-Dev] 3.9.4 release?

2009-11-20 Thread Chris Withers
Jim Fulton wrote: +class RepozoTests(unittest.TestCase): + +def test_importability(self): +from ZODB.scripts import repozo + I appreciate your dedication to quality. That test passes under ZODB 3.9.3 with Python 2.6. ...but it will emit a deprecation warning, which I

Re: [ZODB-Dev] Zope 2.12 and blobs

2009-11-20 Thread Chris Withers
Jim Fulton wrote: No, we should tell them they should use a mostly untested tool to do backups that doesn't work with blobs. That should inspire confidence. Does Zope 2.12 use Blobs? Not by default, no. Chris -- Simplistix - Content Management, Batch Processing Python Consulting

Re: [ZODB-Dev] 3.9.4 release?

2009-11-20 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jim Fulton wrote: On Fri, Nov 20, 2009 at 11:49 AM, Tres Seaver tsea...@palladion.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Tres Seaver wrote: Jim Fulton wrote: On Fri, Nov 20, 2009 at 5:49 AM, Chris Withers

Re: [ZODB-Dev] 3.9.4 release?

2009-11-20 Thread Jim Fulton
On Fri, Nov 20, 2009 at 1:36 PM, Tres Seaver tsea...@palladion.com wrote: ...  with Zope 2.12 and later now running on Python 2.6, we should just tell people Sorry, you can't do backups? No, we should tell them they should use a mostly untested tool to do backups that doesn't work with

Re: [ZODB-Dev] 3.9.4 release?

2009-11-20 Thread Jeff Shell
On Nov 20, 2009, at 11:52 AM, Jim Fulton wrote: If configured, sure. I would not trust repozo + blob backups. I don't trust Blobs. A year ago, I reverted all of the code I had for our CMS that supported Blobs as it was impossible to copy their data in a basic Zope 3 copy/past/move. I think

Re: [ZODB-Dev] 3.9.4 release?

2009-11-20 Thread Christian Theune
On 11/20/2009 08:07 PM, Jeff Shell wrote: On Nov 20, 2009, at 11:52 AM, Jim Fulton wrote: If configured, sure. I would not trust repozo + blob backups. I don't trust Blobs. A year ago, I reverted all of the code I had for our CMS that supported Blobs as it was impossible to copy their data

Re: [ZODB-Dev] blobs

2009-11-20 Thread Chris Withers
Jeff Shell wrote: On Nov 20, 2009, at 11:52 AM, Jim Fulton wrote: If configured, sure. I would not trust repozo + blob backups. I don't trust Blobs. A year ago, I reverted all of the code I had for our CMS that supported Blobs as it was impossible to copy their data in a basic Zope 3

[ZODB-Dev] errors logged at info in ZEO's connection

2009-11-20 Thread Chris Withers
Hi All (although I guess predominantly Jim), ZEO/zprc/connection.py contains this rather odd piece of code: raise except Exception, msg: if not isinstance(msg, self.unlogged_exception_types): self.log(%s() raised exception: %s % (name, msg),

Re: [ZODB-Dev] errors logged at info in ZEO's connection

2009-11-20 Thread Jim Fulton
On Fri, Nov 20, 2009 at 3:15 PM, Chris Withers ch...@simplistix.co.uk wrote: Hi All (although I guess predominantly Jim), ZEO/zprc/connection.py contains this rather odd piece of code:             raise         except Exception, msg:             if not isinstance(msg,

Re: [ZODB-Dev] errors logged at info in ZEO's connection

2009-11-20 Thread Chris Withers
Jim Fulton wrote: It seems a bit bizarre that exceptions are logged at INFO rather than ERROR... Agreed. A simple fix and test on a branch would be appreciated. Done: http://svn.zope.org/ZODB/branches/chrisw-error_logging/ It would be great if this, too, could make it in a 3.9.4