Re: [ZODB-Dev] Default comparison considered harmful in BTrees.

2010-10-27 Thread Hanno Schlichting
On Mon, Oct 25, 2010 at 11:51 PM, Jim Fulton j...@zope.com wrote: I'm inclined to treat the use of the comparison operator inherited from object in BTrees to be a bug.  I plan to fix this on the trunk. Did you mean to throw warnings for simple built-in types? I'm now getting warnings for

Re: [ZODB-Dev] Default comparison considered harmful in BTrees.

2010-10-27 Thread Jim Fulton
On Wed, Oct 27, 2010 at 9:17 AM, Hanno Schlichting ha...@hannosch.eu wrote: On Mon, Oct 25, 2010 at 11:51 PM, Jim Fulton j...@zope.com wrote: I'm inclined to treat the use of the comparison operator inherited from object in BTrees to be a bug.  I plan to fix this on the trunk. Did you mean

Re: [ZODB-Dev] Default comparison considered harmful in BTrees.

2010-10-27 Thread Hanno Schlichting
On Wed, Oct 27, 2010 at 6:45 PM, Jim Fulton j...@zope.com wrote: If not, I wonder if the existing indexes have some bad values in them that are triggering this somehow.  The relevant check is being done when loading state.  I bet you have some bad keys (e.g. None) in your data structures.

Re: [ZODB-Dev] Default comparison considered harmful in BTrees.

2010-10-27 Thread Jim Fulton
On Wed, Oct 27, 2010 at 1:59 PM, Hanno Schlichting ha...@hannosch.eu wrote: On Wed, Oct 27, 2010 at 6:45 PM, Jim Fulton j...@zope.com wrote: If not, I wonder if the existing indexes have some bad values in them that are triggering this somehow.  The relevant check is being done when loading

[ZODB-Dev] ZODB 3.10.1 released

2010-10-27 Thread Jim Fulton
I just released ZODB 3.10.1: http://pypi.python.org/pypi/ZODB3/3.10.1 It has some important bug fixes: http://pypi.python.org/pypi/ZODB3/3.10.1#bugs-fixed In particular: When a transaction rolled back a savepoint after adding objects and subsequently added more objects and committed,

Re: [ZODB-Dev] Default comparison considered harmful in BTrees.

2010-10-27 Thread Jim Fulton
On Mon, Oct 25, 2010 at 5:51 PM, Jim Fulton j...@zope.com wrote: I'm inclined to treat the use of the comparison operator inherited from object in BTrees to be a bug.  I plan to fix this on the trunk. I'm tempted to fix this in 10.1.  This change would make it impossible to add keys to