Re: [ZODB-Dev] An interface for broken objects?
On Sun, Jan 3, 2010 at 5:38 PM, Jim Fulton wrote: > I suggest including these in the interface. Thanks for fixing this yourself and merging. Sorry, I didn't get around to extend things myself. Hanno ___ For more information about ZODB, see the ZODB Wiki: http://www.zope.org/Wikis/ZODB/ ZODB-Dev mailing list - ZODB-Dev@zope.org https://mail.zope.org/mailman/listinfo/zodb-dev
Re: [ZODB-Dev] An interface for broken objects?
On Thu, Dec 31, 2009 at 3:02 PM, Hanno Schlichting wrote: > On Thu, Dec 31, 2009 at 6:03 PM, Jim Fulton wrote: >> On Thu, Dec 31, 2009 at 11:46 AM, Hanno Schlichting >> wrote: >>> Is this something that could be put into the ZODB itself and have the >>> ZODB.broken.Broken class directly implement this interface? >> >> +1. although it shouldn't be an empty interface. > > Ok. I've gone ahead and made a branch for this at: > > svn+ssh://svn.zope.org/repos/main/ZODB/branches/hannosch-ibroken > > It's a single changeset: http://svn.zope.org/ZODB/?rev=107467&view=rev Thanks. > I only specified the custom exception thrown by the __setattr__ in the > interface. Everything else is private double underscore methods. I > wasn't sure if any of those should really be specified formally. Leading *and* trailing double underscores imply "special", rather than private. I suggest including these in the interface. > Thanks for considering to merge this :) Thanks for taking the time to do this. Jim -- Jim Fulton ___ For more information about ZODB, see the ZODB Wiki: http://www.zope.org/Wikis/ZODB/ ZODB-Dev mailing list - ZODB-Dev@zope.org https://mail.zope.org/mailman/listinfo/zodb-dev
Re: [ZODB-Dev] An interface for broken objects?
On Thu, Dec 31, 2009 at 6:03 PM, Jim Fulton wrote: > On Thu, Dec 31, 2009 at 11:46 AM, Hanno Schlichting wrote: >> Is this something that could be put into the ZODB itself and have the >> ZODB.broken.Broken class directly implement this interface? > > +1. although it shouldn't be an empty interface. Ok. I've gone ahead and made a branch for this at: svn+ssh://svn.zope.org/repos/main/ZODB/branches/hannosch-ibroken It's a single changeset: http://svn.zope.org/ZODB/?rev=107467&view=rev I only specified the custom exception thrown by the __setattr__ in the interface. Everything else is private double underscore methods. I wasn't sure if any of those should really be specified formally. Thanks for considering to merge this :) Happy new year, Hanno ___ For more information about ZODB, see the ZODB Wiki: http://www.zope.org/Wikis/ZODB/ ZODB-Dev mailing list - ZODB-Dev@zope.org https://mail.zope.org/mailman/listinfo/zodb-dev
Re: [ZODB-Dev] An interface for broken objects?
On Thu, Dec 31, 2009 at 11:46 AM, Hanno Schlichting wrote: > Hi. > > We currently have a package called "zope.broken" whose entire real content is: > > import zope.interface > > class IBroken(zope.interface.Interface): > """Marker interface for broken objects > """ > > This is used for example by zope.container, which won't try to set > __name__ and __parent__ pointers on these objects. > > Is this something that could be put into the ZODB itself and have the > ZODB.broken.Broken class directly implement this interface? +1. although it shouldn't be an empty interface. Jim -- Jim Fulton ___ For more information about ZODB, see the ZODB Wiki: http://www.zope.org/Wikis/ZODB/ ZODB-Dev mailing list - ZODB-Dev@zope.org https://mail.zope.org/mailman/listinfo/zodb-dev
[ZODB-Dev] An interface for broken objects?
Hi. We currently have a package called "zope.broken" whose entire real content is: import zope.interface class IBroken(zope.interface.Interface): """Marker interface for broken objects """ This is used for example by zope.container, which won't try to set __name__ and __parent__ pointers on these objects. Is this something that could be put into the ZODB itself and have the ZODB.broken.Broken class directly implement this interface? Thanks, Hanno ___ For more information about ZODB, see the ZODB Wiki: http://www.zope.org/Wikis/ZODB/ ZODB-Dev mailing list - ZODB-Dev@zope.org https://mail.zope.org/mailman/listinfo/zodb-dev
