Re: [ZODB-Dev] Repozo tests -- not

2009-12-08 Thread Benji York
On Wed, Dec 2, 2009 at 5:34 PM, Godefroid Chapelle got...@bubblenet.be wrote: As far as I can understand, THE reason for repozo is to backup without stopping the ZODB. [I'm a little late to this conversation.] Filestorages can be backed up without stopping anything. Any incomplete writes that

Re: [ZODB-Dev] Repozo tests -- not

2009-12-08 Thread Jim Fulton
On Tue, Dec 8, 2009 at 1:49 PM, Benji York be...@zope.com wrote: On Wed, Dec 2, 2009 at 5:34 PM, Godefroid Chapelle got...@bubblenet.be wrote: As far as I can understand, THE reason for repozo is to backup without stopping the ZODB. [I'm a little late to this conversation.] Filestorages

Re: [ZODB-Dev] Repozo tests -- not

2009-12-08 Thread Daniel Kraft
Jim Fulton wrote: On Tue, Dec 8, 2009 at 1:49 PM, Benji York be...@zope.com wrote: Any incomplete writes that are in progress at the time of the copy will simply be ignored when the resulting backup is opened later. Note that this assumes that you are using a straightforward linear copy.

Re: [ZODB-Dev] Repozo tests -- not

2009-12-08 Thread Shane Hathaway
Daniel Kraft wrote: Jim Fulton wrote: On Tue, Dec 8, 2009 at 1:49 PM, Benji York be...@zope.com wrote: Any incomplete writes that are in progress at the time of the copy will simply be ignored when the resulting backup is opened later. Note that this assumes that you are using a

Re: [ZODB-Dev] Repozo tests -- not

2009-12-08 Thread Christian Theune
On 12/09/2009 12:06 AM, Shane Hathaway wrote: Daniel Kraft wrote: Jim Fulton wrote: On Tue, Dec 8, 2009 at 1:49 PM, Benji Yorkbe...@zope.com wrote: Any incomplete writes that are in progress at the time of the copy will simply be ignored when the resulting backup is opened later. Note that

Re: [ZODB-Dev] Repozo tests -- not

2009-12-08 Thread Shane Hathaway
Christian Theune wrote: Not exactly: it's still a good idea to store away deltas as single large files are still hard to deal with except if you have really good block-level de-duplication in your filesystem. (Uhmm. I guess ZFS probably has all of that. It also probably serves my dinner.)

Re: [ZODB-Dev] Repozo tests -- not

2009-12-08 Thread Christian Theune
On 12/09/2009 02:25 AM, Shane Hathaway wrote: Christian Theune wrote: Not exactly: it's still a good idea to store away deltas as single large files are still hard to deal with except if you have really good block-level de-duplication in your filesystem. (Uhmm. I guess ZFS probably has all of

Re: [ZODB-Dev] Repozo tests -- not

2009-12-02 Thread Jim Fulton
On Tue, Dec 1, 2009 at 8:44 PM, Martin Aspeli optilude+li...@gmail.com wrote: Jim Fulton wrote: On Fri, Nov 20, 2009 at 1:52 PM, Jim Fulton j...@zope.com wrote: On Fri, Nov 20, 2009 at 1:36 PM, Tres Seaver tsea...@palladion.com wrote: ... More importantly, Chris' change touches non-trivial

Re: [ZODB-Dev] Repozo tests -- not

2009-12-02 Thread Jim Fulton
On Tue, Dec 1, 2009 at 6:24 PM, Chris Withers ch...@simplistix.co.uk wrote: Jim Fulton wrote: Well, not really fair enough.  I just looked at the change that Chris made.  It has a bug that would be caught by your test if anyone tried to port repozo to Python 3. Which alternate reality are

Re: [ZODB-Dev] Repozo tests -- not

2009-12-02 Thread Godefroid Chapelle
Jim Fulton wrote: snip No one seems to be willing to step up and take responsibility. I guess everyone assumes I will. Jim I'll take the responsibility of transforming the manual test to an automated... -- Godefroid Chapelle (aka __gotcha) http://bubblenet.be

Re: [ZODB-Dev] Repozo tests -- not

2009-12-02 Thread Martin Aspeli
Jim Fulton wrote: No one seems to be willing to step up and take responsibility. I guess everyone assumes I will. I know a thing or two about trying to entice people to help maintain open source software. It's certainly not easy. But from a casual observer's perspective, this whole exchange

Re: [ZODB-Dev] Repozo tests -- not

2009-12-02 Thread Jim Fulton
On Wed, Dec 2, 2009 at 7:12 AM, Godefroid Chapelle got...@bubblenet.be wrote: Jim Fulton wrote: snip No one seems to be willing to step up and take responsibility. I guess everyone assumes I will. Jim I'll take the responsibility of transforming the manual test to an automated...

Re: [ZODB-Dev] Repozo tests -- not

2009-12-02 Thread Jim Fulton
On Wed, Dec 2, 2009 at 7:19 AM, Martin Aspeli optilude+li...@gmail.com wrote: Jim Fulton wrote: In any case, nothing is deleted in subversion. If someone creates even minimal tests that exercise the code you changed, then I'll be happy to reapply the change. At some point, if no one takes

Re: [ZODB-Dev] Repozo tests -- not

2009-12-02 Thread Chris Withers
Jim Fulton wrote: BTW, offline back ups if file-storage even with Blobs is straightforward without repozo. I couldn't parse this, could you restate particularly wrt to what ou mean by offline? If there's a way other than repozo, then it would be great to know what it was... Chris --

Re: [ZODB-Dev] Repozo tests -- not

2009-12-02 Thread Jim Fulton
On Wed, Dec 2, 2009 at 8:01 AM, Chris Withers ch...@simplistix.co.uk wrote: Jim Fulton wrote: BTW, offline back ups if file-storage even with Blobs is straightforward without repozo. I couldn't parse this, could you restate particularly wrt to what ou mean by offline? If there's a way other

Re: [ZODB-Dev] Repozo tests -- not

2009-12-02 Thread Chris Withers
Jeff Shell wrote: I'm not sure whose expectations you're satisfying as the items in ZODB.scripts are a wild and inconsistent mess. It's been trial and error just to find ones that seem to work, outside of repozo. Oh the irony of the one script that Jim is looking to remove, because someone

Re: [ZODB-Dev] Repozo tests -- not

2009-12-02 Thread Godefroid Chapelle
Godefroid Chapelle wrote: Jim Fulton wrote: snip No one seems to be willing to step up and take responsibility. I guess everyone assumes I will. Jim I'll take the responsibility of transforming the manual test to an automated... Done in

Re: [ZODB-Dev] Repozo tests -- not

2009-12-02 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Godefroid Chapelle wrote: Godefroid Chapelle wrote: Jim Fulton wrote: snip No one seems to be willing to step up and take responsibility. I guess everyone assumes I will. Jim I'll take the responsibility of transforming the manual test to

Re: [ZODB-Dev] Repozo tests -- not

2009-12-02 Thread Godefroid Chapelle
Tres Seaver wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Godefroid Chapelle wrote: Godefroid Chapelle wrote: Jim Fulton wrote: snip No one seems to be willing to step up and take responsibility. I guess everyone assumes I will. Jim I'll take the responsibility of

Re: [ZODB-Dev] Repozo tests -- not

2009-12-02 Thread Jim Fulton
On Wed, Dec 2, 2009 at 6:30 AM, Jim Fulton j...@zope.com wrote: On Tue, Dec 1, 2009 at 6:24 PM, Chris Withers ch...@simplistix.co.uk wrote: Jim Fulton wrote: ... I don't want people to contribute crap. You've made some reasonable contributions recently so I know you are capable of producing

Re: [ZODB-Dev] Repozo tests -- not

2009-12-02 Thread Jim Fulton
On Wed, Dec 2, 2009 at 12:42 PM, Godefroid Chapelle got...@bubblenet.be wrote: Godefroid Chapelle wrote: Jim Fulton wrote: snip No one seems to be willing to step up and take responsibility. I guess everyone assumes I will. Jim I'll take the responsibility of transforming the manual

Re: [ZODB-Dev] Repozo tests -- not

2009-12-02 Thread Jim Fulton
On Wed, Dec 2, 2009 at 10:09 AM, Jeff Shell j...@bottlerocket.net wrote: On Dec 2, 2009, at 5:39 AM, Jim Fulton wrote: On Wed, Dec 2, 2009 at 7:19 AM, Martin Aspeli optilude+li...@gmail.com wrote: Jim Fulton wrote: ... BTW, offline back ups if file-storage even with Blobs is

Re: [ZODB-Dev] Repozo tests -- not

2009-12-02 Thread Godefroid Chapelle
Tres Seaver wrote: - - Avoid shellling out to run repozo, but rather use its main(), passing argv. I thought of this but decided to not go that way to test that repozo can actually run on a living database. Even if the code that was there still needs to be modified to achieve that goal.

Re: [ZODB-Dev] Repozo tests -- not

2009-12-02 Thread Jim Fulton
On Wed, Dec 2, 2009 at 5:34 PM, Godefroid Chapelle got...@bubblenet.be wrote: Tres Seaver wrote: - - Avoid shellling out to run repozo, but rather use its main(),   passing argv. I thought of this but decided to not go that way to test that repozo can actually run on a living database. Even

[ZODB-Dev] Repozo tests -- not

2009-12-01 Thread Jim Fulton
On Fri, Nov 20, 2009 at 1:52 PM, Jim Fulton j...@zope.com wrote: On Fri, Nov 20, 2009 at 1:36 PM, Tres Seaver tsea...@palladion.com wrote: ... I just checked in a stupid test to ensure that repozo can be imported. - --- src/ZODB/scripts/tests.py (revision 105913) +++ src/ZODB/scripts/tests.py

Re: [ZODB-Dev] Repozo tests -- not

2009-12-01 Thread Martin Aspeli
Jim Fulton wrote: On Fri, Nov 20, 2009 at 1:52 PM, Jim Fulton j...@zope.com wrote: On Fri, Nov 20, 2009 at 1:36 PM, Tres Seaver tsea...@palladion.com wrote: ... I just checked in a stupid test to ensure that repozo can be imported. - --- src/ZODB/scripts/tests.py (revision 105913) +++

Re: [ZODB-Dev] Repozo tests -- not

2009-12-01 Thread Chris Withers
Martin Aspeli wrote: - there were no tests for the existing code There are tests, they're just manual and spew a lot of output even when passing, but they do (as best I could tell) exercise the backup and restore cycle quite heavily. I ran these before and after to verify they didn't fail