Re: [ZODB-Dev] RFC: Remove KeyError as base class of POSKeyError

2011-12-15 Thread Paul Winkler 
Yes thank you!!


Paul Winkler
--
Typed on my phone. Apologies for typos, brevity, and/or bizarre word
substitutions.

On Dec 15, 2011, at 11:52 AM, Jim Fulton  wrote:

> POSKeyError subclasses KeyError.  While this makes sense conceptually,
> it's really unfortunate in practice.  Application code that catches
> key errors when getting an item from a container, will unintentionally
> hide POSKeyErrors.
>
> I propose to remove KeyError as a base class of POSKeyError.  While
> this is a backward incompatible change, I can't imagine unbroken code
> that intentionally catches POSKeyErrors via KeErrors.
>
> If there are no objections, I'll make this change in 3.11.
>
> JIm
>
> --
> Jim Fulton
> http://www.linkedin.com/in/jimfulton
> ___
> For more information about ZODB, see http://zodb.org/
>
> ZODB-Dev mailing list  -  ZODB-Dev@zope.org
> https://mail.zope.org/mailman/listinfo/zodb-dev
___
For more information about ZODB, see http://zodb.org/

ZODB-Dev mailing list  -  ZODB-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zodb-dev

Re: [ZODB-Dev] RFC: Remove KeyError as base class of POSKeyError

2011-12-15 Thread Maurits van Rees 

Op 15-12-11 17:51, Jim Fulton schreef:

POSKeyError subclasses KeyError.  While this makes sense conceptually,
it's really unfortunate in practice.  Application code that catches
key errors when getting an item from a container, will unintentionally
hide POSKeyErrors.

I propose to remove KeyError as a base class of POSKeyError.  While
this is a backward incompatible change, I can't imagine unbroken code
that intentionally catches POSKeyErrors via KeErrors.

If there are no objections, I'll make this change in 3.11.


+1

Subclassing KeyError indeed sounds conceptually logical, but I can 
imagine soms nasty side effects.



--
Maurits van Rees   http://maurits.vanrees.org/
Web App Programmer at Zest Software: http://zestsoftware.nl
"Logical thinking shows conclusively that logical thinking
is inconclusive." - My summary of Gödel, Escher, Bach

___
For more information about ZODB, see http://zodb.org/

ZODB-Dev mailing list  -  ZODB-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zodb-dev