Re: [ZODB-Dev] Relstorage zodbconvert's --incremental

2014-12-18 Thread Mauro Amico
There is also another PR for same, could you try or compare with your 
implementation?


https://github.com/zodb/relstorage/pull/19

Mauro.

On 12/18/2014 11:24 AM, Sylvain Viollon wrote:

Hello,

  I found out that this option did not work at all and seemed to be half 
implemented.

  I believe I fixed it: 
https://github.com/minddistrict/relstorage/compare/zodb:master...master

  If you have any comment or thing I could have missed.

  I am testing it right now on a sizable database, interrupting the process 
and starting over
after and so on. I will do a pull request if everything goes ok.

  Sylvain,

—
Sylvain Viollon
Minddistrict Development
http://minddistrict.com

___
For more information about ZODB, see http://zodb.org/

ZODB-Dev mailing list  -  ZODB-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zodb-dev


___
For more information about ZODB, see http://zodb.org/

ZODB-Dev mailing list  -  ZODB-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zodb-dev


Re: [ZODB-Dev] Relstorage zodbconvert's --incremental

2014-12-18 Thread Sylvain Viollon

 Op 18 dec. 2014, om 11:40 heeft Mauro Amico mauro.am...@gmail.com het 
 volgende geschreven:
 
 There is also another PR for same, could you try or compare with your 
 implementation?
 
 https://github.com/zodb/relstorage/pull/19
 

   Yes, except you cannot change the signature of copyTransactionsFrom, since 
if you convert
from relstorage to a regular storage, the ZODB implementation is called instead 
of the one in
relstorage. I made this proxy object in order to have it work with all backends.

Sylvain,

— 
Sylvain Viollon
Minddistrict Development
http://minddistrict.com

___
For more information about ZODB, see http://zodb.org/

ZODB-Dev mailing list  -  ZODB-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zodb-dev