Re: [ZODB-Dev] SVN: ZODB/trunk/ Note split of persistent.
Hello, Now we have some problems making the binary eggs. See the attached txt for the full output. On 08/26/2012 09:07 PM, Tres Seaver wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/26/2012 07:05 AM, Hanno Schlichting wrote: On Sat, Aug 25, 2012 at 4:11 PM, Tres Seaver tsea...@palladion.com wrote: This failure, and the others like it, indicate that the buildout has failed to install persistent correctly (there is nothing Windows-specific about the failure):: I actually got the same error locally. The trouble is the timestamp.py module and the TimeStamp.c extension. During installation setuptools creates a wrapper for the extension file. So you end up with TimeStamp.so but also a timestamp.py wrapper. This wrapper overwrites the original timestamp.py module. You likely have a case-sensitive file system and therefor didn't get this problem. Whoever came up with the idea of a case-insensitive filesystem should be shot (or at least, whoever decided to keep doing that after moving off of DOS). I have worked around this problem (I think) by renaming the extension module to '_timestamp.so'. I released a 4.0.1 to PyPI with this fix, along with a fix for the int - long overflow on 32-bit systems. I think TimeStamp.c has been there before and is imported in other modules as from persistent.TimeStamp import TimeStamp. So we should keep that API and use a different name for the new timestamp.py module. I don't see the need for the BBB-preservation here: I documented the backward-incompatibility in CHANGES.txt instead. Tres. - -- === Tres Seaver +1 540-429-0999 tsea...@palladion.com Palladion Software Excellence by Designhttp://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAlA6c9IACgkQ+gerLs4ltQ6ocACeIqlGWazwos+yWGaMvgMCOkQD ZQoAn3oR2rY70a1oT6aTjLpofIVtVBNd =GzPs -END PGP SIGNATURE- ___ For more information about ZODB, see http://zodb.org/ ZODB-Dev mailing list - ZODB-Dev@zope.org https://mail.zope.org/mailman/listinfo/zodb-dev -- Best regards, Adam GROSZER -- Quote of the day: Never let a man imagine that he can pursue a good end by evil means, without sinning against his own soul. The evil effect on himself is certain. - Robert Southey running build_ext building 'persistent.cPersistence' extension creating build creating build\temp.win32-2.6 creating build\temp.win32-2.6\Release creating build\temp.win32-2.6\Release\persistent C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\BIN\cl.exe /c /nologo /Ox /MD /W3 /GS- /DNDEBUG -Ic:\Python26_32\include -Ic:\Python26_32\PC /Tcpersistent/cPersistence.c /Fobuild\temp.win32-2.6\Release\persistent/cPersistence.obj cPersistence.c persistent/cPersistence.c(1124) : warning C4047: '' : '__int64' differs in levels of indirection from 'PyObject *' C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\BIN\cl.exe /c /nologo /Ox /MD /W3 /GS- /DNDEBUG -Ic:\Python26_32\include -Ic:\Python26_32\PC /Tcpersistent/ring.c /Fobuild\temp.win32-2.6\Release\persistent/ring.obj ring.c creating build\lib.win32-2.6 creating build\lib.win32-2.6\persistent C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\BIN\link.exe /DLL /nologo /INCREMENTAL:NO /LIBPATH:c:\Python26_32\libs /LIBPATH:c:\Python26_32\PCbuild /EXPORT:initcPersistence build\temp.win32-2.6\Release\persistent/cPersistence.obj build\temp.win32-2.6\Release\persistent/ring.obj /OUT:build\lib.win32-2.6\persistent\cPersistence.pyd /IMPLIB:build\temp.win32-2.6\Release\persistent\cPersistence.lib /MANIFESTFILE:build\temp.win32-2.6\Release\persistent\cPersistence.pyd.manifest Creating library build\temp.win32-2.6\Release\persistent\cPersistence.lib and object build\temp.win32-2.6\Release\persistent\cPersistence.exp C:\Program Files\Microsoft SDKs\Windows\v6.1\bin\mt.exe -nologo -manifest build\temp.win32-2.6\Release\persistent\cPersistence.pyd.manifest -outputresource:build\lib.win32-2.6\persistent\cPersistence.pyd;2 building 'persistent.cPickleCache' extension C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\BIN\cl.exe /c /nologo /Ox /MD /W3 /GS- /DNDEBUG -Ic:\Python26_32\include -Ic:\Python26_32\PC /Tcpersistent/cPickleCache.c /Fobuild\temp.win32-2.6\Release\persistent/cPickleCache.obj cPickleCache.c C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\BIN\cl.exe /c /nologo /Ox /MD /W3 /GS- /DNDEBUG -Ic:\Python26_32\include -Ic:\Python26_32\PC /Tcpersistent/ring.c /Fobuild\temp.win32-2.6\Release\persistent/ring.obj ring.c C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\BIN\link.exe /DLL /nologo /INCREMENTAL:NO /LIBPATH:c:\Python26_32\libs /LIBPATH:c:\Python26_32\PCbuild /EXPORT:initcPickleCache build\temp.win32-2.6\Release\persistent/cPickleCache.obj build\temp.win32-2.6\Release\persistent/ring.obj
Re: [ZODB-Dev] SVN: ZODB/trunk/ Note split of persistent.
On Mon, Aug 27, 2012 at 8:57 AM, Adam GROSZER agroszer...@gmail.com wrote: Now we have some problems making the binary eggs. See the attached txt for the full output. I think I fixed that on SVN trunk. Looks like on Windows the compiler complains about mismatches between module names and the init functions inside the extension. On Mac OS I only got runtime errors: python -c from persistent import _timestamp Traceback (most recent call last): File string, line 1, in module ImportError: dynamic module does not define init function (init_timestamp) But I do get a test failure in the new maxint test under Python 2.7 on a 64bit Python (sys.maxint == 2**63-1): bin/test -t test_assign_p_estimated_size_bigger_than_sys_maxint Running zope.testrunner.layer.UnitTests tests: Set up zope.testrunner.layer.UnitTests in 0.000 seconds. Traceback (most recent call last): File bin/test-ztk-persistent, line 24, in module '--test-path', '/opt/zope/ztk/trunk/src/persistent', File /opt/eggs/zope.testrunner-4.0.4-py2.7.egg/zope/testrunner/__init__.py, line 30, in run failed = run_internal(defaults, args, script_parts=script_parts) File /opt/eggs/zope.testrunner-4.0.4-py2.7.egg/zope/testrunner/__init__.py, line 43, in run_internal runner.run() File /opt/eggs/zope.testrunner-4.0.4-py2.7.egg/zope/testrunner/runner.py, line 148, in run self.run_tests() File /opt/eggs/zope.testrunner-4.0.4-py2.7.egg/zope/testrunner/runner.py, line 229, in run_tests setup_layers, self.failures, self.errors) File /opt/eggs/zope.testrunner-4.0.4-py2.7.egg/zope/testrunner/runner.py, line 390, in run_layer return run_tests(options, tests, layer_name, failures, errors) File /opt/eggs/zope.testrunner-4.0.4-py2.7.egg/zope/testrunner/runner.py, line 306, in run_tests result.addSuccess(test) File /opt/eggs/zope.testrunner-4.0.4-py2.7.egg/zope/testrunner/runner.py, line 738, in addSuccess t = max(time.time() - self._start_time, 0.0) OverflowError: long too big to convert The error is obviously raised in the wrong place. Not sure what C code causes this. Hanno ___ For more information about ZODB, see http://zodb.org/ ZODB-Dev mailing list - ZODB-Dev@zope.org https://mail.zope.org/mailman/listinfo/zodb-dev
Re: [ZODB-Dev] SVN: ZODB/trunk/ Note split of persistent.
On Mon, Aug 27, 2012 at 3:18 PM, Tres Seaver tsea...@palladion.com wrote: I think that was the attempt to convert a too-big number to a C 'long long'. I have adjusted the test to use 2**63 - 1 directly. Yep, tests pass here now. I will make a 4.0.2 release after to buildbots report success on Windows (assuming they do). The winbot only builds actual tagged releases. You can follow its progress at http://winbot.zope.org/builders/wineggbuilder - there's a run every 30 minutes. I'm confident enough in the fix, so I'd just cut a new release. Hanno ___ For more information about ZODB, see http://zodb.org/ ZODB-Dev mailing list - ZODB-Dev@zope.org https://mail.zope.org/mailman/listinfo/zodb-dev
Re: [ZODB-Dev] SVN: ZODB/trunk/ Note split of persistent.
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/27/2012 09:55 AM, Hanno Schlichting wrote: On Mon, Aug 27, 2012 at 3:18 PM, Tres Seaver tsea...@palladion.com wrote: I think that was the attempt to convert a too-big number to a C 'long long'. I have adjusted the test to use 2**63 - 1 directly. Yep, tests pass here now. I will make a 4.0.2 release after to buildbots report success on Windows (assuming they do). The winbot only builds actual tagged releases. You can follow its progress at http://winbot.zope.org/builders/wineggbuilder - there's a run every 30 minutes. I'm confident enough in the fix, so I'd just cut a new release. OK, I'll make the release then. Tres. - -- === Tres Seaver +1 540-429-0999 tsea...@palladion.com Palladion Software Excellence by Designhttp://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAlA7h+kACgkQ+gerLs4ltQ7ALwCfY7nVKv1ZzXvYM3iduSwzCa37 iaQAn3xfaOnQfc+ZLkoT6lmQtPUPeMMM =eZGj -END PGP SIGNATURE- ___ For more information about ZODB, see http://zodb.org/ ZODB-Dev mailing list - ZODB-Dev@zope.org https://mail.zope.org/mailman/listinfo/zodb-dev
Re: [ZODB-Dev] SVN: ZODB/trunk/ Note split of persistent.
On Sat, Aug 25, 2012 at 4:11 PM, Tres Seaver tsea...@palladion.com wrote: This failure, and the others like it, indicate that the buildout has failed to install persistent correctly (there is nothing Windows-specific about the failure):: I actually got the same error locally. The trouble is the timestamp.py module and the TimeStamp.c extension. During installation setuptools creates a wrapper for the extension file. So you end up with TimeStamp.so but also a timestamp.py wrapper. This wrapper overwrites the original timestamp.py module. You likely have a case-sensitive file system and therefor didn't get this problem. I think TimeStamp.c has been there before and is imported in other modules as from persistent.TimeStamp import TimeStamp. So we should keep that API and use a different name for the new timestamp.py module. Hanno ___ For more information about ZODB, see http://zodb.org/ ZODB-Dev mailing list - ZODB-Dev@zope.org https://mail.zope.org/mailman/listinfo/zodb-dev
Re: [ZODB-Dev] SVN: ZODB/trunk/ Note split of persistent.
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/26/2012 07:05 AM, Hanno Schlichting wrote: On Sat, Aug 25, 2012 at 4:11 PM, Tres Seaver tsea...@palladion.com wrote: This failure, and the others like it, indicate that the buildout has failed to install persistent correctly (there is nothing Windows-specific about the failure):: I actually got the same error locally. The trouble is the timestamp.py module and the TimeStamp.c extension. During installation setuptools creates a wrapper for the extension file. So you end up with TimeStamp.so but also a timestamp.py wrapper. This wrapper overwrites the original timestamp.py module. You likely have a case-sensitive file system and therefor didn't get this problem. Whoever came up with the idea of a case-insensitive filesystem should be shot (or at least, whoever decided to keep doing that after moving off of DOS). I have worked around this problem (I think) by renaming the extension module to '_timestamp.so'. I released a 4.0.1 to PyPI with this fix, along with a fix for the int - long overflow on 32-bit systems. I think TimeStamp.c has been there before and is imported in other modules as from persistent.TimeStamp import TimeStamp. So we should keep that API and use a different name for the new timestamp.py module. I don't see the need for the BBB-preservation here: I documented the backward-incompatibility in CHANGES.txt instead. Tres. - -- === Tres Seaver +1 540-429-0999 tsea...@palladion.com Palladion Software Excellence by Designhttp://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAlA6c9IACgkQ+gerLs4ltQ6ocACeIqlGWazwos+yWGaMvgMCOkQD ZQoAn3oR2rY70a1oT6aTjLpofIVtVBNd =GzPs -END PGP SIGNATURE- ___ For more information about ZODB, see http://zodb.org/ ZODB-Dev mailing list - ZODB-Dev@zope.org https://mail.zope.org/mailman/listinfo/zodb-dev
Re: [ZODB-Dev] SVN: ZODB/trunk/ Note split of persistent.
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/25/2012 04:33 AM, Adam GROSZER wrote: Hello, I'm sorry to say, but the build (for r127209) before your merge was passing. See http://localhost:8009/builders/ZODB_dev%20py_265_win32/builds/750 This failure, and the others like it, indicate that the buildout has failed to install persistent correctly (there is nothing Windows-specific about the failure):: - - % --- Error in test test___delattr___p__names (persistent.tests.test_persistence.PyPersistentTests) Traceback (most recent call last): File c:\Python26_32\lib\unittest.py, line 279, in run testMethod() File c:\eggs\persistent-4.0.0-py2.6-win32.egg\persistent\tests\test_persistence.py, line 643, in test___delattr___p__names inst, jar, OID = self._makeOneWithJar() File c:\eggs\persistent-4.0.0-py2.6-win32.egg\persistent\tests\test_persistence.py, line 58, in _makeOneWithJar from persistent.timestamp import _makeOctets ImportError: cannot import name _makeOctets - - % --- The only solution I can think of is to delete those buildouts and start fresh. And there are more problems: http://winbot.zope.org/builders/persistent_py_265_32/builds/2/steps/test/logs/stdio all probably windows related. I don't have a clue how to diagnose this one. $ python 2.6 Python 2.6.8 (unknown, May 27 2012, 16:15:53) [GCC 4.6.3] on linux3 ... type(1073741697 * 1024) type 'int' What does that yield on the Windows box? Tres. - -- === Tres Seaver +1 540-429-0999 tsea...@palladion.com Palladion Software Excellence by Designhttp://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAlA43PUACgkQ+gerLs4ltQ4UrQCgzUc2GiwTd+FLu+UEJvCTeJSC mO4AoKy6rZvWHIVR5l9Cu6cpbLE5ajaP =Kgjg -END PGP SIGNATURE- ___ For more information about ZODB, see http://zodb.org/ ZODB-Dev mailing list - ZODB-Dev@zope.org https://mail.zope.org/mailman/listinfo/zodb-dev
Re: [ZODB-Dev] SVN: ZODB/trunk/ Note split of persistent.
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/24/2012 10:05 AM, Tres Seaver wrote: On 08/24/2012 02:42 AM, Adam GROSZER wrote: Hello, I think this broke ZODB tests. http://winbot.zope.org/builders/ZODB_dev%20py_265_win64/builds/757/steps/test/logs/stdio On 08/21/2012 07:08 PM, Tres Seaver wrote: Log message for revision 127545: Note split of persistent. Changed: _U ZODB/trunk/ U ZODB/trunk/src/CHANGES.txt -=- Modified: ZODB/trunk/src/CHANGES.txt === --- ZODB/trunk/src/CHANGES.txt 2012-08-21 17:07:01 UTC (rev 127544) +++ ZODB/trunk/src/CHANGES.txt 2012-08-21 17:08:42 UTC (rev 127545) @@ -8,6 +8,9 @@ New Features +- The ``persistent`` package is now released as a separate distribution, + on which ZODB now depends. + - ZODB no longer depends on zope.event. It now uses ZODB.event, which uses zope.event if it is installed. You can override ZODB.event.notify to provide your own event handling, although Hmmm, those symbols are there: $ /opt/Python-2.6.8/bin/virtualenv /tmp/per4 ... $ /tmp/per4/bin/easy_install persistent ... $ /tmp/per4/bin/python -c from persistent.timestamp import _makeOctets I will try a fresh ZODB checkout and see if I can reproduce. I don't see any of those failures. I see only one failure in src/ZEO/tests/testZEO.py (ZEO.tests.testZEO.client_has_newer_data_than_server). It looks like a spurious doctest failure to me (the expected error is actually raised, but the rendered output doesn't match). Tres. - -- === Tres Seaver +1 540-429-0999 tsea...@palladion.com Palladion Software Excellence by Designhttp://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAlA3jsIACgkQ+gerLs4ltQ6vtACglapHfxTy0FV/V8fpTKkNcGpZ 0HYAnR9lKiNkc2yG1XjuJU9+DECvvtlz =V8FU -END PGP SIGNATURE- ___ For more information about ZODB, see http://zodb.org/ ZODB-Dev mailing list - ZODB-Dev@zope.org https://mail.zope.org/mailman/listinfo/zodb-dev
