Re: [ZODB-Dev] breaking out the transaction module from ZODB

2007-11-09 Thread Jim Fulton
On Nov 8, 2007, at 7:46 PM, Chris McDonough wrote: How about zope.transaction? Guido recently told me that people in the Python community at large assume that anything in the Zope namespace is assumed to be Zope specific, so I'd rather not put it there. Does it matter? People who are

Re: [ZODB-Dev] breaking out the transaction module from ZODB

2007-11-09 Thread Chris McDonough
On Nov 9, 2007, at 7:52 AM, Jim Fulton wrote: On Nov 8, 2007, at 7:46 PM, Chris McDonough wrote: How about zope.transaction? Guido recently told me that people in the Python community at large assume that anything in the Zope namespace is assumed to be Zope specific, so I'd rather not

Re: [ZODB-Dev] breaking out the transaction module from ZODB

2007-11-09 Thread Jim Fulton
On Nov 9, 2007, at 8:31 AM, Chris McDonough wrote: It also contains TimeStamp, which will get moved out of persistent. Why? I don't see any uses of TimeStamp by the transaction package. In your new package, it is only used by its tests. The tests work (reqt's are downloaded) if you do

Re: [ZODB-Dev] breaking out the transaction module from ZODB

2007-11-09 Thread Chris McDonough
On Nov 9, 2007, at 8:41 AM, Jim Fulton wrote: On Nov 9, 2007, at 8:31 AM, Chris McDonough wrote: It also contains TimeStamp, which will get moved out of persistent. Why? I don't see any uses of TimeStamp by the transaction package. In your new package, it is only used by its tests.

Re: [ZODB-Dev] breaking out the transaction module from ZODB

2007-11-09 Thread Jim Fulton
On Nov 9, 2007, at 9:29 AM, Chris McDonough wrote: On Nov 9, 2007, at 8:41 AM, Jim Fulton wrote: On Nov 9, 2007, at 8:31 AM, Chris McDonough wrote: It also contains TimeStamp, which will get moved out of persistent. Why? I don't see any uses of TimeStamp by the transaction package. In

Re: [ZODB-Dev] breaking out the transaction module from ZODB

2007-11-09 Thread Jim Fulton
On Nov 9, 2007, at 9:29 AM, Chris McDonough wrote: On Nov 9, 2007, at 8:41 AM, Jim Fulton wrote: On Nov 9, 2007, at 8:31 AM, Chris McDonough wrote: It also contains TimeStamp, which will get moved out of persistent. Why? I don't see any uses of TimeStamp by the transaction package. In

Re: [ZODB-Dev] breaking out the transaction module from ZODB

2007-11-09 Thread Chris McDonough
On Nov 9, 2007, at 9:43 AM, Jim Fulton wrote: Yawn. IMO, the test command in setuptools is a waste of time, because it doesn't work with anything else. It runs all the tests, even the doctests, if thats what you mean. See the additional_tests hair in the test modules. My point is

Re: [ZODB-Dev] breaking out the transaction module from ZODB

2007-11-09 Thread Jim Fulton
On Nov 9, 2007, at 11:37 AM, Chris McDonough wrote: On Nov 9, 2007, at 9:43 AM, Jim Fulton wrote: Yawn. IMO, the test command in setuptools is a waste of time, because it doesn't work with anything else. It runs all the tests, even the doctests, if thats what you mean. See the

Re: [ZODB-Dev] breaking out the transaction module from ZODB

2007-11-09 Thread Chris McDonough
In the meantime, I've gotten rid of 'zope.transaction' and I've created a new top-level 'transaction' package at http://svn.zope.org/transaction/ . All its tests pass. It depends only on 'zope.interface', and requires 'zope.testing' for running the tests. Yay! I think you are pretty

Re: [ZODB-Dev] breaking out the transaction module from ZODB

2007-11-09 Thread Jim Fulton
On Nov 9, 2007, at 12:10 PM, Chris McDonough wrote: In the meantime, I've gotten rid of 'zope.transaction' and I've created a new top-level 'transaction' package at http:// svn.zope.org/transaction/ . All its tests pass. It depends only on 'zope.interface', and requires 'zope.testing'

Re: [ZODB-Dev] breaking out the transaction module from ZODB

2007-11-09 Thread Chris McDonough
On Nov 9, 2007, at 12:10 PM, Chris McDonough wrote: BTW, it would be nice to now remove the transaction package from the ZODB trunk and make it a dependency. Yes. ZODB's setup.py is polyglotic... it works if setuptools isn't installed. I suspect it shouldn't continue to given that it now

Re: [ZODB-Dev] breaking out the transaction module from ZODB

2007-11-08 Thread Jim Fulton
On Nov 7, 2007, at 11:38 PM, Chris McDonough wrote: I've begun work on breaking out the transaction module so it can be used independently from ZODB. Great! Here's what I've done so far: - I've moved TransactionError and TransactionFailedError from ZODB.POSException into

Re: [ZODB-Dev] breaking out the transaction module from ZODB

2007-11-08 Thread Chris McDonough
On Nov 8, 2007, at 9:14 AM, Jim Fulton wrote: class TransactionFailedError(Exception): Cannot perform an operation on a transaction that previously failed. An attempt was made to commit a transaction, or to join a transaction, but this transaction previously raised an

Re: [ZODB-Dev] breaking out the transaction module from ZODB

2007-11-08 Thread Jim Fulton
On Nov 8, 2007, at 1:59 PM, Chris McDonough wrote: On Nov 8, 2007, at 9:14 AM, Jim Fulton wrote: class TransactionFailedError(Exception): Cannot perform an operation on a transaction that previously failed. An attempt was made to commit a transaction, or to join a

Re: [ZODB-Dev] breaking out the transaction module from ZODB

2007-11-08 Thread Chris McDonough
On Nov 8, 2007, at 6:25 PM, Jim Fulton wrote: Why not subclass TransactionError? It didn't before. Should it? Seems logical, but I'm not looking that closely. :) OK. How about zope.transaction? Guido recently told me that people in the Python community at large assume that anything