Re: [ZODB-Dev] errors logged at info in ZEO's connection
Merged. Jim On Fri, Nov 20, 2009 at 5:45 PM, Chris Withers wrote: > Jim Fulton wrote: >>> >>> It seems a bit bizarre that exceptions are logged at INFO rather than >>> ERROR... >> >> Agreed. A simple fix and test on a branch would be appreciated. > > Done: > > http://svn.zope.org/ZODB/branches/chrisw-error_logging/ > > It would be great if this, too, could make it in a 3.9.4 release... > > Chris > > -- > Simplistix - Content Management, Batch Processing & Python Consulting > - http://www.simplistix.co.uk > -- Jim Fulton ___ For more information about ZODB, see the ZODB Wiki: http://www.zope.org/Wikis/ZODB/ ZODB-Dev mailing list - ZODB-Dev@zope.org https://mail.zope.org/mailman/listinfo/zodb-dev
Re: [ZODB-Dev] errors logged at info in ZEO's connection
Jim Fulton wrote: >> It seems a bit bizarre that exceptions are logged at INFO rather than >> ERROR... > > Agreed. A simple fix and test on a branch would be appreciated. Done: http://svn.zope.org/ZODB/branches/chrisw-error_logging/ It would be great if this, too, could make it in a 3.9.4 release... Chris -- Simplistix - Content Management, Batch Processing & Python Consulting - http://www.simplistix.co.uk ___ For more information about ZODB, see the ZODB Wiki: http://www.zope.org/Wikis/ZODB/ ZODB-Dev mailing list - ZODB-Dev@zope.org https://mail.zope.org/mailman/listinfo/zodb-dev
Re: [ZODB-Dev] errors logged at info in ZEO's connection
On Fri, Nov 20, 2009 at 3:15 PM, Chris Withers wrote:
> Hi All (although I guess predominantly Jim),
>
> ZEO/zprc/connection.py contains this rather odd piece of code:
>
> raise
> except Exception, msg:
> if not isinstance(msg, self.unlogged_exception_types):
> self.log("%s() raised exception: %s" % (name, msg),
> logging.INFO, exc_info=True)
>
> Any objections to me changing this on the 3.9 branch and trunk to:
>
> raise
> except Exception, msg:
> if not isinstance(msg, self.unlogged_exception_types):
> self.logger.exception(
> "%s() raised exception: %s" % (name, msg),
> )
>
> ...and making sure there's a test of some sort that demonstrates this?
Yes, I object on 2 levels.
First, as I said earlier, all check ins must go into branches for my
review and merge. The branch should be from the 3.9 branch.
Second, the change should simply change the level passed to self.log.
The log method adds a log label that can be very useful.
> It seems a bit bizarre that exceptions are logged at INFO rather than
> ERROR...
Agreed. A simple fix and test on a branch would be appreciated.
Jim
--
Jim Fulton
___
For more information about ZODB, see the ZODB Wiki:
http://www.zope.org/Wikis/ZODB/
ZODB-Dev mailing list - ZODB-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zodb-dev
