Re: [ZODB-Dev] zodbpickle claim (but OS X is not unix)
On 7/4/13 9:40 PM, Tres Seaver wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/04/2013 11:52 AM, Stephan Richter wrote: On Thursday, July 04, 2013 05:47:39 AM Christian Tismer wrote: there is now a pull request, completely tested on OS X, ready to be applied with no other work involved. Yeah, I saw that. thanks. It would be nice if that version could be uploaded, soon, so that I can close this issue and move on. ;-) Yeah, I just want Tres and/or Jim to weigh in, since they did the last iterations on this code. And you know, we have Independence Day today, so this week might be a little bit tough. ;-) I've done some review on Christian's PR: he is preparing some additional changes. Can somebody please have a look, again? I think it is now very complete, everythink updated. In addition, it adds two little convenience modules 'fastpickle' and 'slowpickle' which I will use for my projects. Let me know what you think, please. ciao - chris -- Christian Tismer :^) mailto:tis...@stackless.com Software Consulting : Have a break! Take a ride on Python's Karl-Liebknecht-Str. 121 :*Starship* http://starship.python.net/ 14482 Potsdam: PGP key - http://pgp.uni-mainz.de phone +49 173 24 18 776 fax +49 (30) 700143-0023 PGP 0x57F3BF04 9064 F4E1 D754 C2FF 1619 305B C09C 5A3B 57F3 BF04 whom do you want to sponsor today? http://www.stackless.com/ ___ For more information about ZODB, see http://zodb.org/ ZODB-Dev mailing list - ZODB-Dev@zope.org https://mail.zope.org/mailman/listinfo/zodb-dev
Re: [ZODB-Dev] zodbpickle claim (but OS X is not unix)
On 04.07.13 17:52, Stephan Richter wrote: On Thursday, July 04, 2013 05:47:39 AM Christian Tismer wrote: there is now a pull request, completely tested on OS X, ready to be applied with no other work involved. Yeah, I saw that. thanks. It would be nice if that version could be uploaded, soon, so that I can close this issue and move on. ;-) Yeah, I just want Tres and/or Jim to weigh in, since they did the last iterations on this code. And you know, we have Independence Day today, so this week might be a little bit tough. ;-) Thanks guys, and keep up the good work Thank you for using/testing zodbpickle and sending us the patch. BTW, are you using zodbpickle by itself to create Py2/3 compatible code? Hi Stephan, I am reviving Durus right now as my super pickle for the pocket, and don't want to stay stuck on protocol 2, incompatibility with the python version etc. . Personally, I have moved my projects to Py3.3, but a database is a different thing that should really not suffer from that. After some hacking, I realized that the problem is not so trivial, and fortunately found zodbpickle. So I thought that is the way to go, contribute a bit and use it. I'm working on BTree forests for a versioned, read-only database, and those versions come every two weeks, but I want to keep them all in the same database without keeping redundant data. That got me to the forest idea. First thing I was looking into was the B+Tree impl. of Zodb, but that was too much for me to change just for a prototype, because of all the optimized C code. And also the bucket pointers of B+Tree are disturbing a bit, because every bucket/subtree can be part of many trees, so I have to think how that should be. But in the end I agree that Zodb is the real thing, and I will eventually move there, when my forests prove useful and working. Oh, back on the question: Yes! We will use zodbpickle for all persistence stuff. And I want python.org to incorporate these patches, because I think that would help everyone. Why don't they want that small change? cheers - Chris -- Christian Tismer :^) mailto:tis...@stackless.com Software Consulting : Have a break! Take a ride on Python's Karl-Liebknecht-Str. 121 :*Starship* http://starship.python.net/ 14482 Potsdam: PGP key - http://pgp.uni-mainz.de phone +49 173 24 18 776 fax +49 (30) 700143-0023 PGP 0x57F3BF04 9064 F4E1 D754 C2FF 1619 305B C09C 5A3B 57F3 BF04 whom do you want to sponsor today? http://www.stackless.com/ ___ For more information about ZODB, see http://zodb.org/ ZODB-Dev mailing list - ZODB-Dev@zope.org https://mail.zope.org/mailman/listinfo/zodb-dev
Re: [ZODB-Dev] zodbpickle claim (but OS X is not unix)
Hi Stefan, fine with me. I have the patch working. Will complete the 3.3 module, update the doap record to 0.5.1 and submit a pull request this evening. All the best - chris Sent from my Ei4Steve On Jul 3, 2013, at 2:09, Stephan Richter stephan.rich...@gmail.com wrote: Hi Christian, On Wednesday, July 03, 2013 01:01:14 AM Christian Tismer wrote: I would appreciate if that simple-to-fix bug could be removed, and I would be happy to help with this. I am not a C expert, so I cannot comment. And while we are at it: How about completion of the module, to let it define standard things like DEFAULT_PROTOCOL ? Or is there a reason to avoid this (because Python2 doesn't have it)? We might have simply forgotten it. Also, we started Python 3.2's version, if I remember correctly, maybe it was missing there as well? Please don't get me wrong, I really like that module and want it to set the standard. Hey, not at all. You can clone the git repo, make the fix and create a pull request. We (as in the Zope devs) have been pretty good about merging in pull requests after quick reviews. I really want to be zodbpickle to be rock-solid as well, since we need it for the Python 3 ports to go ahead. Regards, Stephan -- Entrepreneur and Software Geek Google me. Zope Stephan Richter ___ For more information about ZODB, see http://zodb.org/ ZODB-Dev mailing list - ZODB-Dev@zope.org https://mail.zope.org/mailman/listinfo/zodb-dev
Re: [ZODB-Dev] zodbpickle claim (but OS X is not unix)
On 03.07.13 00:41, Christian Tismer wrote: sorry, I hit the send button while refining my text. Here it goes: So on OS X Mountain lion, I get with $ pip install zodbpickle: cc -fno-strict-aliasing -fno-common -dynamic -I/usr/local/include -I/usr/local/opt/sqlite/include -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I/usr/local/Cellar/python/2.7.5/Frameworks/Python.framework/Versions/2.7/include/python2.7 -c src/zodbpickle/_pickle_27.c -o build/temp.macosx-10.8-x86_64-2.7/src/zodbpickle/_pickle_27.o src/zodbpickle/_pickle_27.c:6254:13: error: void function 'init_pickle' should not return a value [-Wreturn-type] return -1; ^ ~~ src/zodbpickle/_pickle_27.c:6259:13: error: void function 'init_pickle' should not return a value [-Wreturn-type] return -1; ^ ~~ 2 errors generated. error: command 'cc' failed with exit status 1 I would appreciate if that simple-to-fix bug could be removed, and I would be happy to help with this. And while we are at it: How about completion of the module, to let it define standard things like DEFAULT_PROTOCOL ? Or is there a reason to avoid this (because Python2 doesn't have it)? Please don't get me wrong, I really like that module and want it to set the standard. Cheers -- chris -- Christian Tismer :^) mailto:tis...@stackless.com Software Consulting : Have a break! Take a ride on Python's Karl-Liebknecht-Str. 121 :*Starship* http://starship.python.net/ 14482 Potsdam: PGP key - http://pgp.uni-mainz.de phone +49 173 24 18 776 fax +49 (30) 700143-0023 PGP 0x57F3BF04 9064 F4E1 D754 C2FF 1619 305B C09C 5A3B 57F3 BF04 whom do you want to sponsor today? http://www.stackless.com/ ___ For more information about ZODB, see http://zodb.org/ ZODB-Dev mailing list - ZODB-Dev@zope.org https://mail.zope.org/mailman/listinfo/zodb-dev
Re: [ZODB-Dev] zodbpickle claim (but OS X is not unix)
Hi Christian, On Wednesday, July 03, 2013 01:01:14 AM Christian Tismer wrote: I would appreciate if that simple-to-fix bug could be removed, and I would be happy to help with this. I am not a C expert, so I cannot comment. And while we are at it: How about completion of the module, to let it define standard things like DEFAULT_PROTOCOL ? Or is there a reason to avoid this (because Python2 doesn't have it)? We might have simply forgotten it. Also, we started Python 3.2's version, if I remember correctly, maybe it was missing there as well? Please don't get me wrong, I really like that module and want it to set the standard. Hey, not at all. You can clone the git repo, make the fix and create a pull request. We (as in the Zope devs) have been pretty good about merging in pull requests after quick reviews. I really want to be zodbpickle to be rock-solid as well, since we need it for the Python 3 ports to go ahead. Regards, Stephan -- Entrepreneur and Software Geek Google me. Zope Stephan Richter ___ For more information about ZODB, see http://zodb.org/ ZODB-Dev mailing list - ZODB-Dev@zope.org https://mail.zope.org/mailman/listinfo/zodb-dev
