Re: [zones-discuss] code review: native brand refactoring

2008-05-23 Thread Joerg Barfurth
Hi, I just stumbled over this: Edward Pilatowicz schrieb: - nit: in start_zoneadmd(), instead of: if ((child_pid = fork()) == -1) { zperror(gettext(could not fork)); goto out; } else if (child_pid == 0) { ... _exit(1);

Re: [zones-discuss] Solaris 8 and Solaris 9 containers in OpenSolaris

2008-05-23 Thread Robert Milkowski
Hello Jerry, Thursday, May 22, 2008, 3:40:13 PM, you wrote: JJ Bernd Schemmer wrote: Can I use Solaris 8 and Solaris 9 Containers in OpenSolaris? I installed the packages for both but could not create a Solaris 8 or Solaris 9 zone. zonecfg always complained about a not supported brand.

Re: [zones-discuss] code review: native brand refactoring

2008-05-23 Thread Steve Lawrence
It seems to me that the first comment in the NOTES section of fork(2) would only apply to vfork(). ?? -Steve On Fri, May 23, 2008 at 01:31:58PM +0200, Joerg Barfurth wrote: Hi, I just stumbled over this: Edward Pilatowicz schrieb: - nit: in start_zoneadmd(), instead of: if

Re: [zones-discuss] code review: native brand refactoring

2008-05-23 Thread Mike Oliver
Steve Lawrence wrote: It seems to me that the first comment in the NOTES section of fork(2) would only apply to vfork(). It's true that the comment that exit() will damage the parent's stdio data structures applies only to the vfork() case. However, you should still call _exit() even in the

Re: [zones-discuss] code review: native brand refactoring

2008-05-23 Thread Jerry Jelinek
Ed, My responses are in-line. Edward Pilatowicz wrote: On Wed, May 21, 2008 at 09:43:27AM -0600, Jerry Jelinek wrote: Thanks again for your input. I am rebuilding and retesting with these changes. Once that is done, I'll post an updated webrev. i couldn't wait. :) more comments are