Jerry Jelinek wrote: > > I have a first cut at p2v for native zones. > This is: > > 6667924 physical to virtual utility for native zones > PSARC 2008/766 native zones p2v > > There is a webrev at: > > http://cr.opensolaris.org/~gjelinek/webrev.p2v/
Quick look at http://cr.opensolaris.org/~gjelinek/webrev.p2v/on.patch (patch code is quoted with "> "): > +# Check for a non-empty root. > +# > +cnt=`ls $install_root | wc -l` Plese use $(...) instead of `...` (see http://www.opensolaris.org/os/project/shell/shellstyle/#use_posix_subshell_syntax). > +if [ $cnt -ne 0 ]; then Please use arithmetric expressions to compare numbers, e.g. -- snip -- if (( cnt != 0 )) ; then -- snip -- (see http://www.opensolaris.org/os/project/shell/shellstyle/#use_posix_arithmetic_expressions) > + screenlog "$root_full" "$install_root" > + exit $int_code > +fi "p2v.ksh" triggers lots of warnings when scanned via $ shlint p2v.ksh # (or as substitute use $ ksh93 -n p2v.ksh #): -- snip -- $ shlint p2v.ksh p2v.ksh: warning: line 48: `...` obsolete, use $(...) p2v.ksh: warning: line 48: `...` obsolete, use $(...) p2v.ksh: warning: line 65: `...` obsolete, use $(...) p2v.ksh: warning: line 65: `...` obsolete, use $(...) p2v.ksh: warning: line 75: `...` obsolete, use $(...) p2v.ksh: warning: line 75: `...` obsolete, use $(...) p2v.ksh: warning: line 84: -ne within [[...]] obsolete, use ((...)) p2v.ksh: warning: line 143: `...` obsolete, use $(...) p2v.ksh: warning: line 145: -ne within [[...]] obsolete, use ((...)) p2v.ksh: warning: line 152: `...` obsolete, use $(...) p2v.ksh: warning: line 153: -ne within [[...]] obsolete, use ((...)) p2v.ksh: warning: line 158: `...` obsolete, use $(...) p2v.ksh: warning: line 159: -ne within [[...]] obsolete, use ((...)) p2v.ksh: warning: line 164: `...` obsolete, use $(...) p2v.ksh: warning: line 185: `...` obsolete, use $(...) p2v.ksh: warning: line 222: -eq within [[...]] obsolete, use ((...)) p2v.ksh: warning: line 264: -eq within [[...]] obsolete, use ((...)) p2v.ksh: warning: line 299: `...` obsolete, use $(...) p2v.ksh: warning: line 303: `...` obsolete, use $(...) p2v.ksh: warning: line 313: `...` obsolete, use $(...) p2v.ksh: warning: line 340: -eq within [[...]] obsolete, use ((...)) p2v.ksh: warning: line 349: `...` obsolete, use $(...) p2v.ksh: warning: line 371: -eq within [[...]] obsolete, use ((...)) p2v.ksh: warning: line 379: -eq within [[...]] obsolete, use ((...)) p2v.ksh: warning: line 387: `...` obsolete, use $(...) p2v.ksh: warning: line 417: `...` obsolete, use $(...) p2v.ksh: warning: line 477: `...` obsolete, use $(...) p2v.ksh: warning: line 490: `...` obsolete, use $(...) p2v.ksh: warning: line 546: -lt within [[...]] obsolete, use ((...)) p2v.ksh: warning: line 548: -gt within [[...]] obsolete, use ((...)) p2v.ksh: warning: line 639: -ne within [[...]] obsolete, use ((...)) p2v.ksh: warning: line 676: -ne within [[...]] obsolete, use ((...)) p2v.ksh: warning: line 691: -ne within [[...]] obsolete, use ((...)) p2v.ksh: warning: line 713: -ne within [[...]] obsolete, use ((...)) p2v.ksh: warning: line 726: -eq within [[...]] obsolete, use ((...)) p2v.ksh: warning: line 732: -ne within [[...]] obsolete, use ((...)) -- snip -- "image_install.ksh" has similar problems: -- snip -- image_install.ksh: warning: line 37: `...` obsolete, use $(...) image_install.ksh: warning: line 37: `...` obsolete, use $(...) image_install.ksh: warning: line 50: `...` obsolete, use $(...) image_install.ksh: warning: line 50: `...` obsolete, use $(...) image_install.ksh: warning: line 60: `...` obsolete, use $(...) image_install.ksh: warning: line 60: `...` obsolete, use $(...) image_install.ksh: warning: line 159: `...` obsolete, use $(...) image_install.ksh: warning: line 164: `...` obsolete, use $(...) image_install.ksh: warning: line 326: -ne within [[...]] obsolete, use ((...)) image_install.ksh: warning: line 336: Invariant test image_install.ksh: warning: line 347: '=' obsolete, use '==' image_install.ksh: warning: line 355: '=' obsolete, use '==' image_install.ksh: warning: line 359: '=' obsolete, use '==' image_install.ksh: warning: line 366: '=' obsolete, use '==' image_install.ksh: warning: line 385: '=' obsolete, use '==' image_install.ksh: warning: line 390: '=' obsolete, use '==' image_install.ksh: warning: line 396: '=' obsolete, use '==' image_install.ksh: warning: line 409: '=' obsolete, use '==' image_install.ksh: warning: line 414: `...` obsolete, use $(...) image_install.ksh: warning: line 414: `...` obsolete, use $(...) image_install.ksh: warning: line 418: '=' obsolete, use '==' image_install.ksh: warning: line 440: '=' obsolete, use '==' image_install.ksh: warning: line 448: -ne within [[...]] obsolete, use ((...)) image_install.ksh: warning: line 495: -lt within [[...]] obsolete, use ((...)) image_install.ksh: warning: line 576: `...` obsolete, use $(...) image_install.ksh: warning: line 576: `...` obsolete, use $(...) image_install.ksh: warning: line 581: -a obsolete, use -e image_install.ksh: warning: line 629: -ne within [[...]] obsolete, use ((...)) image_install.ksh: warning: line 638: `...` obsolete, use $(...) image_install.ksh: warning: line 638: `...` obsolete, use $(...) image_install.ksh: warning: line 685: `...` obsolete, use $(...) image_install.ksh: warning: line 711: '=' obsolete, use '==' image_install.ksh: warning: line 719: '=' obsolete, use '==' image_install.ksh: warning: line 724: '=' obsolete, use '==' image_install.ksh: warning: line 729: '=' obsolete, use '==' image_install.ksh: warning: line 737: '=' obsolete, use '==' image_install.ksh: warning: line 744: '=' obsolete, use '==' image_install.ksh: warning: line 746: `...` obsolete, use $(...) image_install.ksh: warning: line 746: `...` obsolete, use $(...) image_install.ksh: warning: line 754: '=' obsolete, use '==' image_install.ksh: warning: line 765: '=' obsolete, use '==' image_install.ksh: warning: line 768: `...` obsolete, use $(...) image_install.ksh: warning: line 786: -eq within [[...]] obsolete, use ((...)) image_install.ksh: warning: line 788: -ne within [[...]] obsolete, use ((...)) image_install.ksh: warning: line 824: -eq within [[...]] obsolete, use ((...)) -- snip -- IMO it would be nice to fix that... ---- Bye, Roland -- __ . . __ (o.\ \/ /.o) roland.ma...@nrubsig.org \__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer /O /==\ O\ TEL +49 641 3992797 (;O/ \/ \O;) _______________________________________________ zones-discuss mailing list zones-discuss@opensolaris.org
