[zones-discuss] Code review for zones support in SNAP (updated)
Joe, Jean, Jerry, Thanks for providing your comments. We've built an incremental webrev with just the changes from your comments. This webrev also includes a couple of dev bugfixes that went in during the code review process - 3776, 3772 Any further comments are welcomed. http://cr.opensolaris.org/~equach/webrev.snap_zones.2 As a reference, we've also refreshed the overall webrev here: http://cr.opensolaris.org/~equach/webrev.3686 Thanks again for the review, -ethan ___ zones-discuss mailing list zones-discuss@opensolaris.org
Re: [zones-discuss] Code review for zones support in SNAP (updated)
Ethan Quach wrote: Joe, Jean, Jerry, Thanks for providing your comments. We've built an incremental webrev with just the changes from your comments. This webrev also includes a couple of dev bugfixes that went in during the code review process - 3776, 3772 Any further comments are welcomed. http://cr.opensolaris.org/~equach/webrev.snap_zones.2 As a reference, we've also refreshed the overall webrev here: http://cr.opensolaris.org/~equach/webrev.3686 Thanks again for the review, -ethan This all looks good. I only found one small nit. Joe usr/src/lib/libbe/be_create.c +-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+ Issue: -- Typo-s in comment: Change from: 1004 * root dataset of the new BE. The uuid is use to set the parentbe 1005 * property for the new zones datasets. To: 1004 * root dataset of the new BE. The uuid is used to set the parent be 1005 * property for the new zones datasets. ___ zones-discuss mailing list zones-discuss@opensolaris.org
Re: [zones-discuss] Code review for zones support in SNAP (updated)
Joe, Thanks. We'll make that correction. -ethan Joseph J VLcek wrote: Ethan Quach wrote: Joe, Jean, Jerry, Thanks for providing your comments. We've built an incremental webrev with just the changes from your comments. This webrev also includes a couple of dev bugfixes that went in during the code review process - 3776, 3772 Any further comments are welcomed. http://cr.opensolaris.org/~equach/webrev.snap_zones.2 As a reference, we've also refreshed the overall webrev here: http://cr.opensolaris.org/~equach/webrev.3686 Thanks again for the review, -ethan This all looks good. I only found one small nit. Joe usr/src/lib/libbe/be_create.c +-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+ Issue: -- Typo-s in comment: Change from: 1004 * root dataset of the new BE. The uuid is use to set the parentbe 1005 * property for the new zones datasets. To: 1004 * root dataset of the new BE. The uuid is used to set the parent be 1005 * property for the new zones datasets. ___ zones-discuss mailing list zones-discuss@opensolaris.org
